OpenCPN RC 4.1.1301 Release

[nohal]

Originally Posted by boat_alexandra

Maybe 4.2 should be built with svg support disabled.

Sean...
Could you elaborate a bit on the reason? As far as I can tell, nobody reports the SVG stuff broken from user's point of view.
I also myself haven't seen any asserts, but will look for them harder.

Pavel


Sent from my iPhone using Cruisers Sailing Forum

[Gilletarom]

Hello,
EeePC 10inch, Linux Ubuntu. Chardownloader

Originally Posted by Gilletarom

Transmitterdan,
1° Yes, the mouse run normally.
2° It was at the end of this action the mouse pointer becomes the spinning wheel and remains there permanently.

And also :
1° Open chartdownloader
2° Clic "Add"
3° Choice by example "Belgium Inland ENC charts"
4° Validate your choice
5° You can see that the mouse pointer is the wheel .... (At this moment, I do not clic on "Update the choice".)

And Also, not with chartdownloader :
1° run O
2° Options/advance
3° I was OpenGL ON. I unclick the checkbox and now I am OpenGL OFF. The mouse pointer is the wheel ....

[Gilletarom]

Dave,

Tablet 10 inch, W10. O411301.
1° How is it possible to enlarge size character of the 5 item of the menu bar ?
2° Is it possible to create distance more than now from each item of the menu bar. And this, because, with a thinger, it is not easy to select the one that we want.

It is also very difficult to select a command in the all the context menu with a thinger. is it possible to enlarge the distance between 2 lines in context menu ?

[transmitterdan]

Originally Posted by nohal

Sean...
Could you elaborate a bit on the reason? As far as I can tell, nobody reports the SVG stuff broken from user's point of view.
I also myself haven't seen any asserts, but will look for them harder.

Pavel


Sent from my iPhone using Cruisers Sailing Forum

I have run .1301 under Windows in debug mode a lot (hours and hours) without any SVG related asserts. I test with NMEA data streaming into O to simulate real cruising conditions. I routinely see only one assert when closing the options dialog box. The assert is telling that the wxBusy state is not busy when a call to release busy state is made. I think this assert is harmless. But Gilaterom has a tablet running Win 10 that does not release busy state when it should. However I don't think this is related to SVG and I cannot reproduce.

Another way I can get several asserts at least under Win 10 is to run non-debug built plugins from a debug enabled core. I don't understand why this is so. But if I run everything either consistently built with debug or release then no strange asserts at least on Win 10.

[ptulp]

I think that function ChartDldrPrefsDlgImpl::OnOkClick in file chartdldr_pi.cpp needs the EndModal call to fix the problem mentioned in message #12.

Peter

void ChartDldrPrefsDlgImpl::OnOkClick( wxCommandEvent& event )
{
if( !wxDirExists(m_tcDefaultDir->GetValue()) )
if( !wxFileName::Mkdir(m_tcDefaultDir->GetValue(), 0755, wxPATH_MKDIR_FULL) )
{
wxMessageBox(wxString::Format(_("Directory %s can't be created."), m_tcDefaultDir->GetValue().c_str()), _("Chart Downloader"));
return;
}
event.Skip();
EndModal( wxID_OK );
}

[seandepagnier]

Originally Posted by nohal

Sean...
Could you elaborate a bit on the reason? As far as I can tell, nobody reports the SVG stuff broken from user's point of view.
I also myself haven't seen any asserts, but will look for them harder.

Pavel


Sent from my iPhone using Cruisers Sailing Forum

I get lots of compile errors on my raspberry pi unless I disable svg


All these extra libraries are great, but I wish to somehow break the support libraries like curl, tinyxml or svg etc... out of the tree because I don't have a hardware clock and often this forces accidentally making me rebuild everything which takes about an hour. Also when I am editing cmakelist it must now rebuild all these support libraries and it takes forever when I am bisecting with git because it must again rebuild these support libraries for every step which have nothing to do with the bug I am on.

For example, to fix a recent I was compiling all day long for two days.

[nohal]

Originally Posted by boat_alexandra

I get lots of compile errors on my raspberry pi unless I disable svg

Interesting, the ARM builds on Launchpad don't show any problem there...

All these extra libraries are great, but I wish to somehow break the support libraries like curl, tinyxml or svg etc... out of the tree because I don't have a hardware clock and often this forces accidentally making me rebuild everything which takes about an hour. Also when I am editing cmakelist it must now rebuild all these support libraries and it takes forever when I am bisecting with git or something.

If you are not directly working on the SVG stuff, it can be trivially disabled completely with -DOCPN_USE_SVG=OFF cmake parameter, I suppose it should be doable for you. If we break the tree, most of the people now being able to get it built will again have problem to do so, as they do with every single architectural change we do, unfortunately.

Pavel

[did-g]

Dave...

Originally Posted by bdbcat

did-g...

re:
I agree with your analysis. This sure looks to me like a bug in wxWidgets/gtk.

Looks like we have trouble in two places:

1. chcanv.cpp Grid display.
2. S52PLIB text display.

All other instances of FindOrCreateFont() are one-time, or infrequently called. So not much resource impact. But these two are are called lots, and generate a new font every time.

(1) is easy to fix. We just cache the font in the chart canvas class. I'll do that.

(2) is more trouble. I guess the correct solution is to implement our own fontlist in the S52PLIB, and emulate the function of FindorCreateFont().

Any other ideas?

Dave

No other ideas, wxTheFontList is 100 % broken the cache rarely round-trip.

I push a PR for 2 but it's a partial fix, on linux it still doesn't round trip on some fonts: "arial" , "helvetica" and for some encoding. There's a wxASSERT for testing but we can't keep it. A proper fix must keep in the cache all FindorCreateFont parameters. Don't know if it's worth the pain.

BTW do you remember why there's a wxFONTENCODING_ISO8859_1 in concanv.cpp?

[wdkester]

Is the chart scale slider in this release? If so, how do you activate it?

[did-g]

Originally Posted by Gilletarom

Hello,
EeePC 10inch, Linux Ubuntu. Chardownloader


And Also, not with chartdownloader :
1° run O
2° Options/advance
3° I was OpenGL ON. I unclick the checkbox and now I am OpenGL OFF. The mouse pointer is the wheel ....

Maybe http://www.cruisersforum.com/forums/...ml#post2005059 ?

Could you double your wx version? 2.8, 3.0 or 3.0.2.

[bdbcat]

@jon...

re: SVG asserts...

With SVG enabled, do you repeatably get the initial ASSERT described above? Or only sometimes?

Thanks
Dave

[did-g]

Originally Posted by bdbcat

@jon...

re: SVG asserts...

With SVG enabled, do you repeatably get the initial ASSERT described above? Or only sometimes?

Thanks
Dave

hi,
There's a lot of stop without color in ocpn svg file and the lib doesn't set them by default.
from the spec it should be black;
slower but no assert:

diff --git a/src/wxsvg/src/SVGCanvas.cpp b/src/wxsvg/src/SVGCanvas.cpp
index df1f59b..5dd8679 100644
--- a/src/wxsvg/src/SVGCanvas.cpp
+++ b/src/wxsvg/src/SVGCanvas.cpp
@@ -180,9 +180,14 @@ unsigned int wxSVGCanvas::GetGradientStops(const wxSVGSVGElement& svgElem, wxSVG
        stop_elem = (wxSVGStopElement*) gradElem->GetChildren();
        int i = 0;
        while (stop_elem) {
-               if (stop_elem->GetDtd() == wxSVG_STOP_ELEMENT)
+               if (stop_elem->GetDtd() == wxSVG_STOP_ELEMENT) {
+                       wxSVGColor color = stop_elem->GetStopColor();
+                       //
+                       if (color.GetColorType() == wxSVG_COLORTYPE_UNKNOWN)
+                                color = wxSVGColor(0,0,0);
                        SetStopValue(i++, stop_elem->GetOffset(), stop_elem->GetStopOpacity() * opacity,
-                                       stop_elem->GetStopColor().GetRGBColor());
+                                       color.GetRGBColor());
+                }
                stop_elem = (wxSVGStopElement*) stop_elem->GetNext();
        }
        return stop_count;

[ChuckSK]

When OpenCPN is started with a vertical toolbar in Journeyman style the gps indicator is distorted.


vs

[ChuckSK]

Originally Posted by ChuckSK

When OpenCPN is started with a vertical toolbar in Journeyman style the gps indicator is distorted.

Just submitted a pull request that fixes this.

[jongough]

Dave,
I got the errors, quite a large number, at startup so I told the system to continue and not tell me any more. I have just downloaded 'afbfeb9' and rebuilt and am still getting the error.

If I tell the system to continue and not notify me of the same errors I get over 81 of these before I get the main OCPN screen displayed. The same 3 messages are displayed over and over:

../src/gtk/colour.cpp(207): assert "IsOk()" failed in Blue(): invalid colour
../src/gtk/colour.cpp(196): assert "IsOk()" failed in Green(): invalid colour
../src/gtk/colour.cpp(185): assert "IsOk()" failed in Red(): invalid colour

When I closed OCPN I got a further 54 of these messages.

These errors always occur when I have SVG enabled.

Jon

Originally Posted by bdbcat

@jon...

re: SVG asserts...

With SVG enabled, do you repeatably get the initial ASSERT described above? Or only sometimes?

Thanks
Dave