OpenCPN Beta test 4.1.1108 Release

[transmitterdan]

Originally Posted by LeaseOnLife

Did you leave it running for a longer time?

I compiled your git master, including your #482, but see no change in performance on my linux box. As with any other I tried, it is fine @10 min runtime with ~20000 targets but gets worse from there while the target count increases only slightly:

• 17:04 start opencpn from transmitterdan
• 17:11 40% CPU, 19815 targets
• 17:15 60% CPU, 20938 targets
• 17:21 80% CPU, 22057 targets
• 17:26 95% CPU, 22647 targets

There is a bug in my git. I am fixing it and will make a new post when ready to test.

[bdbcat]

Gilletarom...

re:
"But I can not enlarge the font size in the window of the list of AIS targets.

Who can tell me what to do?"

The font size of the AIS Target List is controlled by text element "Dialog", in the Settings->User Interface panel.

Tested, works for me.
Dave

[bdbcat]

TDan, et al...

I have pushed a commit which greatly improves the performance of AIS target processing. Refactored a loop running at nearly oN2. Now handles 20K+ targets on linux without stuttering.

There is more performance work to do here, all in due course.

Meanwhile, please beat on this with a stick! Bring on the huge data sets.

Many thanks to all who worked this one, especially TDan.

btw,
I used the Python VDRplayer from TDan.
https://github.com/transmitterdan/VDRplayer

Very cool tool. Recommended.

Thanks
Dave

[Hakan]

Today's pull Win10, VS2013

Although I haven't' stressed the new AIS handling by lots of targets it runs fine.
One personal comment:
The new COG predictor line in OpenGL mode is a bit "fat" and dominating. Also is the red color not clearly visible on the alerted line. See right hand picture where the red circle is fine but not the line.
If I try to play with AISCOGPredictorWidth in config file it's obvious the line consists of two parts, one colored and one black part:
AISCOGPredictorWidth=1 gives a very tiny green(red) line
AISCOGPredictorWidth=2 gives a fat black line with a green(red) shadow.
AISCOGPredictorWidth=3 gives a fatter black. (Pic 2)

Note, the left pic is from before this git update.
Håkan

[rooiedirk]

Hm Compiling goes fine, but when running I getLinux Mint17 64

../src/common/glcmn.cpp(59): assert "IsShownOnScreen()" failed in SetCurrent(): can't make hidden GL canvas current

the backtrace:

ASSERT INFO:
../src/common/glcmn.cpp(59): assert "IsShownOnScreen()" failed in SetCurrent(): can't make hidden GL canvas current

BACKTRACE:
[1] wxGLCanvasBase::SetCurrent(wxGLContext const&) const
[2] glChartCanvas::OnSize(wxSizeEvent&) /home/dirk/Development/OpenCPN/OpenCPN_RooieDirk/OpenCPN/src/glChartCanvas.cpp:916
[3] ChartCanvas::OnSize(wxSizeEvent&) /home/dirk/Development/OpenCPN/OpenCPN_RooieDirk/OpenCPN/src/chcanv.cpp:4506
[4] wxAppConsoleBase::CallEventHandler(wxEvtHandler*, wxEventFunctor&, wxEvent&) const
[5] wxEvtHandler::ProcessEventIfMatchesId(wxEventTableEntryBase const&, wxEvtHandler*, wxEvent&)
[6] wxEventHashTable::HandleEvent(wxEvent&, wxEvtHandler*)
[7] wxEvtHandler::TryHereOnly(wxEvent&)
[8] wxEvtHandler::ProcessEventLocally(wxEvent&)
[9] wxEvtHandler::ProcessEvent(wxEvent&)
[10] wxEvtHandler::SafelyProcessEvent(wxEvent&)
[11] wxWindow::DoSetSize(int, int, int, int, int)
[12] wxWindowBase::SetSize(int, int, int, int, int) /usr/include/wx-3.0/wx/window.h:259
[13] MyFrame::ODoSetSize() /home/dirk/Development/OpenCPN/OpenCPN_RooieDirk/OpenCPN/src/chart1.cpp:3621
[14] MyFrame::OnSize(wxSizeEvent&) /home/dirk/Development/OpenCPN/OpenCPN_RooieDirk/OpenCPN/src/chart1.cpp:3516
[15] wxAppConsoleBase::CallEventHandler(wxEvtHandler*, wxEventFunctor&, wxEvent&) const
[16] wxEvtHandler::ProcessEventIfMatchesId(wxEventTableEntryBase const&, wxEvtHandler*, wxEvent&)
[17] wxEventHashTable::HandleEvent(wxEvent&, wxEvtHandler*)
[18] wxEvtHandler::TryHereOnly(wxEvent&)
[19] wxEvtHandler::DoTryChain(wxEvent&)
[20] wxEvtHandler::ProcessEvent(wxEvent&)
[21] wxEvtHandler::SafelyProcessEvent(wxEvent&)
[22] wxWindowBase::SendSizeEvent(int)
[23] MyFrame::ApplyGlobalSettings(bool, bool) /home/dirk/Development/OpenCPN/OpenCPN_RooieDirk/OpenCPN/src/chart1.cpp:4843
[24] MyApp::OnInit() /home/dirk/Development/OpenCPN/OpenCPN_RooieDirk/OpenCPN/src/chart1.cpp:1809
[25] wxAppConsoleBase::CallOnInit() /usr/include/wx-3.0/wx/app.h:93
[26] wxEntry(int&, wchar_t**)
[27] main /home/dirk/Development/OpenCPN/OpenCPN_RooieDirk/OpenCPN/src/chart1.cpp:821
[28] __libc_start_main
[29] _start

[seandepagnier]

Originally Posted by rooiedirk

Hm Compiling goes fine, but when running I getLinux Mint17 64[CODE]../src/common/glcmn.cpp(59): assert "IsShownOnScreen()" failed in SetCurrent(): can't make hidden GL canvas current

Please post log file

[rooiedirk]

The log:

2:20:17 CET: 2015-12-08
12:20:17 CET:  ------- Starting OpenCPN -------
12:20:17 CET: Version 4.1.1108 Build 2015-111-08
12:20:18 CET: wxWidgets version: wxWidgets 3.0.0 Linux 64 bit wxGTK
12:20:18 CET: MemoryStatus:  mem_total: 15415 mb,  mem_initial: 29 mb
12:20:18 CET: SData_Locn is /usr/local/share/opencpn/
12:20:18 CET: PrivateDataDir is /home/dirk/.opencpn
12:20:18 CET: Using existing Config_File: /home/dirk/.opencpn/opencpn.conf
12:20:18 CET: Setting Viewpoint Lat/Lon 53.8972, -0.0837
12:20:18 CET: Setting Ownship Lat/Lon 52.4655, 5.0381
12:20:18 CET: Styles loading from /usr/local/share/opencpn/uidata/styles.xml
12:20:18 CET: No styles found at: /home/dirk/
12:20:18 CET: No styles found at: /home/dirk/.opencpn/
12:20:18 CET: Detected display size (horizontal): 508 mm
12:20:18 CET: System default Language:  en_US
12:20:18 CET: Opencpn language set to:  en_US
12:20:18 CET: Creating MyFrame...size(1423, 721)  position(442, 93)
12:20:18 CET: Creating glChartCanvas

end of logfile

[seandepagnier]

Originally Posted by rooiedirk

Hm Compiling goes fine, but when running I getLinux Mint17 64[CODE]../src/common/glcmn.cpp(59): assert "IsShownOnScreen()" failed in SetCurrent(): can't make hidden GL canvas current

Please post log file

[rooiedirk]

Originally Posted by boat_alexandra

Please post log file

See Att.

[CarCode]

Originally Posted by rooiedirk

Hm Compiling goes fine, but when running I getLinux Mint17 64

../src/common/glcmn.cpp(59): assert "IsShownOnScreen()" failed in SetCurrent(): can't make hidden GL canvas current

the backtrace:

ASSERT INFO:
../src/common/glcmn.cpp(59): assert "IsShownOnScreen()" failed in SetCurrent(): can't make hidden GL canvas current

BACKTRACE:
[1] wxGLCanvasBase::SetCurrent(wxGLContext const&) const
[2] glChartCanvas::OnSize(wxSizeEvent&) /home/dirk/Development/OpenCPN/OpenCPN_RooieDirk/OpenCPN/src/glChartCanvas.cpp:916
[3] ChartCanvas::OnSize(wxSizeEvent&) /home/dirk/Development/OpenCPN/OpenCPN_RooieDirk/OpenCPN/src/chcanv.cpp:4506
[4] wxAppConsoleBase::CallEventHandler(wxEvtHandler*, wxEventFunctor&, wxEvent&) const
[5] wxEvtHandler::ProcessEventIfMatchesId(wxEventTableEntryBase const&, wxEvtHandler*, wxEvent&)
[6] wxEventHashTable::HandleEvent(wxEvent&, wxEvtHandler*)
[7] wxEvtHandler::TryHereOnly(wxEvent&)
[8] wxEvtHandler::ProcessEventLocally(wxEvent&)
[9] wxEvtHandler::ProcessEvent(wxEvent&)
[10] wxEvtHandler::SafelyProcessEvent(wxEvent&)
[11] wxWindow::DoSetSize(int, int, int, int, int)
[12] wxWindowBase::SetSize(int, int, int, int, int) /usr/include/wx-3.0/wx/window.h:259
[13] MyFrame::ODoSetSize() /home/dirk/Development/OpenCPN/OpenCPN_RooieDirk/OpenCPN/src/chart1.cpp:3621
[14] MyFrame::OnSize(wxSizeEvent&) /home/dirk/Development/OpenCPN/OpenCPN_RooieDirk/OpenCPN/src/chart1.cpp:3516
[15] wxAppConsoleBase::CallEventHandler(wxEvtHandler*, wxEventFunctor&, wxEvent&) const
[16] wxEvtHandler::ProcessEventIfMatchesId(wxEventTableEntryBase const&, wxEvtHandler*, wxEvent&)
[17] wxEventHashTable::HandleEvent(wxEvent&, wxEvtHandler*)
[18] wxEvtHandler::TryHereOnly(wxEvent&)
[19] wxEvtHandler::DoTryChain(wxEvent&)
[20] wxEvtHandler::ProcessEvent(wxEvent&)
[21] wxEvtHandler::SafelyProcessEvent(wxEvent&)
[22] wxWindowBase::SendSizeEvent(int)
[23] MyFrame::ApplyGlobalSettings(bool, bool) /home/dirk/Development/OpenCPN/OpenCPN_RooieDirk/OpenCPN/src/chart1.cpp:4843
[24] MyApp::OnInit() /home/dirk/Development/OpenCPN/OpenCPN_RooieDirk/OpenCPN/src/chart1.cpp:1809
[25] wxAppConsoleBase::CallOnInit() /usr/include/wx-3.0/wx/app.h:93
[26] wxEntry(int&, wchar_t**)
[27] main /home/dirk/Development/OpenCPN/OpenCPN_RooieDirk/OpenCPN/src/chart1.cpp:821
[28] __libc_start_main
[29] _start

The fault is commit e3f48200346d90f051b8daaf7e7e6d983d01814c.
Reason: IsShown() failed in SetCurrent(): can't make hidden GL canvas current. See function glChartCanvas::OnSize() in glChartCanvas.cpp.

Gerhard

[rooiedirk]

@Sean,
Please don't trouble any longer. Somehow my Git was corrupted
Dirk

[bdbcat]

Hakan...

re:
AIS COG predictor drawing change.

I quite agree. I have partially reverted the relevant commit, to improve the display in GL mode.

Thanks
Dave

[seandepagnier]

Originally Posted by bdbcat

Hakan...

re:
AIS COG predictor drawing change.

I quite agree. I have partially reverted the relevant commit, to improve the display in GL mode.

Thanks
Dave

Thanks for now, but eventually we should rework it to make the improved display efficient.

[Gilletarom]

Dave,

Originally Posted by Gilletarom

Dave,
...Compilation provided by Jean-Pierre today.

Look at the icon of the "toolbox". It is a curious phenomenon that has existed since the initial release 411108. The icon may be displayed in small, sometimes normal size. Just approach the mouse to the icon resumes its normal size.

I confirm. When I run O 411108, this phenomenon occur. It is as if there were two icons displayed one above the other, at startup.

Yesterday with OpenGL Off, this day with openGL ON.

Today with icon barr transparency ON or OFF.

Best regards.

[Hakan]

Dave
Thanks now of course back to "normal".
It's a bit sad we have to draw the line twice to get a good visibility but with the thin, one pixel, black it's far better then with only a colored line.
I tested with

if( g_ais_cog_predictor_width > 3 ) {
                        //    Draw a 1 pixel wide black line

But still to transparent a line.
So if no better idea then to draw it twice this is still the best looking solution.

Håkan