Beta Test / Technical

[bdbcat]

Hakan...

re:
All plugins and others disappeared...

Oops... Temporarily removed to speed up my local builds.
Fixed now in github.

Thanks
Dave

[Hakan]

Dave
Thanks - much better now

BTW: There are normally a couple of warnings first time build after a significant code update, like this. The dll linkage and M_PI are well known but there was more than usual this time, see below. All warnings are gone on next build, also as usual.

Warning    1    warning C4101: 'primitiveType' : unreferenced local variable    C:\Builds\OCPN\OpenCPN\src\Osenc.cpp    118    1    S57ENC
Warning    2    warning C4101: 'obj' : unreferenced local variable    C:\Builds\OCPN\OpenCPN\src\Osenc.cpp    116    1    S57ENC
Warning    3    warning C4101: 'geoType' : unreferenced local variable    C:\Builds\OCPN\OpenCPN\src\Osenc.cpp    836    1    S57ENC
Warning    4    warning C4101: 'temp' : unreferenced local variable    C:\Builds\OCPN\OpenCPN\src\Osenc.cpp    1148    1    S57ENC
Warning    5    warning C4101: 'line' : unreferenced local variable    C:\Builds\OCPN\OpenCPN\src\Osenc.cpp    2373    1    S57ENC
Warning    6    warning C4102: 'next' : unreferenced label    C:\Builds\OCPN\OpenCPN\src\chartsymbols.cpp    146    1    SYMBOLS
Warning    7    warning C4101: 'ptp' : unreferenced local variable    C:\Builds\OCPN\OpenCPN\src\s52plib.cpp    3894    1    S57ENC
Warning    8    warning C4101: 'npt' : unreferenced local variable    C:\Builds\OCPN\OpenCPN\src\s52plib.cpp    3895    1    S57ENC
Warning    9    warning C4101: 'ptp' : unreferenced local variable    C:\Builds\OCPN\OpenCPN\src\s52plib.cpp    4233    1    S57ENC
Warning    10    warning C4101: 'npt' : unreferenced local variable    C:\Builds\OCPN\OpenCPN\src\s52plib.cpp    4460    1    S57ENC
Warning    11    warning C4101: 'ppt' : unreferenced local variable    C:\Builds\OCPN\OpenCPN\src\s52plib.cpp    4485    1    S57ENC
Warning    12    warning C4101: 'nxx' : unreferenced local variable    C:\Builds\OCPN\OpenCPN\src\s57chart.cpp    5358    1    S57ENC
Warning    13    warning C4101: 'Tcpa' : unreferenced local variable    C:\Builds\OCPN\OpenCPN\src\ais.cpp    978    1    opencpn
Warning    14    warning C4005: 'M_PI' : macro redefinition    C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\include\math.h    1298    1    opencpn
Warning    15    warning C4150: deletion of pointer to incomplete type 'JobTicket'; no destructor called    C:\Builds\OCPN\OpenCPN\src\glTextureManager.cpp    53    1    opencpn
Warning    16    warning C4101: 'ssize' : unreferenced local variable    C:\Builds\OCPN\OpenCPN\src\glTextureManager.cpp    696    1    opencpn
Warning    17    warning C4390: ';' : empty controlled statement found; is this the intent?    C:\Builds\OCPN\OpenCPN\src\glTextureManager.cpp    999    1    opencpn
Warning    18    warning C4005: 'M_PI' : macro redefinition    C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\include\math.h    1298    1    opencpn
Warning    19    warning C4800: 'int' : forcing value to bool 'true' or 'false' (performance warning)    C:\Builds\OCPN\OpenCPN\src\options.cpp    5324    1    opencpn
Warning    20    warning C4273: 'wxEVT_DOWNLOAD_EVENT' : inconsistent dll linkage    C:\Builds\OCPN\OpenCPN\src\pluginmanager.cpp    5245    1    opencpn
Warning    21    warning C4723: potential divide by 0    c:\builds\ocpn\opencpn\src\options.cpp    6496    1    opencpn
Warning    22    warning C4005: 'M_PI' : macro redefinition    C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\include\math.h    1298    1    opencpn

It may be task for coming winter - what to do now - activity?
Håkan

[Hakan]

On Win10:
The "Prepare all ENC charts" button tested:
My first attempt caused OCPN to hang/crash when the first chart was initiated. An endless spinning mouse didn't resolved so I had to force OCPN down. On next try I first made a "Force Full Database Rebuild" and then clicked the ENC button. This time the ENC process rolled out. Then I pressed "Apply" and "OK" and OCPN charts window returned but with a spinning mouse and I couldn't change chart. When the (spinning) mouse flow over the charts bar it looks like attached picture and nothing happens when i click a bar. OCPN is alive but the chart window is frozen. (Dashboard is updated but not ships position) I couldn't shut O down using the close -X. Had to use applications manager.
On next try I again used the "Prepare all ENC charts" button only and O crashed again.
Håkan

[cagney]

Dave

Git master from a few minutes ago does not compile on my box.
See output from "make".
make.txt.pdf

Thanks!
Thomas

[bdbcat]

Hakan & cagney....

Fixed a few bugs, new code in github now.
Thanks for your patience.

Dave

[Hakan]

Dave
Win10: Tested today's Github.
After I've used the "Prepare all ENC charts" button O's behavior is as my description above. Cant use the chart bar to switch charts.
After O restart all is OK, so I tested to see if the new SENC files was used. But when zooming in to channels in Europe the SENC creation procedure is still there. For every chart I move into.
Håkan

[cagney]

Dave
Testing your latest code.
+I started with deleting all old SENCs.
+Prepare all ENC Charts took 30 minutes.
+Tested a limited Chart group. All working nicely in St Croix VI. Probably no updates in that area.
+PaEC again. about 10 minutes.
+PaEC again. Skip button works.
+Changed to chart group US EastCoast ENCs. Quick parsing of most charts occur.
+ No problem with changing charts using the chart bar, whether quilted or single mode.
+PaEC again(7 min) + new PaEC without pressing "Apply": Works, just starts a new round of parsing.

Is there a way to include the updates in the "Prepare all ENC Charts" button?

Thanks!!

Thomas

[bcn]

Originally Posted by Hakan

Dave
Yes, of course, I should have known. Wonder how they have disappeared?? I new copy of "OpenCPN_buildwin" fixed it all.
Thanks for your advise.
Håkan

Trying to build and running into the same error of missing cairo libs.
The link given here
Compiling - Windows | Official OpenCPN Homepage :
http://opencpn.org/web/2016030905590...in.7z/download

goes into the nirvana.

[bcn]

Link is back again, thanks.

[bdbcat]

cagney....

Thanks for testing.

The PaEC logic understands (or should understand) the incremental updates that might be downloaded. I don't know why your subsequent PaEC presses should take so long.

In my tests of US Chesapeake Bay (Region 4) ENCs, I find that immediate second press of PaEC, after initial processing takes only about 10 seconds. There is nothing to do. The progress bar just zips along.

Then, if I immediately update some cells from NOAA, only a few of the cells are updated, as you would expect. Time for this depends on how many updates have been downloaded. Usually pretty fast.

You can test this logic.
In a typical ENC folder, you will find the base chart ENC file as .000 extension. Updates have extensions of .001, .002, and so on.

Try this:
1. Temporarily rename or move the last one or two update files.
2. Run PaEC
3. Restore the renamed update files.
4. Run PaEC again. Check the log, and you should see one new SENC built, incorporating the latest update. It should run PaEC very fast.

All this activity should be reflected in the logfile.
It is surely the intent that updates be processed logically by PaEC. Lets work this out.

Dave

[Hakan]

ENC - Cont
Yet no luck using PaEC.
I've started from scratch by removing all ENCs.
- So I've downloaded some new chart files.
- Run Force Full Database Rebuild
- Apply
- Run PaEC. Took around 6 minutes.
- Clicked OK
- O returned to chart window and started to update all charts.
- Hanged on one chart, see pict. I've to force O down after 10 minutes.
- The Log has some strange "Error: File ''" couldn't be removed"
All can be seen in attached log file. (Download and take away ext .pfd)
Håkan

[bdbcat]

Hakan...

New code in github now. I think the base problem is memory leakage, which I have now corrected. Please check this out.

Good Luck
Dave

[Hakan]

Dave, thanks. Now tested:
I did:
- Deleted all SENC-files
- Run PaEC. Took around 5 minutes. But the process ended quickly before the progress bar had finalized.
- Clicked OK
- O returned to charts window where CM93 is shown. But when I , with the mouse, moved the chart O hanged black, see pict., spinning mouse and didn't respond. It didn't resolved so I had force down. (The close-X was responding so Windows could take it down.)
- Restarted O and run PaEC again. Now some 50 more senc-files was made.
- Clicked OK and returned to CM93 and this time it didn't freeze.
- Again run PaEC. Now it detected present SENC and ended quickly -good.
- Viewed the new charts and this time O detected the SENC-files and didn't had to make them again - also very good.

Log file for the two sessions attached. As can be seen in the second session the "Error: File ''" couldn't be removed" is still there.

Håkan

[Hakan]

Another thing concerning latest 4.5.0
The mark symbols has changed! And in my view to a not preferable alternative. Especially the cardinal marks are really bad. Please compare version 4.4.0 and 4.5.0 using the same CM93 charts in below picture.
Can it be changed back?? Or does anyone else prefer the new style?

Håkan

[cagney]

Originally Posted by Hakan

Another thing concerning latest 4.5.0
The mark symbols has changed! And in my view to a not preferable alternative. Especially the cardinal marks are really bad. Please compare version 4.4.0 and 4.5.0 using the same CM93 charts in below picture.
Can it be changed back?? Or does anyone else prefer the new style?

Håkan

Håkan

Change Vector Settings - Graphic Style back to "Paper Chart".
The "new" style is the "Simplified"style, which has been available for years.

/Thomas