Visit our Popular Forums

bdbcat · 01-05-2014, 07:37

Ahoy testers...

We have started the process of merging Sean's excellent optimization work into the OCPN github master branch. This will be an incremental process, pulling in small and not-so-small diffs individually so that we may manage regression problems cleanly. We plan to get most of Sean's work integrated and stabilized before the next Beta.

The first diff, in place now, applies OpenGL texture-based text rendering to vector charts.

Those who have source build capabilities are encouraged to clone/pull the latest github master branch, build it, and beat it with a stick.

I'll try to keep this thread updated with our progress reports. Please report build/run problems here, as well.

Thanks
Dave

Hakan · 01-05-2014, 09:06

Dave..
On Win32-XP&7, CM93, VC++:
Nice built w/o warnings nor errors.
Runs as expected. If texts was the issue I haven't seen anything to comment. All text are nicely following zoom and movements. (Font colours are still black when using OpenGL irrespective of font settings but I suppose this was not an issue?)

I've also tested running br24radar_pi ver. 40412 w/o comments.
Håkan

CarCode · 01-05-2014, 09:33

Dave,

I have announced that your diffs "Updates to PlugIn chart interface, especially S57 extended sectors and NATSUR attributes display." from April, 23. crashed here. Have you ever checked this?

See:
http://www.cruisersforum.com/forums/...-a-125066.html

Gerhard

cagney · 01-05-2014, 09:46

I have the same experience as Håkan. No problems.

Thomas

rooiedirk · 01-05-2014, 12:40

Compiles withouth errors but a view warnings. I left out the warnings for dashboard and grib plugin.

Code:

#/OpenCPN/src/tri.c: In function 'do_triangulate_polygon':
#/OpenCPN/src/tri.c:689:7: warning: this decimal constant is unsigned only in ISO C90 [enabled by default]
#/OpenCPN/src/wxJSON/jsonval.cpp: In member function 'wxJSONRefData* wxJSONValue::COW()':
#/OpenCPN/src/wxJSON/jsonval.cpp:3057:20: warning: variable 'data' set but not used [-Wunused-but-set-variable]
#/OpenCPN/src/wxJSON/jsonval.cpp: At global scope:
#/OpenCPN/src/wxJSON/jsonval.cpp:35:22: warning: 'traceMask' defined but not used [-Wunused-variable]
#/OpenCPN/src/wxJSON/jsonval.cpp:36:22: warning: 'compareTraceMask' defined but not used [-Wunused-variable]
#/OpenCPN/src/wxJSON/jsonval.cpp:37:22: warning: 'cowTraceMask' defined but not used [-Wunused-variable]

First impression, seem to run OK
Dirk

bdbcat · 01-05-2014, 16:58

Gerhard....

Is current github still crashing on Mac as mentioned before?
Works fine for me on Lion, wx2.95

Any more info? Screen shot of crash report?

Dave

CarCode · 02-05-2014, 01:05

Quote:

Originally Posted by bdbcat

Gerhard....

Is current github still crashing on Mac as mentioned before?
Works fine for me on Lion, wx2.95

Any more info? Screen shot of crash report?

Dave

I will check further.
The mentioned diffs however has leaded to an infinitiv loop while starting OpenCPN after compiling with no errors or warnings. So I left out this diff.

The last Sean's Optimum diffs are OK however with OS X Mavericks, Xcode 5.1 and wxWidgets 3.1.

Gerhard

Ptizef · 05-05-2014, 12:23

Hi all
New git built and run as expected
Starting tests .. chart texts OK, no visible difference.
But what the does mean "Enabled Responsive graphic Interface" ?
It result in very big menu bar icons and dialog font on my Vista Notebook, that I can't change.
Jean Pierre

bdbcat · 05-05-2014, 19:36

jp...

"Responsive" option is incompletely implemented. What it will eventually do is cause icons/text to conform to an absolute minimum size, so that when used on a high definition tablet screen, say 8", the icons and other GUI elements will not be too small to touch cleanly, or read clearly.

As I say, it is incomplete in github now. This is not ready for Beta yet.

Thanks
Dave

Ptizef · 06-05-2014, 06:27

Thanks Dave
understood
JP

bdbcat · 10-05-2014, 09:34

Hi folks...

The next stage in OCPN Optimum branch merge is now available.

Changes:

remove unused texture from ocpndc
improve performance as well as appearance of thick line rendering
variable step count ellipse, use faster float since double is not needed, cleanup unused code, and a few rendering corrections
Fix introduced bug I missed do to merging.
correct end cap rendering logic
corrections to drawing thick lines

The latest merge may be pulled from github master now.
It will be called 3.3.1710

Thanks Sean

Dave

seandepagnier · 10-05-2014, 20:26

This is going well. It gives me a chance to re-review things, and then dave makes important fixes as well which were not obvious to me. The next change (smooth panning improvements) is awaiting merging.

A possible point of discussion:

I added the keys '[' ]' '|' for setting arbitrary rotations. I personally like this feature so I can set arbitrary angles rather than relying on the course-up algorithm. This allows south up, route-up, and general course-up without changing the angle all the time.

It greatly helps in narrowing down many rotation-related bugs (many which are fixed in the optimum branch), but many users may find it confusing. What do you think? Should it be enabled by a configuration option only? Apparently it is difficult on some foreign keyboards. I believe user rotation control is needed for testing purposes to verify course up works for all angles, but it is also an important feature.

Hakan · 11-05-2014, 01:08

Quote:

Originally Posted by boat_alexandra

............Apparently it is difficult on some foreign keyboards. .............

Sean... There must be another key board independent way to interpret key strokes? I think the problem in OCPN is that I, using the Swedish board, have to press the Alt-key to get the "|" sign and you read the "Alt-code". But that's not a problem for any word processor or when I write here?

seandepagnier · 11-05-2014, 01:25

Quote:

Originally Posted by Hakan

Sean... There must be another key board independent way to interpret key strokes? I think the problem in OCPN is that I, using the Swedish board, have to press the Alt-key to get the "|" sign and you read the "Alt-code". But that's not a problem for any word processor or when I write here?

Yes, there is, but the problem is I do not know the magic number to use. See chcanv.cpp line 1899. If you can set a breakpoint there, then press what key, then look at the value of key_char then you could provide the keycodes needed.