Little AIS mod

[useris]

Hello,

I want create a little AIS mod - to display ship or base name (as i done in picture) if we have it.
It work's but I have some questions about better way to do it. I added in chcanv.cpp file :

wxString Name =wxString::FromUTF8(td->ShipName); // If there is better way to get Ship Name?
Name = Name.substr(0, Name.find(_T ("@"), 0)); // Some how I get name with @@@@@ at the end
Name = Name.substr(0, Name.find(_T ("Unknown"), 0)); // If we do not have ship's name nothing display

wxFont font;
font = wxFont( 10, wxFONTFAMILY_ROMAN, wxFONTSTYLE_NORMAL, wxFONTWEIGHT_NORMAL ); // How to change font size depending on chart scale?
dc.SetFont(font );

dc.DrawText(Name, TargetPoint.x+10, TargetPoint.y-6); // How change font direction, because if ship's course 090 ship's icon hide ship's name

ImageShack® - Online Photo and Video Hosting

Thank you for answers

[Liam Wald]

Hugh...what?

[nohal]

useris...
1) make it configurable in options - it will clutter the chart in areas with heavy traffic IMO.
2) Do not try to rotate the text, people hate it, recalculate the offset based on the target heading instead to shift the text to the other side...
3) Have a look at https://github.com/OpenCPN/OpenCPN/b...canv.cpp#L5122 (actually at what precedes it)

Pavel

[useris]

Originally Posted by nohal

useris...
1) make it configurable in options - it will clutter the chart in areas with heavy traffic IMO.
2) Do not try to rotate the text, people hate it, recalculate the offset based on the target heading instead to shift the text to the other side...
3) Have a look at https://github.com/OpenCPN/OpenCPN/b...canv.cpp#L5122 (actually at what precedes it)

Pavel

Ok, I understood. How get present chart scale? Ship's name would be depend on chart scale.
double true_scale_display = floor( VPoint.chart_scale / 100. ) * 100.;

Actually i did this modification, just want make it better

[useris]

If someone want AIS modification - it is display ship's name like in first picture and it depend on chart scale:
Need to edit chcanv.cpp
Around line no 6192 (dc.SetPen( wxPen( GetGlobalColor( _T ( "UBLCK" ) ) ) ) after add:

double true_scale_display = floor( VPoint.chart_scale / 100. ) * 100.;

if(true_scale_display<280000){ // from which scale to display name

wxString Name =wxString::FromUTF8(td->ShipName);
Name = Name.substr(0, Name.find(_T ("@"), 0));
Name = Name.substr(0, Name.find(_T ("Unknown"), 0));

if (Name!=_T("")) {
wxFont font;
font = wxFont( 10, wxFONTFAMILY_ROMAN, wxFONTSTYLE_NORMAL, wxFONTWEIGHT_NORMAL );
dc.SetFont(font );

if ((td->COG> 70) && (td->COG < 120)) {dc.DrawText(Name, TargetPoint.x-10, TargetPoint.y-6);
} else { dc.DrawText(Name, TargetPoint.x+10, TargetPoint.y-6); }

} //If name do not empty
} // if scale

[Hakan]

Hello
Useris' [Show Target Name] coded, compiled and running in Win32. Pavel's comment to include user choice in AIS options also included. Nice "good to have" thanks to useris and Pavel.
I can of course share it but I may need some "how to do advices" to put in a common repository.

Håkan

[Hakan]

Originally Posted by Hakan

Hello
Useris' [Show Target Name] coded, compiled and running in Win32.
I can of course share it but I may need some "how to do advices" to put in a common repository.
Håkan

All files used for this little hack are here:
https://dl.dropbox.com/u/5209364/AIS...arget_Name.zip

[nohal]

Hakan...
Congrats Ready for the next small git lesson? If so, try

git diff

on your modified source.
Better say

git diff > mydiff.txt

I think it will save you a bit of work next time...
The resulting mydiff.txt is all that's needed to replay your changes on anybody's code using

git apply mydiff.txt

Pavel

[MarkJ]

Originally Posted by Hakan

All files used for this little hack are here:
https://dl.dropbox.com/u/5209364/AIS...arget_Name.zip

I just download it onto Win7 and it loads itself or do I put it somewhere, or do something to it?
I am a user, not a developer.

Thanks,


Mark

[Hakan]

Mark
Just download and unpack the zip file to any directory of your choice. There's a readme.txt included where I describe how to handle the files. You have to rename some files and do some copying. I hope it's clear enough. Otherwise it's due to my bad explanations and please come back and I'll try to describe it better.
Compared to our developers I'm a user as well but enjoys trying to learn some coding in C++.
Make a try! The only thing of importance is to not overwrite but rename the actual opencpn.exe so you can get it back whenever you want.
Håkan

[MarkJ]

Thanks Hakan! that's great!

I will do it this afternoon!


Mark

[Hakan]

Originally Posted by nohal

Hakan...
Congrats Ready for the next small git lesson? If so, try

git diff

on your modified source.
Better say

git diff > mydiff.txt

I think it will save you a bit of work next time...
The resulting mydiff.txt is all that's needed to replay your changes on anybody's code using

git apply mydiff.txt

Pavel

Pavel..
Many thanks for your advices. Really appreciated.
I think I have to read GIT manual more though. The file mydiff.txt seems to include every code in the whole project and have the size of approx. 2.1 Mb. I was in the root directory, with .git, scr and so on just below, when issued the command you said.
Håkan

[nohal]

Windows new line characters, I would say. If you edit the source in VisualStudio, this should not happen, but once you touch it with notepad everything is messed up. You can configure git to take care of it though.

[Hakan]

Pavel..
All source is edited with VC++ 2010 I haven't touched it with notepad. But I may have answered "yes" to a repetitive question about adaptation to Windows CR/LF. Is that what you mean? If so I maybe have VC to recall it.

[nohal]

Ahh, that's it. The correct answer is "leave as is". You can do Save as... - Save with Encoding... to restore the Unix LF line endings the source uses.