WeatherFax ...

[rgleason]

Was compiling in v 3.2.2 for weatherfax. Is this the problem? It compiled there last time! Why the new external symbols needed?

[rgleason]

Actually using version 3.2.0 from github

[rgleason]

Found the API number as 18 and the PluginVersion 09 in weatherfax_pi.h line 42 and 43

#define PLUGIN_VERSION_MAJOR 0
#define PLUGIN_VERSION_MINOR 9

#define MY_API_VERSION_MAJOR 1
#define MY_API_VERSION_MINOR 8

[rgleason]

Weatherfax_pi.h file shows API:18, Plugin Version:09

Compile in 3.2.2 with _isnan & tinyxml errors fixed, failed with unresolved External Symbol errors.

Compile in 3.3.1009 with _isnan & tinyxml errors fixed, failed with unresolved External Symbol errors. See attached..

Any ideas?

[rgleason]

Ok I started over. Deleted the weatherfax_pi and did a git clone again.
I then went back and tried to look at the paths and includes with tinyxml. Then looked at KonniLogbook for examples of the right way to do this.

I did a search in weatherfax_pi directory to find all references to tinyxml
From that I opened each file and changed the include path etc.

Here is what I did to the weather_fax files.

copy tinyxml.h from opencpn/ main directory to  plugins/weatherfax_pi/src
I also copied 
tinyxml.cpp from opencpn/ main directory   to  plugins/weatherfax_pi/src
tinyxmlerror.cpp from opencpn/ main directory   to  plugins/weatherfax_pi/src
tinyxmlparser.cpp from opencpn/ main directory   to  plugins/weatherfax_pi/src

===
Change  the tinyxml.h  path in the following:
InternetRetrievalDialog.cpp
SchedulesDialog.cpp
WeatherFax.cpp

 to read   #include "tinyxml.h"
 
 ===
 
 Change cmakelist.txt  in plugins/weatherfax_pi directory
 
 to add
             src/tinyxml.h
            src/tinyxml.cpp
            src/tinyxmlerror.cpp
            src/tinyxmlparser.cpp

Then compiled and it still fails with 9 errors. see attached.
Any ideas?

[rgleason]

This "unresolved external symbol error" involves
SchedulesDialog.obj
and
InternetRetrievalDialog.obj

with ...
"public: virtual bool __thiscall wxGenericImageList::GetSize(int,int &,int &)const " (?GetSize@wxGenericImageList@@UBE_NHAAH0@Z)

I have done searches trying to find out what these are.

[rgleason]

I just tried

To WeatherFax.cpp add
#include "SchedulesDialog.h"

I get this set of errors. So forget it. I've run out of steam and ideas to fix Sean's plugin and I am very frustrated.

[rgleason]

The Linux version compiles ok for me, however I can figure out how to "Browse" to select a weather image. There is a little window when the plugin is opened but nothing seems to work. Is this plugin broken in linux too?

[rgleason]

Ok, so I checked out how Linux does tinyxml and found a FindcmakeXml.txt that somehow searches out tinyxml where ever it is. That must not work in Windows.

So I looked carefully at Logbook Konni plugin which has an src/tinyxml/ subdirectory and decided to follow that structure.

1. Copied the Logbook src/tinyxml/ directory into weatherfax_pi/src
2. Changed all the include pathnames at the head of the weatherfax_pi/src files to "tinyxml/tinyxml.h" where the tinyxml.h path exists.
3. Moved up to plugins/weatherfax_pi/ directory and changed the cmakelist.txt file copying the following include paths in (that were in logbook konni). Removed other tinyxml path references.
src/icons.cpp

src/tinyxml/tinyxml.cpp
src/tinyxml/tinyxml.h
src/tinyxml/tinyxmlerror.cpp
src/tinyxml/tinyxmlparser.cpp
src/tinyxml/tinystr.cpp
src/tinyxml/tinystr.h

Then compiled from opencpn-git/build with cmake ../ and cmake --build .

Very similar Output errors still occurred, so I don't think the problem is tinyxml!

LD.vcxproj" (default targets) -- FAILED.

Build FAILED.

"C:\Data-Dart\Up-Soft\Navigation\opencpn-git\build\ALL_BUILD.vcxproj" (default t
arget) (1) ->
"C:\Data-Dart\Up-Soft\Navigation\opencpn-git\build\plugins\weatherfax_pi\weather
fax_pi.vcxproj" (default target) (36) ->
(ClCompile target) ->
  c:\data-dart\up-soft\navigation\opencpn-git\plugins\weatherfax_pi\src\Schedule
sDialog.h(38): error C2011: 'Schedule' : 'class' type redefinition [C:\Data-Dart
\Up-Soft\Navigation\opencpn-git\build\plugins\weatherfax_pi\weatherfax_pi.vcxpro
j]
  c:\data-dart\up-soft\navigation\opencpn-git\plugins\weatherfax_pi\src\Schedule
sDialog.h(71): error C2011: 'SchedulesDialog' : 'class' type redefinition [C:\Da
ta-Dart\Up-Soft\Navigation\opencpn-git\build\plugins\weatherfax_pi\weatherfax_pi
.vcxproj]
  ..\..\..\plugins\weatherfax_pi\src\WeatherFax.cpp(84): error C2027: use of und
efined type 'SchedulesDialog' [C:\Data-Dart\Up-Soft\Navigation\opencpn-git\build
\plugins\weatherfax_pi\weatherfax_pi.vcxproj]
  ..\..\..\plugins\weatherfax_pi\src\WeatherFax.cpp(84): error C2227: left of '-
>{ctor}' must point to class/struct/union/generic type [C:\Data-Dart\Up-Soft\Nav
igation\opencpn-git\build\plugins\weatherfax_pi\weatherfax_pi.vcxproj]
  ..\..\..\plugins\weatherfax_pi\src\WeatherFax.cpp(84): error C2027: use of und
efined type 'SchedulesDialog' [C:\Data-Dart\Up-Soft\Navigation\opencpn-git\build
\plugins\weatherfax_pi\weatherfax_pi.vcxproj]
  ..\..\..\plugins\weatherfax_pi\src\WeatherFax.cpp(84): error C2227: left of '-
>{dtor}' must point to class/struct/union/generic type [C:\Data-Dart\Up-Soft\Nav
igation\opencpn-git\build\plugins\weatherfax_pi\weatherfax_pi.vcxproj]
  ..\..\..\plugins\weatherfax_pi\src\WeatherFax.cpp(84): fatal error C1903: unab
le to recover from previous error(s); stopping compilation [C:\Data-Dart\Up-Soft
\Navigation\opencpn-git\build\plugins\weatherfax_pi\weatherfax_pi.vcxproj]

    0 Warning(s)
    7 Error(s)

Time Elapsed 00:00:07.69

C:\Data-Dart\Up-Soft\Navigation\opencpn-git\build>

[rgleason]

MSVC++ Output
These changes have eliminated the InternetRetrievalDialog external symbol error, but the Schedulesdialog error continues.

51>------ Skipped Build: Project: wmm-pot-update, Configuration: Debug Win32 ------
51>Project not selected to build for this solution configuration 
18>  WeatherFax.cpp
18>c:\data-dart\up-soft\navigation\opencpn-git\plugins\weatherfax_pi\src\SchedulesDialog.h(38): error C2011: 'Schedule' : 'class' type redefinition
18>          c:\data-dart\up-soft\navigation\opencpn-git\plugins\weatherfax_pi\src\SchedulesDialog.h(38) : see declaration of 'Schedule'
18>c:\data-dart\up-soft\navigation\opencpn-git\plugins\weatherfax_pi\src\SchedulesDialog.h(71): error C2011: 'SchedulesDialog' : 'class' type redefinition
18>          c:\data-dart\up-soft\navigation\opencpn-git\plugins\weatherfax_pi\src\SchedulesDialog.h(71) : see declaration of 'SchedulesDialog'
18>..\..\..\plugins\weatherfax_pi\src\WeatherFax.cpp(84): error C2027: use of undefined type 'SchedulesDialog'
18>          c:\data-dart\up-soft\navigation\opencpn-git\plugins\weatherfax_pi\src\SchedulesDialog.h(71) : see declaration of 'SchedulesDialog'
18>..\..\..\plugins\weatherfax_pi\src\WeatherFax.cpp(84): error C2227: left of '->{ctor}' must point to class/struct/union/generic type
18>          type is 'TiXmlElement *'
18>..\..\..\plugins\weatherfax_pi\src\WeatherFax.cpp(84): error C2027: use of undefined type 'SchedulesDialog'
18>          c:\data-dart\up-soft\navigation\opencpn-git\plugins\weatherfax_pi\src\SchedulesDialog.h(71) : see declaration of 'SchedulesDialog'
18>..\..\..\plugins\weatherfax_pi\src\WeatherFax.cpp(84): error C2227: left of '->{dtor}' must point to class/struct/union/generic type
18>          type is 'TiXmlElement *'
18>..\..\..\plugins\weatherfax_pi\src\WeatherFax.cpp(84): fatal error C1903: unable to recover from previous error(s); stopping compilation
52>------ Build started: Project: ALL_BUILD, Configuration: Debug Win32 ------
52>  Build all projects
53>------ Skipped Build: Project: PACKAGE, Configuration: Debug Win32 ------
53>Project not selected to build for this solution configuration 
54>------ Skipped Build: Project: INSTALL, Configuration: Debug Win32 ------
54>Project not selected to build for this solution configuration 
========== Build: 18 succeeded, 1 failed, 20 up-to-date, 35 skipped ==========

[rgleason]

It is at Line 84 of Weatherfax.cpp:

Very large segments of the procedures are commented out, perhaps these are tests or something, but the problem at line 84 is at the start of one of those comment outs which is called UpdateMenuStates():

Now I think I have downloaded a version of weatherfax that Sean was working on when he left, using github as a safe storage place. The file was being tested for various conditions, getting an image already on the computer, decoding it if there is a radio and proper connectios,, etc.

So maybe I should just drop this effort. So github as a safe backup location, makes perfect sense. I just don't know when it is real code and when it is not. A waste of my time!!!!!!!!

So now, unless Sean explicitly sends me an email saying he wants something compiled, I am NOT GOING TO DO ANYTHING, end of story.

Line 78
#define FAIL(X) do { error = X; goto failed; } while(0)
WeatherFax::WeatherFax( weatherfax_pi &_weatherfax_pi, wxWindow* parent)
    : WeatherFaxBase( parent ),
      m_SchedulesDialog(_weatherfax_pi, this),
      m_InternetRetrievalDialog(_weatherfax_pi, this),
      m_weatherfax_pi(_weatherfax_pi)

Line 84
{
    UpdateMenuStates();   [goes on here, deleted]  
}

WeatherFax::~WeatherFax()
{   [commented out here too] 
}


void WeatherFax::EnableDisplayControls(bool enable)
{  Comment out
}

void WeatherFax::OnFaxes( wxCommandEvent& event )
{  Comment out     UpdateMenuStates();


void WeatherFax::OnFaxesToggled( wxCommandEvent& event )
{
    RequestRefresh( m_parent );
}

void WeatherFax::OpenWav(wxString filename, wxString station, wxString area)
{  Comment out  something about decoder
}

void WeatherFax::OpenImage(wxString filename)
{  Comment out  about transparency
}

void WeatherFax::OnOpen( wxCommandEvent& event )
{ Comment out      wxFileDialog openDialog
}

void WeatherFax::OnEdit( wxCommandEvent& event )
{
}

void WeatherFax::OnDelete( wxCommandEvent& event )
{
}

void WeatherFax::TransparencyChanged( wxScrollEvent& event )
{
}

void WeatherFax::WhiteTransparencyChanged( wxScrollEvent& event )
{
}

void WeatherFax::OnInvert( wxCommandEvent& event )
{
}

void WeatherFax::OnCapture( wxCommandEvent& event )
{
}

void *DecoderThread::Entry() {

[rgleason]

Mike sent me a fix!!

Mike,
Awesome, I've been wondering about those wx/wx.h and others. I think they have to do with the Linux Screen Builder, but there does not seem to be a wx directory... a bit weird. -- I'll give it a try! Thanks so much. We'll have to make a Tracker entry for the image scales.

My next hurdle is to learn how to upload to git and request a pull from Sean, what a kick that would be!

By the way I just got weather_routing_pi fixed for incorrect external dependencies too. Used your guidance and looked at Logbook Konni's structure for cutil, georef, too. I had to keep fixing stuff and finally got it. Should have written it down.

Rasbats

Weatherfax problems in Windows:

InternetRetrievalDialog.cpp
SchedulesDialog.cppBoth these files needed the extra 'include' file 'wx/wx.h' to make the Weatherfax plugin compile.

I don't know why it works!!!!

Using the plugin I found a problem with the scale of the images. Also make sure you have set up the 'data' folder for the plugin, with the two xml files.

Hope this helps.Best regards,Mike

[rgleason]

Well, I tried Mike's solution which added wx/wx.h to several files, which fixed some of the problems, but the last 8 were still there, and perhaps I was not doing it right. I tried both include "wx/wxh" and include <wx/wx.h>. The "wx/wx.h" resulted in fewer errors but some still remained. Tried some other things to no avail. So I deleted wxfax and did a new git clone.

After doing the following to fix the bad external references:

Copied Logbook Konni tinyxml directory to weatherfax_pi/src/

Changed ../../../include/tinyxml.xml TO /tinyxml/tinyxml.xml
IN Weatherfax.cpp InternetRetrievalDialog.cpp SchedulesDialog.cpp

Changed isnan to _snan in WeatherfaxImage.cpp 2 in line 368 and 2 in line 386.

There appear to be new cmake --build . output errors, see below.
I find Sean has updated git and has changed the code.

  Deleting file "wmm_pi.dir\Debug\wmm_pi.unsuccessfulbuild".
  Touching "wmm_pi.dir\Debug\wmm_pi.lastbuildstate".
Done Building Project "C:\Data-Dart\Up-Soft\Navigation\opencpn-git\build\plugins
\wmm_pi\wmm_pi.vcxproj" (default targets).
Done Building Project "C:\Data-Dart\Up-Soft\Navigation\opencpn-git\build\ALL_BUI
LD.vcxproj" (default targets) -- FAILED.

Build FAILED.

"C:\Data-Dart\Up-Soft\Navigation\opencpn-git\build\ALL_BUILD.vcxproj" (default t
arget) (1) ->
"C:\Data-Dart\Up-Soft\Navigation\opencpn-git\build\plugins\weatherfax_pi\weather
fax_pi.vcxproj" (default target) (36) ->
(ClCompile target) ->
  ..\..\..\plugins\weatherfax_pi\src\wximgkap.cpp(48): error C2371: 'RGBQUAD' :
redefinition; different basic types [C:\Data-Dart\Up-Soft\Navigation\opencpn-git
\build\plugins\weatherfax_pi\weatherfax_pi.vcxproj]
  ..\..\..\plugins\weatherfax_pi\src\wximgkap.cpp(271): error C2668: 'sqrt' : am
biguous call to overloaded function [C:\Data-Dart\Up-Soft\Navigation\opencpn-git
\build\plugins\weatherfax_pi\weatherfax_pi.vcxproj]
  ..\..\..\plugins\weatherfax_pi\src\wximgkap.cpp(355): error C2668: 'sqrt' : am
biguous call to overloaded function [C:\Data-Dart\Up-Soft\Navigation\opencpn-git
\build\plugins\weatherfax_pi\weatherfax_pi.vcxproj]
  ..\..\..\plugins\weatherfax_pi\src\wximgkap.cpp(364): error C2668: 'sqrt' : am
biguous call to overloaded function [C:\Data-Dart\Up-Soft\Navigation\opencpn-git
\build\plugins\weatherfax_pi\weatherfax_pi.vcxproj]
  ..\..\..\plugins\weatherfax_pi\src\wximgkap.cpp(424): error C2668: 'sqrt' : am
biguous call to overloaded function [C:\Data-Dart\Up-Soft\Navigation\opencpn-git
\build\plugins\weatherfax_pi\weatherfax_pi.vcxproj]
  ..\..\..\plugins\weatherfax_pi\src\wximgkap.cpp(425): error C2668: 'sqrt' : am
biguous call to overloaded function [C:\Data-Dart\Up-Soft\Navigation\opencpn-git
\build\plugins\weatherfax_pi\weatherfax_pi.vcxproj]
  ..\..\..\plugins\weatherfax_pi\src\wximgkap.cpp(426): error C2668: 'sqrt' : am
biguous call to overloaded function [C:\Data-Dart\Up-Soft\Navigation\opencpn-git
\build\plugins\weatherfax_pi\weatherfax_pi.vcxproj]
  ..\..\..\plugins\weatherfax_pi\src\wximgkap.cpp(811): error C3861: 'log2': ide
ntifier not found [C:\Data-Dart\Up-Soft\Navigation\opencpn-git\build\plugins\wea
therfax_pi\weatherfax_pi.vcxproj]

    0 Warning(s)
    8 Error(s)

Time Elapsed 00:00:07.37

C:\Data-Dart\Up-Soft\Navigation\opencpn-git\build>

[rgleason]

ambiguous call to overloaded function in C++

error: ambiguous call to overloaded func - C++ Forum

namespaces - C++ strange ambiguous call to overloaded function - Stack Overflow

Is using sqrt in a return ambiquous to MSVC++???

Line 271

static inline int HistDist(Color32 a, Color32 b)
{
   int c,r;

   c = a.q.rgbRed - b.q.rgbRed;
   r = c*c;

   c = a.q.rgbGreen - b.q.rgbGreen;
   r += c*c;

   c = a.q.rgbBlue - b.q.rgbBlue;
   r += c*c;

   return sqrt(r);   <--- Line 271
}

Line 355

if (h->count && !h->num)
        {
            int32_t cote = 0;
            int32_t nbcolors;
            int32_t curv;

            r->count = r->red = r->green = r->blue = 0;
            r->nbin = 0;
            r->nextcote = 0;
            r->nbout++;

            cote = (int32_t)(pow((double)((1<<24)/(double)r->colorsout),1.0/3.0)/2)-1;
            r->maxcote = sqrt(3*cote*cote);  <---Line 355

Line 364

 while (r->nbin < nbcolors)
            {
                curv += nbcolors - r->nbin;
                cote = (int32_t)(pow(curv,1.0/3.0)/2) - 1;
                cote = sqrt(3*cote*cote);   <--- Line 364

                if (r->nextcote > cote)
                    cote = r->nextcote;

LIne 424

static int HistReduce(histogram *h, int colorsin, int colorsout)
{
    reduce r;

    r.h = h;

    r.nbout = 0;

    if (!colorsout || !colorsin) return 0;

    if (colorsout > 0x7FFF) colorsout = 0x7FFF;
    if (colorsout > colorsin) colorsout = colorsin;
    r.colorsin = colorsin;
    r.colorsout = colorsout;

    r.limcote[2] = sqrt(3*3*3) ;   <Line 424
    r.limcote[4] = sqrt(3*15*15) ;
    r.limcote[6] = sqrt(3*63*63) ;

    HistReduceLevel(&r,h,6);

    return r.nbout;

[Rasbats]

With Windows the latest Weatherfax plugin code was compiled from:
https://github.com/seandepagnier/weatherfax_pi

Using VSC++ 2010, Win 7, OpenCPN 3.3.910

Following changes had to be made in wximgkap.cpp:

Add a function below 'typedef union' bit at the top of the file:

unsigned int log2( unsigned int x )
{
unsigned int ans = 0 ;
while( x>>=1 ) ans++;
return ans ;
}

To avoid ambiguous call for 'sqrt'
Change return sqrt(r); to read return sqrt(float (r));
Change sqrt(3*cote*cote); to read sqrt(float(3*cote*cote));
Change sqrt(3*3*3) ; to read sqrt(float (3*3*3)) ;
Change sqrt(3*15*15) ; to read sqrt(float (3*15*15)) ;
Change sqrt(3*63*63) ; to read sqrt(float (3*63*63)) ;
And there may be some other sqrt to amend in the same way.

And the ambiguous call for 'ceil':
Change bits_out = ceil(log2( num_colors)); to read
bits_out = ceil(float (log2( num_colors)));

Comment out this bit
/* color type and mask */

typedef struct
{
uint8_t rgbRed, rgbGreen, rgbBlue, rgbReserved;
} RGBQUAD;

It's defined elsewhere.

In InternetRetrievalDialog.cpp and SchedulesDialog.cpp

Add #include <wx/wx.h>

Add the 4 tinyxml files from the main branch to the weatherfax src folder and add to the project.

If there are any remaining errors please post them, I may have missed something. And my corrections may have messed up something else!

Mike