OpenCPN Version 5 Beta Starts

[Hakan]

Pavel..

Tide: OK, my mistake. Works fine.

Date format is different in "Departure" date and ETA dates, see shot. Could that be equalized? The format in Departure is correct system format.

Thanks
Håkan

[conachair]

Originally Posted by Hakan

I've three issues for the Route manager.
I'm on Win10. Could anyone else confirm this? Seems strange.

1. The "Plan speed" can't be edited. Each Leg can after a double click be edited. I don't remember if this was the intention.
2. Even if a Tide station info window is open in the same canvas no tide info is created. I've changed the date and pressed Enter as of the logic in version 4.8.8.
3. If the Route properties is opened from the left mouse click menu it can't be closed using the "OK Button". Nothing happens when I click. One not repeatable O crash occurred when I clicked the OK button several times.

These issues are noted in Flyspray: https://opencpn.org/flyspray/index.p...s&task_id=2489

Seeing the same here on a win10 laptop. Just crashed with repeated clicking OK in the route properties editor. Crash report sent.
1st time opening the properties from the route manager the planned speed is editable, 2nd time the mouse click won't highlight the text box, it is editable by repeated tab to highlight the text box. Clicking OK seems to save the changes, just not close the page, cancel closes the page as expected.

[nohal]

Originally Posted by conachair

Seeing the same here on a win10 laptop. Just crashed with repeated clicking OK in the route properties editor. Crash report sent.

Can't reproduce this one, anything else that needs to be done to get to the crash? (And what is "repeated clicking the OK button"? On my W10 system there is nothing to click on after the OK button is clicked once as the window is closed)

1st time opening the properties from the route manager the planned speed is editable, 2nd time the mouse click won't highlight the text box, it is editable by repeated tab to highlight the text box. Clicking OK seems to save the changes, just not close the page, cancel closes the page as expected.

This one I now can reproduce, thanks.

[Hakan]

Originally Posted by nohal

... (And what is "repeated clicking the OK button"? On my W10 system there is nothing to click on after the OK button is clicked once as the window is closed)....

Pavell..
That's what we are trying to explain. Ok my English is bad, but the OK button has no hide effect when the Route dialog is opened by the right mouse click menu. So when the OK button is clicked changed data are saved but the dialog is not closed. That's why we can click on it several times. Since it's still there! This effect is not present at the official beta version. Maybe introduced on this commit?:

FWIW I tried a little hack on the 731d2ed1f commit:
RoutePropDlglmpl.cpp: row: ~805

     SaveChanges();
-    if( pRouteManagerDialog && pRouteManagerDialog->IsShown() ) {
-        pRouteManagerDialog->UpdateRouteListCtrl();Hide();
+    if (pRouteManagerDialog && pRouteManagerDialog->IsShown()) {
+        pRouteManagerDialog->UpdateRouteListCtrl(); Hide();
     }
+    else Hide();

My assumption is when there is no route manager dialog in behind, as when it's opened by the right click menu, the Hide() is not performed?
Anyhow, with this hack the dialog is nicely closed, or hid, when I click the OK button even if the dialog is opened from the canvas right click menu.
Now, I'm not a coder but it works for me.
Thanks

Håkan

[houlejm]

Originally Posted by Hakan

Pavel..
"What is the "left mouse click menu"? FWIW I can't reproduce after neither double left-click on the route nor using the right-click context menu."

Sorry, Yes right click... of course! And this I can reproduce after several restart. anyone else?


I'll check the tide logic. If so I must have missed this.. (Long winter, bad memory??) Thanks for the info.

Yes Right click to get route properties. I can reproduce always on linux.
Jean-Marie

[conachair]

Originally Posted by nohal

Can't reproduce this one, anything else that needs to be done to get to the crash? (And what is "repeated clicking the OK button"? On my W10 system there is nothing to click on after the OK button is clicked once as the window is closed)

Can't reproduce the crash now
"repeated clicking the OK button"? is just that, the OK button seems to save any changes but doesn't close the window. Same with either double clicking a route or right click/properties.

Win10, V - 5014200

[Hakan]

The OK - no hide -issue now fixed by Pavel in Github.
Thanks.
Håkan

[geoffr]

Dave,

I've played with some more mbtiles with SAS and if you do it correctly when you scan the charts it doesn't crash so I'm pretty sure it was an "invalid" mbtiles file as created the file in SAS without downloading all the tiles first.

I'm hoping when you scan them you can let the user know it's a bad/unreadable etc. mbtiles file..

Geoff

Originally Posted by geoffr

Dave,

Now that I've played with mbtiles and SAS some more it's not surprising to me that you say it's corrupt. In SAS it will create an mbtiles file even if you haven't download all the tiles, so perhaps it's creating the file incorrectly as there are missing tiles? I'll try again after downloading the tiles and see if that fixes it..

Geoff.

[yachtvalhalla]

Originally Posted by Hakan

I've three issues for the Route manager.
I'm on Win10. Could anyone else confirm this? Seems strange.
The "Plan speed" can't be edited. Each Leg can after a double click be edited. I don't remember if this was the intention.

1. Even if a Tide station info window is open in the same canvas no tide info is created. I've changed the date and pressed Enter as of the logic in version 4.8.8.
2. If the Route properties is opened from the left mouse click menu it can't be closed using the "OK Button". Nothing happens when I click. One not repeatable O crash occurred when I clicked the OK button several times.

These issues are noted in Flyspray: https://opencpn.org/flyspray/index.p...s&task_id=2489

I cannot confirm but have a related issue. W10 also.

Plan speed for a route: I'm able to edit the speed. First image. (Changed to 3 and was retained on subsequent display)

1. Tide information: Shows and can be changed. Second and third images.

ISSUE: Once the tide station has been found and the data displayed, it cannot again be displayed until O5 has been restarted. Fourth image. (Second attempt at waypoint shown in 1. above) I will report to Flyspray.

2. Closing Route Properties. Closes with either the "OK" or the red "X" for me.


Terry

[conachair]

Originally Posted by Hakan

The OK - no hide -issue now fixed by Pavel in Github.
Thanks.
Håkan

Seems to work fine now, thanks guys.
Still can't select the planned speed text box with mouse, just tab but you probably know that.

[nohal]

Terry...
Can't reproduce, can you confirm the issue is still present in the current CI build?(https://ci.appveyor.com/project/bdbc...uild/artifacts)

Thanks

Pavel

[nohal]

@Hakan, @conachair...
The route dialog field focus mess started by leaving the "Plan speed" field for the first time seems fixed for me in current github master, can you confirm?

Thanks

Pavel

[fgd3]

Originally Posted by Hakan

I've three issues for the Route manager.
I'm on Win10. Could anyone else confirm this? Seems strange.

1. The "Plan speed" can't be edited. Each Leg can after a double click be edited. I don't remember if this was the intention.

You can set a default Plan Speed in Opencpn\opencpn.ini. Search for "PlanSpeed". I think we used to be able to set that with one of the program's settings options but no more.


Here's the (buggy) Route Manager behavior I've seen with Windows 10.


I create a route and open Route Manager. The new route is unnamed. I click on it, then click the Properties button. I can now edit the route name and the Plan Speed. I close the Properties dialog and the route is still listed as unnamed in Route Manager. I close Route Manager, then open it. The route is now listed with the correct name.


I try to edit the route's properties. I cannot click in the Plan Speed field to change it. If I double click in the Plan Speed field the value is highlighted but I still cannot change it. I can click in the Distance field, then tab forward and I can edit the Plan Speed field. I can also click in the Departure field, then back tab to the Plan Speed field. Regardless of direction when I tab into the field I can edit it.


When I change the Plan Speed field the speed of each leg is immediately modified. I have not found a way to modify the speed shown by each route point in the route. I don't think that was ever a feature.



Fabbian

[yachtvalhalla]

Originally Posted by nohal

Terry...
Can't reproduce, can you confirm the issue is still present in the current CI build?(https://ci.appveyor.com/project/bdbc...uild/artifacts)
Thanks
Pavel

Yes the issue is still in this version.

Perhaps a silly question but should I be using this version instead of the original?

Thanks, Terry

[yachtvalhalla]

Don't think this is important enough to call a 'bug' but it is very annoying.

When importing multiple waypoints they are sorted 'ZtoA'.

Clicking on 'Waypoint Name' changes it to desired (my) 'AtoZ'.

Terry the Nitpicker