Ocpn-Draw and Boundary

[rgleason]

Tried recent compile.

Had one errror

Build FAILED.

"C:\Users\Frederick\Documents\OpenCPN-Data\o-plugin\ocpn_draw_pi\build\ALL_BUIL
D.vcxproj" (default target) (1) ->
"C:\Users\Frederick\Documents\OpenCPN-Data\o-plugin\ocpn_draw_pi\build\ocpn_dra
w_pi.vcxproj" (default target) (3) ->
(ClCompile target) ->
  c:\users\frederick\documents\opencpn-data\o-plugin\ocpn_draw_pi\include\ocpn_
plugin.h(624): warning C4190: 'GetSharedDataLocation' has C-linkage specified,
but returns UDT 'wxString' which is incompatible with C [C:\Users\Frederick\Doc
uments\OpenCPN-Data\o-plugin\ocpn_draw_pi\build\ocpn_draw_pi.vcxproj]
  c:\users\frederick\documents\opencpn-data\o-plugin\ocpn_draw_pi\include\wx\js
on_defs.h(213): warning C4005: 'MIN' : macro redefinition [C:\Users\Frederick\D
ocuments\OpenCPN-Data\o-plugin\ocpn_draw_pi\build\ocpn_draw_pi.vcxproj]
  c:\users\frederick\documents\opencpn-data\o-plugin\ocpn_draw_pi\include\wx\js
on_defs.h(214): warning C4005: 'MAX' : macro redefinition [C:\Users\Frederick\D
ocuments\OpenCPN-Data\o-plugin\ocpn_draw_pi\build\ocpn_draw_pi.vcxproj]
  c:\users\frederick\documents\opencpn-data\o-plugin\ocpn_draw_pi\ocpninclude\d
ychart.h(85): warning C4005: 'snprintf' : macro redefinition [C:\Users\Frederic
k\Documents\OpenCPN-Data\o-plugin\ocpn_draw_pi\build\ocpn_draw_pi.vcxproj]
  ..\src\ocpn_draw_pi.cpp(779): warning C4101: 'y' : unreferenced local variabl
e [C:\Users\Frederick\Documents\OpenCPN-Data\o-plugin\ocpn_draw_pi\build\ocpn_d
raw_pi.vcxproj]
  ..\src\ocpn_draw_pi.cpp(779): warning C4101: 'x' : unreferenced local variabl
e [C:\Users\Frederick\Documents\OpenCPN-Data\o-plugin\ocpn_draw_pi\build\ocpn_d
raw_pi.vcxproj]
  c:\users\frederick\documents\opencpn-data\o-plugin\ocpn_draw_pi\include\ocpn_
plugin.h(624): warning C4190: 'GetSharedDataLocation' has C-linkage specified,
but returns UDT 'wxString' which is incompatible with C [C:\Users\Frederick\Doc
uments\OpenCPN-Data\o-plugin\ocpn_draw_pi\build\ocpn_draw_pi.vcxproj]
  c:\users\frederick\documents\opencpn-data\o-plugin\ocpn_draw_pi\include\ocpn_
plugin.h(624): warning C4190: 'GetSharedDataLocation' has C-linkage specified,
but returns UDT 'wxString' which is incompatible with C [C:\Users\Frederick\Doc
uments\OpenCPN-Data\o-plugin\ocpn_draw_pi\build\ocpn_draw_pi.vcxproj]
  c:\users\frederick\documents\opencpn-data\o-plugin\ocpn_draw_pi\include\ocpn_
plugin.h(624): warning C4190: 'GetSharedDataLocation' has C-linkage specified,
but returns UDT 'wxString' which is incompatible with C [C:\Users\Frederick\Doc
uments\OpenCPN-Data\o-plugin\ocpn_draw_pi\build\ocpn_draw_pi.vcxproj]
  c:\users\frederick\documents\opencpn-data\o-plugin\ocpn_draw_pi\include\ocpn_
plugin.h(624): warning C4190: 'GetSharedDataLocation' has C-linkage specified,
but returns UDT 'wxString' which is incompatible with C [C:\Users\Frederick\Doc
uments\OpenCPN-Data\o-plugin\ocpn_draw_pi\build\ocpn_draw_pi.vcxproj]
  c:\users\frederick\documents\opencpn-data\o-plugin\ocpn_draw_pi\include\ocpn_
plugin.h(624): warning C4190: 'GetSharedDataLocation' has C-linkage specified,
but returns UDT 'wxString' which is incompatible with C [C:\Users\Frederick\Doc
uments\OpenCPN-Data\o-plugin\ocpn_draw_pi\build\ocpn_draw_pi.vcxproj]
  C:\Users\Frederick\Documents\OpenCPN-Data\o-plugin\ocpn_draw_pi\include\ocpn_
plugin.h(624): warning C4190: 'GetSharedDataLocation' has C-linkage specified,
but returns UDT 'wxString' which is incompatible with C [C:\Users\Frederick\Doc
uments\OpenCPN-Data\o-plugin\ocpn_draw_pi\build\ocpn_draw_pi.vcxproj]
  c:\users\frederick\documents\opencpn-data\o-plugin\ocpn_draw_pi\include\wx\js
on_defs.h(213): warning C4005: 'MIN' : macro redefinition [C:\Users\Frederick\D
ocuments\OpenCPN-Data\o-plugin\ocpn_draw_pi\build\ocpn_draw_pi.vcxproj]
  c:\users\frederick\documents\opencpn-data\o-plugin\ocpn_draw_pi\include\wx\js
on_defs.h(214): warning C4005: 'MAX' : macro redefinition [C:\Users\Frederick\D
ocuments\OpenCPN-Data\o-plugin\ocpn_draw_pi\build\ocpn_draw_pi.vcxproj]
  C:\Users\Frederick\Documents\OpenCPN-Data\o-plugin\ocpn_draw_pi\ocpninclude\d
ychart.h(85): warning C4005: 'snprintf' : macro redefinition [C:\Users\Frederic
k\Documents\OpenCPN-Data\o-plugin\ocpn_draw_pi\build\ocpn_draw_pi.vcxproj]
  C:\Users\Frederick\Documents\OpenCPN-Data\o-plugin\ocpn_draw_pi\include\ocpn_
plugin.h(624): warning C4190: 'GetSharedDataLocation' has C-linkage specified,
but returns UDT 'wxString' which is incompatible with C [C:\Users\Frederick\Doc
uments\OpenCPN-Data\o-plugin\ocpn_draw_pi\build\ocpn_draw_pi.vcxproj]
  c:\users\frederick\documents\opencpn-data\o-plugin\ocpn_draw_pi\include\ocpn_
plugin.h(624): warning C4190: 'GetSharedDataLocation' has C-linkage specified,
but returns UDT 'wxString' which is incompatible with C [C:\Users\Frederick\Doc
uments\OpenCPN-Data\o-plugin\ocpn_draw_pi\build\ocpn_draw_pi.vcxproj]
  c:\users\frederick\documents\opencpn-data\o-plugin\ocpn_draw_pi\include\ocpn_
plugin.h(624): warning C4190: 'GetSharedDataLocation' has C-linkage specified,
but returns UDT 'wxString' which is incompatible with C [C:\Users\Frederick\Doc
uments\OpenCPN-Data\o-plugin\ocpn_draw_pi\build\ocpn_draw_pi.vcxproj]
  c:\users\frederick\documents\opencpn-data\o-plugin\ocpn_draw_pi\include\ocpn_
plugin.h(624): warning C4190: 'GetSharedDataLocation' has C-linkage specified,
but returns UDT 'wxString' which is incompatible with C [C:\Users\Frederick\Doc
uments\OpenCPN-Data\o-plugin\ocpn_draw_pi\build\ocpn_draw_pi.vcxproj]
  c:\users\frederick\documents\opencpn-data\o-plugin\ocpn_draw_pi\include\ocpn_
plugin.h(624): warning C4190: 'GetSharedDataLocation' has C-linkage specified,
but returns UDT 'wxString' which is incompatible with C [C:\Users\Frederick\Doc
uments\OpenCPN-Data\o-plugin\ocpn_draw_pi\build\ocpn_draw_pi.vcxproj]
  c:\users\frederick\documents\opencpn-data\o-plugin\ocpn_draw_pi\include\wx\js
on_defs.h(213): warning C4005: 'MIN' : macro redefinition [C:\Users\Frederick\D
ocuments\OpenCPN-Data\o-plugin\ocpn_draw_pi\build\ocpn_draw_pi.vcxproj]
  c:\users\frederick\documents\opencpn-data\o-plugin\ocpn_draw_pi\include\wx\js
on_defs.h(214): warning C4005: 'MAX' : macro redefinition [C:\Users\Frederick\D
ocuments\OpenCPN-Data\o-plugin\ocpn_draw_pi\build\ocpn_draw_pi.vcxproj]
  c:\users\frederick\documents\opencpn-data\o-plugin\ocpn_draw_pi\ocpninclude\d
ychart.h(85): warning C4005: 'snprintf' : macro redefinition [C:\Users\Frederic
k\Documents\OpenCPN-Data\o-plugin\ocpn_draw_pi\build\ocpn_draw_pi.vcxproj]
  c:\users\frederick\documents\opencpn-data\o-plugin\ocpn_draw_pi\include\ocpn_
plugin.h(624): warning C4190: 'GetSharedDataLocation' has C-linkage specified,
but returns UDT 'wxString' which is incompatible with C [C:\Users\Frederick\Doc
uments\OpenCPN-Data\o-plugin\ocpn_draw_pi\build\ocpn_draw_pi.vcxproj]
  c:\users\frederick\documents\opencpn-data\o-plugin\ocpn_draw_pi\include\ocpn_
plugin.h(624): warning C4190: 'GetSharedDataLocation' has C-linkage specified,
but returns UDT 'wxString' which is incompatible with C [C:\Users\Frederick\Doc
uments\OpenCPN-Data\o-plugin\ocpn_draw_pi\build\ocpn_draw_pi.vcxproj]
  c:\users\frederick\documents\opencpn-data\o-plugin\ocpn_draw_pi\include\wx\js
on_defs.h(213): warning C4005: 'MIN' : macro redefinition [C:\Users\Frederick\D
ocuments\OpenCPN-Data\o-plugin\ocpn_draw_pi\build\ocpn_draw_pi.vcxproj]
  c:\users\frederick\documents\opencpn-data\o-plugin\ocpn_draw_pi\include\wx\js
on_defs.h(214): warning C4005: 'MAX' : macro redefinition [C:\Users\Frederick\D
ocuments\OpenCPN-Data\o-plugin\ocpn_draw_pi\build\ocpn_draw_pi.vcxproj]
  c:\users\frederick\documents\opencpn-data\o-plugin\ocpn_draw_pi\include\ocpn_
plugin.h(624): warning C4190: 'GetSharedDataLocation' has C-linkage specified,
but returns UDT 'wxString' which is incompatible with C [C:\Users\Frederick\Doc
uments\OpenCPN-Data\o-plugin\ocpn_draw_pi\build\ocpn_draw_pi.vcxproj]
  c:\users\frederick\documents\opencpn-data\o-plugin\ocpn_draw_pi\include\wx\js
on_defs.h(213): warning C4005: 'MIN' : macro redefinition [C:\Users\Frederick\D
ocuments\OpenCPN-Data\o-plugin\ocpn_draw_pi\build\ocpn_draw_pi.vcxproj]
  c:\users\frederick\documents\opencpn-data\o-plugin\ocpn_draw_pi\include\wx\js
on_defs.h(214): warning C4005: 'MAX' : macro redefinition [C:\Users\Frederick\D
ocuments\OpenCPN-Data\o-plugin\ocpn_draw_pi\build\ocpn_draw_pi.vcxproj]
  C:\Users\Frederick\Documents\OpenCPN-Data\o-plugin\ocpn_draw_pi\include\ocpn_
plugin.h(624): warning C4190: 'GetSharedDataLocation' has C-linkage specified,
but returns UDT 'wxString' which is incompatible with C [C:\Users\Frederick\Doc
uments\OpenCPN-Data\o-plugin\ocpn_draw_pi\build\ocpn_draw_pi.vcxproj]
  c:\users\frederick\documents\opencpn-data\o-plugin\ocpn_draw_pi\include\wx\js
on_defs.h(213): warning C4005: 'MIN' : macro redefinition [C:\Users\Frederick\D
ocuments\OpenCPN-Data\o-plugin\ocpn_draw_pi\build\ocpn_draw_pi.vcxproj]
  c:\users\frederick\documents\opencpn-data\o-plugin\ocpn_draw_pi\include\wx\js
on_defs.h(214): warning C4005: 'MAX' : macro redefinition [C:\Users\Frederick\D
ocuments\OpenCPN-Data\o-plugin\ocpn_draw_pi\build\ocpn_draw_pi.vcxproj]
  C:\Users\Frederick\Documents\OpenCPN-Data\o-plugin\ocpn_draw_pi\include\ocpn_
plugin.h(624): warning C4190: 'GetSharedDataLocation' has C-linkage specified,
but returns UDT 'wxString' which is incompatible with C [C:\Users\Frederick\Doc
uments\OpenCPN-Data\o-plugin\ocpn_draw_pi\build\ocpn_draw_pi.vcxproj]
  c:\users\frederick\documents\opencpn-data\o-plugin\ocpn_draw_pi\src\ocpnpoint
.cpp(565): warning C4700: uninitialized local variable 'gFrame' used [C:\Users\
Frederick\Documents\OpenCPN-Data\o-plugin\ocpn_draw_pi\build\ocpn_draw_pi.vcxpr
oj]


"C:\Users\Frederick\Documents\OpenCPN-Data\o-plugin\ocpn_draw_pi\build\ALL_BUIL
D.vcxproj" (default target) (1) ->
"C:\Users\Frederick\Documents\OpenCPN-Data\o-plugin\ocpn_draw_pi\build\ocpn_dra
w_pi.vcxproj" (default target) (3) ->
(ClCompile target) ->
  ..\src\OCPNDrawPropertiesImpl.cpp(130): error C2664: 'atof' : cannot convert
parameter 1 from 'wxString' to 'const char *' [C:\Users\Frederick\Documents\Ope
nCPN-Data\o-plugin\ocpn_draw_pi\build\ocpn_draw_pi.vcxproj]

    35 Warning(s)
    1 Error(s)

Time Elapsed 00:00:33.06

C:\Users\Frederick\Documents\OpenCPN-Data\o-plugin\ocpn_draw_pi\build>

[jongough]

Hi,
I found that and fixed it, however, I did not get time to put it up git. I will do that tonight.

I think I have found what is causing the rubber banding to look wrong, i.e. start at the top of the screen and join to the cursor. It seems that under windows there is an extra mouse event which sets the current x/y position incorrectly. I am still trying understand why.

Now that I have a 'working' version I will look at the windows issues and see if I can fix them before doing more work on the functionality, i.e. right click processing of popup menus and rollovers.

Jon

[jongough]

I have put up the fix to the compile error under windows.

Going through the code it appears that GetCanvasPixLL is returning an incorrect value for the y coordinate, i.e. 0, and is causing the rubber banding to show up from the top of the screen. I am not sure why it is doing this, but I am running under VirtualBox and this 'may' be causing the issue.

Jon

[jongough]

I seem to have broken rubber banding with this though!

Originally Posted by jongough

I have put up the fix to the compile error under windows.

Going through the code it appears that GetCanvasPixLL is returning an incorrect value for the y coordinate, i.e. 0, and is causing the rubber banding to show up from the top of the screen. I am not sure why it is doing this, but I am running under VirtualBox and this 'may' be causing the issue.

Jon

[jongough]

I have got most of it working again. The preferences button now works from the plugins section of the options. You can set all the default settings for OCPNPoints (waypoints by any other name), Paths (not really used yet, but there for future developments) and Boundaries (this is what the plugin was about originally).

It works in Linux and Windows (tested on win7), although win7 on my system does not seem to handle recovery over a crash (forced stop), Linux does.

On Linux and win7 it works with both opengl and without.

Right clicks on boundaries and points will show a menu, but currently it will not do anything. That is next on the todo list.

If you want to try a Linux version you will need to compile it yourself (sorry, haven't worked out how to make an install package for it yet), for windows you will find an installable here:
https://www.dropbox.com/s/5fef6fy1ni...win32.exe?dl=0

Please be gentle, this is the first working, I think, version. If you find issues please let me know, but it may take a few days to fix it up. Can you please raise issues on github ( https://github.com/jongough/ocpn_draw_pi/issues ) as it makes it easier for me to track.

Thanks
Jon

[rgleason]

Jon, have compiled it using previous v4.1 opencpn.lib, hope that is ok.
It does seem to work much better under windows. I git checkout master this time and compiled it. Let me know when I should update opencpn.lib if it needs to change, thanks.

In fact I found all the previous boundaries that disappeared now showing up and from the manage menu when I hit "deactivate" and then "activate" the screen zoomed into the activated boundary, so now I knew where the boundary in the list was located.
- It would be nice to have the boundaries change somehow, larger line weight? when the cursor has selected them or cursor is hoovering over or whatever. Also that line in the manager could get darker during that time to make it easier to know which boundary is connected to what. There might be easier ways to accomplish this.

The boundaries wnen "deactivated" turn light yellow and remain on the charts and you cannot change properties (is this true Jon) or select them until they are active.

If you use the "eye" for show and do not show in the manager the entire boundary will disappear.

The rubber banding is Working -- great. Its much much better. You might want to prevent complex shapes that go over themselves by not allowing the rubber band line to cross the pre entered boundary.

I have not tested editing of boundaries or is that the next challenge?

I found the ocpn_points could be entered and tried the rings but they did not show. I guess that is work still in progress...

Very nice progress. Did not do much with layers yet.

I uploaded this to Opencpn File Thingie rguser rgpass 4.1 PI Win directory.

Will make better comments in git Issues on your repository. Guys remember this works with the current version of 4.1

[rgleason]

Perhaps at some point to call your plugin the simple and powerful name of "draw_pi" ? easier typing etc.?

[rgleason]

Jon, The selection process for Boundaries and Ocpn_Points where you click on the right icon then left click to scroll through in workable for up to 3 entity types.

Also the Ocpn_Point Range rings Work fine.

[jongough]

The current version in git (boundary branch) now has right click on the objects. Delete and Properties work, Move is moving the points a couple of pixels, not sure what is wrong. It does work on Windows. If you want the latest windows build you can find it here:
https://www.dropbox.com/s/er0admadn7...win32.exe?dl=0

Jon

[rgleason]

Jon, in the current version, I found that 'right click' move points works, move boundary point works, remove point from path works. ..Great progress.

Maybe there could be a
"Move entire boundary intact"
"Insert/Add a boundary point"
at some point.

Ps We need a "delete ocpn_point" too.
Also for Boundaries would need
"Delete boundary point" - now "delete"
"Delete bounary path"

With Accel Graphics (opengl) the boundary is not redrawing as before. I understand that is still an open issue.

Also your icons look better. Maybe darken the lines in the "manager" like routing.

[Taarnskov]

Where do i find 4.1

Lars

[nohal]

Lars...
There is no 4.1, the master code is not ready for any type of release, not even beta.

Pavel

[jongough]

Rick,
If you right click on the boundary, not a boundary point you will find that you can insert a new point into the boundary or delete the whole boundary. If you right click on a point in a boundary you can remove the point from the boundary (just need to change the wording on the popup) or delete the point.

Opengl seems a little 'unstable' as the redraw seems to change at times and I don't think I have changed the code in the drawing area for a little while. I will track it down, but it is rather elusive.

I am looking at the icons to see if I can come up with better/clearer ones, but that is on the back burner at the moment as I try to get the base functionality working.

I will look at moving the whole boundary, but it may take a little while.

Originally Posted by rgleason

Jon, in the current version, I found that 'right click' move points works, move boundary point works, remove point from path works. ..Great progress.

Maybe there could be a
"Move entire boundary intact"
"Insert/Add a boundary point"
at some point.

Ps We need a "delete ocpn_point" too.
Also for Boundaries would need
"Delete boundary point" - now "delete"
"Delete bounary path"

With Accel Graphics (opengl) the boundary is not redrawing as before. I understand that is still an open issue.

Also your icons look better. Maybe darken the lines in the "manager" like routing.

[jongough]

Lars,
If you want to try out the plugin you will need the latest OCPN code, but it is not available as a binary, only in source form from github. So to try out the plugin you would really need to get the OCPN code from here: https://github.com/OpenCPN/OpenCPN and the latest version of the plugin (if you are not using windows) from here: https://github.com/jongough/ocpn_draw_pi and https://github.com/jongough/ocpn_draw_pi/tree/Boundary as the latest changes are in the Boundary tree at the moment.

If you cannot or don't know how to buld OCPN, then I am affraid that you will need to wait until at least a beta version is made available. My Plugin is still very much 'Alpha', although it is stablising a bit now, so it is not ready for real use, but it is ready enough to see if the concept is useful.

Jon

Originally Posted by Taarnskov

Where do i find 4.1

Lars

[seandepagnier]

Could someone explain to me the intended purpose of this plugin?

I could see it useful for alarms, and maybe even weather routing, but not sure it should be a separate plugin for these cases.