Weather Routing

[stelian]

Originally Posted by stelian

Ok, I will be coding something along these lines in the next days.

Never leave for tomorrow what you can do today, right ?

What do you think of this (wording, additional choices etc) ?

[stelian]

A side question: since commit 12454d "Replace the time selection controls with wxTimePickerCtrl. Fixes #139" I can no longer open WeatherRouting.fbp in wxformbuilder, I get instead an error saying "Component for wxTimePickerCtrl not found! <visualeditor.cpp@745>"

My wxformbuilder is locally built from git master.

What sort of configuration or build option am I missing ? Google doesn't say anything obvious about this.

[rgleason]

I think this wording would make me think that if I have created new boat.xml and polar files with unique names and had some configurations that I wanted to keep, that they will get overwritten. I don't believe that is the intent.

The intent is to add new example boat.xml and polars and configurations that will work "out of the box" and to properly configure the plugin so that it using the correct user programdata/opencpn/plugins/weatherouting/ (boats, polars, etc) directories that are writeable.

All new users of the plugin should accept this!

[rgleason]

Stelian, I think the choices are good.
Maybe, "Import new example configs, boats and polars." assuming the previous installation is working properly.
"Import default config, boat and polar files" for all new users or to reset the entire configuration.

[rgleason]

Sorry this is so involved.

[rgleason]

I suppose a third choice could be "Leave my config, boat and polar files alone." Where you must pick one of the three.

[stelian]

Originally Posted by rgleason

I think this wording would make me think that if I have created new boat.xml and polar files with unique names and had some configurations that I wanted to keep, that they will get overwritten. I don't believe that is the intent.

You're correct. Feel free to suggest an alternative wording (I'm not a native English speaker after all).

Originally Posted by rgleason

The intent is to add new example boat.xml and polars and configurations that will work "out of the box"

New boat and polars who may be updated, and "example configurations" that will work out of the box

Originally Posted by rgleason

and to properly configure the plugin so that it using the correct user programdata/opencpn/plugins/weatherouting/ (boats, polars, etc) directories that are writeable.

This should be ok even if you choose CANCEL, because, if the boats or polars directory doesn't exist, the plugin will still copy the files to the correct place.

Originally Posted by rgleason

All new users of the plugin should accept this!

I could check the boxes by default if the plugin has never been used (since the introduction of the test, that's it). How's that ?

[nohal]

Originally Posted by stelian

A side question: since commit 12454d "Replace the time selection controls with wxTimePickerCtrl. Fixes #139" I can no longer open WeatherRouting.fbp in wxformbuilder, I get instead an error saying "Component for wxTimePickerCtrl not found! <visualeditor.cpp@745>"

My wxformbuilder is locally built from git master.

What sort of configuration or build option am I missing ? Google doesn't say anything obvious about this.

The latest wxFormbuilder master, including https://github.com/wxFormBuilder/wxFormBuilder/pull/351 should definitely work. It is what I used to edit that file. But building wxFormbuilder correctly may get tricky...

[kevinvh]

Originally Posted by stelian

Never leave for tomorrow what you can do today, right ?

What do you think of this (wording, additional choices etc) ?

Can I suggest the following:

A new version of the Weather Route plugin has been installed.

"Import new boats and polars" will overwrite your existing boat and polar configurations with newer data. If you have created your own polars and want to retain them, copy those polars to your desktop before selecting this option. You can copy them back to your polar folder after the update.

"Do not overwrite boats and polars" will not update boats and polars and you will be asked to choose again when OpenCPN is next launched.

O Import new boats and polars
O Do not overwrite boats and polars

Cancel OK

[nohal]

A little experiment to allow saving screen estate: https://github.com/seandepagnier/wea...ng_pi/pull/148

[kevinvh]

Originally Posted by nohal

A little experiment to allow saving screen estate: https://github.com/seandepagnier/wea...ng_pi/pull/148

I like that Pavel - almost as good as having a Window menu to select the preferred window on top. Are you fixing the column width format as well?

[nohal]

Originally Posted by kevinvh

Are you fixing the column width format as well?

No, this has nothing to do with column widths, they adjust automatically. And since https://github.com/seandepagnier/wea...9b279eb94eb95b differently than before, but automatically.

[seandepagnier]

Originally Posted by kevinvh

Can I suggest the following:

A new version of the Weather Route plugin has been installed.

"Import new boats and polars" will overwrite your existing boat and polar configurations with newer data. If you have created your own polars and want to retain them, copy those polars to your desktop before selecting this option. You can copy them back to your polar folder after the update.

"Do not overwrite boats and polars" will not update boats and polars and you will be asked to choose again when OpenCPN is next launched.

O Import new boats and polars
O Do not overwrite boats and polars

Cancel OK

It's a nice idea, but I want to understand why this is such an issue.

It shouldn't overwrite any polars you made with unique names. If you edit a polar, but use the existing filename, then it may be overwritten. I would suggest users save their own polars in a unique place anyway.

I think it's more important we modify the existing polars to define speeds with wind speeds up to 60 knots (rather than only 20) Not sure how to do it, as many boats cannot beat against the wind in these conditions at all.

[stelian]

Originally Posted by nohal

The latest wxFormbuilder master, including https://github.com/wxFormBuilder/wxFormBuilder/pull/351 should definitely work. It is what I used to edit that file. But building wxFormbuilder correctly may get tricky...

Ok, it works now. For some reason the build did generate a binary named "output/bin/wxformbuilder-30" instead of overwriting the old one called "output/bin/wxformbuilder"...

[stelian]

Originally Posted by boat_alexandra

It's a nice idea, but I want to understand why this is such an issue.

It shouldn't overwrite any polars you made with unique names.

And it doesn't. kevinvh wording is misleading indeed, how about:

A new version of the Weather Route plugin has been installed.

"Import new boats and polars" will overwrite the provided boats and polars with newer data. If you have modified this data by yourself, your modifications will be lost, so be sure to backup them. If you have added new polars or boats, they will be kept untouched.

"Import example configurations" will overwrite your route configurations with a sample set showing you how WeatherRouting works. Backup your existing configurations if you need.

Pressing "OK" will apply the selected changes, pressing "Cancel" will do nothing and you will be asked again on the next launch.

O Import new boats and polars
O Import example route configurations

(there are checkboxes not exclusive choices !)