OpenCPN Version 2.4 Release Candidate 714

[nohal]

Dave...
Fedora 15 startup crash accounts to Fedora's TinyXML, with the bundled one everything is ok... Looking at it now. With the assembler problem, I of course don't have any clue.

Pavel

[rooiedirk]

Hoi Dave,
a small not very annoying thing. If I have opencpn switchet to background with a tooltip opened, the tooltip stayes on top, even above the newly opened application.
Noticed under OpenSuse and Kubuntu
Dirk

[steffenp]

Hi,

have a problem building opencpn for Opensuse Factory (the next version)
i586. x86_64 works.

Gcc is version 4.6.1

The komplete Log kan be found here:
https://build.opensuse.org/package/r...enSUSE_Factory

Any ideas?

[ 15%] Building CXX object CMakeFiles/S57ENC.dir/src/s52plib.cpp.o
/usr/src/packages/BUILD/opencpn/src/s52plib.cpp: In member function 'int s52plib::ParseLUPT(FILE*)':
/usr/src/packages/BUILD/opencpn/src/s52plib.cpp:1159:14: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
/usr/src/packages/BUILD/opencpn/src/s52plib.cpp: In member function 'bool s52plib::S52_flush_Plib()':
/usr/src/packages/BUILD/opencpn/src/s52plib.cpp:1900:13: warning: variable 'pR' set but not used [-Wunused-but-set-variable]
/usr/src/packages/BUILD/opencpn/src/s52plib.cpp: In member function  'bool s52plib::RenderHPGLtoDC(char*, char*, wxDC*, wxPoint&,  wxPoint&, double)':
/usr/src/packages/BUILD/opencpn/src/s52plib.cpp:2814:14: warning:  variable 'polyMode' set but not used [-Wunused-but-set-variable]
/usr/src/packages/BUILD/opencpn/src/s52plib.cpp: In member function 'int s52plib::RenderLC(ObjRazRules*, Rules*, ViewPort*)':
/usr/src/packages/BUILD/opencpn/src/s52plib.cpp:3890:17: warning: variable 'w' set but not used [-Wunused-but-set-variable]
/usr/src/packages/BUILD/opencpn/src/s52plib.cpp: In member function 'int s52plib::PrioritizeLineFeature(ObjRazRules*, int)':
/usr/src/packages/BUILD/opencpn/src/s52plib.cpp:4948:23: warning: variable 'inode' set but not used [-Wunused-but-set-variable]
/usr/src/packages/BUILD/opencpn/src/s52plib.cpp: In member function 'int  s52plib::dda_tri(wxPoint*, S52color*, render_canvas_parms*,  render_canvas_parms*)':
/usr/src/packages/BUILD/opencpn/src/s52plib.cpp:5231:12: warning: variable 'dda8' set but not used [-Wunused-but-set-variable]
/usr/src/packages/BUILD/opencpn/src/s52plib.cpp: Assembler messages:
/usr/src/packages/BUILD/opencpn/src/s52plib.cpp:5547: Error: symbol `l0' is already defined
/usr/src/packages/BUILD/opencpn/src/s52plib.cpp:5552: Error: symbol `l1' is already defined
/usr/src/packages/BUILD/opencpn/src/s52plib.cpp:5559: Error: symbol `l2' is already defined
make[2]: *** [CMakeFiles/S57ENC.dir/src/s52plib.cpp.o] Error 1
make[1]: *** [CMakeFiles/S57ENC.dir/all] Error 2
make: *** [all] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.V3Rh9p (%build)

[nohal]

It's the same like on Fedora 15. I managed to compile, but am quite a bit confused with the reasons.
All the changes needed to compile on Fedora in one patch at https://github.com/OpenCPN/OpenCPN/issues/2

Pavel

[bdbcat]

nohal/steffenp

Try this:
Replace the following block of code in s52plib.cpp

#define memset3(dest, value, count) \
__asm__ __volatile__ ( \
"cmp $0,%2\n\t" \
"jg 2f\n\t" \
"je 3f\n\t" \
"jmp 4f\n\t" \
"2:\n\t" \
"movl  %0,(%1)\n\t" \
"add $3,%1\n\t" \
"dec %2\n\t" \
"jnz 2b\n\t" \
"3:\n\t" \
"movb %b0,(%1)\n\t" \
"inc %1\n\t" \
"movb %h0,(%1)\n\t" \
"inc %1\n\t" \
"shr $16,%0\n\t" \
"movb %b0,(%1)\n\t" \
"4:\n\t" \
: : "a"(value), "D"(dest), "r"(count) :  );

Root cause:
-O3 optimization inlines this function, several times. So the absolute labels get duplicated. The new code (above) tries to use local label references, iiuc the gcc docs.

If this does not work, you could edit CMakeLists.txt, and switch from -O3 to -O2 optimization, avoiding inlining....

Let me know
Dave

[steffenp]

Thanks Pavel,

I have no Problem yet, I only want to mention that there might be a problem with future versions of OpenSuse or better gcc.
Thats the main reason building for factory for me.

I think this schould be fixed before the new stable Release.

[nohal]

Originally Posted by bdbcat

nohal/steffenp

Try this:
Replace the following block of code in s52plib.cpp

#define memset3(dest, value, count) \
__asm__ __volatile__ ( \
"cmp $0,%2\n\t" \
"jg 2f\n\t" \
"je 3f\n\t" \
"jmp 4f\n\t" \
"2:\n\t" \
"movl  %0,(%1)\n\t" \
"add $3,%1\n\t" \
"dec %2\n\t" \
"jnz 2b\n\t" \
"3:\n\t" \
"movb %b0,(%1)\n\t" \
"inc %1\n\t" \
"movb %h0,(%1)\n\t" \
"inc %1\n\t" \
"shr $16,%0\n\t" \
"movb %b0,(%1)\n\t" \
"4:\n\t" \
: : "a"(value), "D"(dest), "r"(count) :  );

Root cause:
-O3 optimization inlines this function, several times. So the absolute labels get duplicated. The new code (above) tries to use local label references, iiuc the gcc docs.

If this does not work, you could edit CMakeLists.txt, and switch from -O3 to -O2 optimization, avoiding inlining....

Let me know
Dave

Dave...

You get all the point as usually Compiles well on Fedora 15

Pavel

[steffenp]

Dave

Compiles well on all current versions of OpenSuSE. (11.3/11.4/Factory/Tumbleweed) for both, i586 and x86_64.

[sailias]

Compiles without issues on Ubuntu 32 11.04. Now I build tinyXML from source but cmake cannot find it. Tried /usr/lib/tinyxml and /usr/lib/tinyxml but no luck. Build goes to completion without however. As I dont know what its used for cannot check for functionality. Clues?

/ch

[nohal]

The embedded TinyXml is used when cmake fails to find it, so no problem. If there was a problem you would probably note it as all the route, track and waypoint handling is based on it.

Pavel

[HamishB]

Originally Posted by sailias

Compiles without issues on Ubuntu 32 11.04. Now I build tinyXML from source but cmake cannot find it. Tried /usr/lib/tinyxml and /usr/lib/tinyxml but no luck.

tinyxml on ubuntu natty (11.04) is found in thelibtinyxml-dev package (et al)

Ubuntu -- Details of package libtinyxml-dev in natty


no need to compile it yourself if you don't want to.


Hamish

[lfabio]

Win7/64, multiple machines: problem with chart borders still alive and well as described in my previous thread.
Edit: network drive issue solved by accessing the drive before opening openCPN. Odd, but that works now.

[cagney]

Originally Posted by lfabio

Win7/64, multiple machines: problem with chart borders still alive and well as described in my previous thread.
....
.

Can you give us a link to the post, where you describe his problem?
Thomas

[Zoef]

OpenCPN crashed (twice) on me while zooming in. Yesterday the same happened while on the previous version.

Problem Event Name: APPCRASH
Application Name: opencpn.exe
Application Version: 2.4.714.0
Application Timestamp: 4e1edf02
Fault Module Name: opencpn.exe
Fault Module Version: 2.4.714.0
Fault Module Timestamp: 4e1edf02
Exception Code: c0000005
Exception Offset: 00033c2b
OS Version: 6.1.7600.2.0.0.256.1
Locale ID: 1043
Additional Information 1: 0a9e
Additional Information 2: 0a9e372d3b4ad19135b953a78882e789
Additional Information 3: 0a9e
Additional Information 4: 0a9e372d3b4ad19135b953a78882e789


The logfile is in
http://dl.dropbox.com/u/35040940/opencpn.log

Klaas

[bdbcat]

ifabio....
After looking at your log, I just wonder if part of the problem is related to the "Y" drive? The 2.4 Beta series make much higher demands on the file system than 1.3.6, mainly due to full screen quilting....

Just wondering.....

Dave




Thomas: Here is a link
http://www.cruisersforum.com/forums/...6-a-63450.html