OpenCPN Beta Version 3.3.1117 Released

[bcn]

Your GPS should show up in 3.2.2 or in the beta you installed.
No need to wait for another year or two.

Give it a try (and have a look at the manual first), after configuring everything at the connection tab of settings (the "wrench" button).

Hubert

[CarCode]

To avoid an assert with Dashboard plugin using wxWidgets 3.1 and Xcode 5.0.2 for Mac OS X Mavericks I have changed in dashboard_pi.cpp at function dashboard_pi::SaveConfig()
line 1237 from:

for( size_t i = 0; i < m_ArrayOfDashboardWindow.GetCount(); i++ ) {

to:

for( unsigned int i = 0; i < m_ArrayOfDashboardWindow.GetCount(); i++ ) {

line 1239 from:

pConf->SetPath( wxString::Format( _T("/PlugIns/Dashboard/Dashboard%d"), i + 1 ) );

to:

pConf->SetPath( wxString::Format( _T("/PlugIns/Dashboard/Dashboard%i"), i + 1 ) );

line 1245,1246 from:

for( size_t j = 0; j < cont->m_aInstrumentList.GetCount(); j++ )
pConf->Write( wxString::Format( _T("Instrument%d"), j + 1 ),

to:

for( unsigned int j = 0; j < cont->m_aInstrumentList.GetCount(); j++ )
pConf->Write( wxString::Format( _T("Instrument%i"), j + 1 ),

Gerhard

[Gilletarom]

Hello Dave, hello other OCPN testers

ASUS EeePC 10' W7 starter. OCPN 33117, OpenGL ON or OFF.

There are some days, all New Zealand raster charts were posted freely by New Zealand state.
Here are the links :
NZMariner - Official Raster Navigational Charts (RNCs) | Land Information New Zealand (LINZ) - Toit
and more directly :
http://www.linz.govt.nz/sites/defaul...r/BSB_BASE.zip

So using this second link, I downloaded these raster charts.

There is a large amount of charts. Some of these charts are not charts "North up".
I encountered a problem with two of these charts:
- NZ2301.kap
- NZ2601.kap

See the attached screenshot of my configuration OCPN 33117.

If I select one of these two charts, other charts red borderlines do not move properly when the chart is moved with the mouse.
See the first two screenshots to understand what I am saying here.

Am I alone with this problem? If I'm not alone, I will put this in tracker.

B.R. Gilletarom

[Gilletarom]

Sorry Dave, I had missed something.

The NZ2301 NZ2601 charts and basically does not take advantage of recently downloaded charts. They are another set of charts in New Zealand, previously downloaded. They were already in my computer but in another folder of cards.
But I do not know where, and when I downloaded these charts.

B.R. Gilletarom.

Error:
These two charts are really in the official set of New Zealand charts.

And the problem that I speak in my previous post is really occured.

B.R. Gilletarom.

[Gilletarom]

Hello Dave,

Additional Note:
Red borders of these charts do not appear on the screen OCPN
The first two charts listed (2301, 2601), we must add the chart n ° 14601.

[SethDart]

Originally Posted by CarCode

To avoid an assert with Dashboard plugin using wxWidgets 3.1 and Xcode 5.0.2 for Mac OS X Mavericks I have changed in dashboard_pi.cpp at function dashboard_pi::SaveConfig()

Hi Gerhard,

Are you sure the assert is right there?

According to wxWidgets: wxArray< T > Class Template Reference this code is right (see GetCount definition, the return type is size_t)
If we change it here, we should change it all around where we use GetCount. For example DeInit() or it may assert as well...

Thanks,
Jean-Eudes

[CarCode]

Originally Posted by SethDart

Hi Gerhard,

Are you sure the assert is right there?

According to wxWidgets: wxArray< T > Class Template Reference this code is right (see GetCount definition, the return type is size_t)
If we change it here, we should change it all around where we use GetCount. For example DeInit() or it may assert as well...

Thanks,
Jean-Eudes

It only gives an assert here with wxWidgets 3.1, Xcode 5.0.2 and Mac OS X SDK 10.9 at this point and no where else. Might be strange but this was the fact. After changing the code as shown the assert was gone.

Gerhard

[CarCode]

Jean-Eudes,

Addendum
I cannot use wxWidgets v2.8 for Mac OS X. There are several fixes between wxWidgets v2.9 and v3.1 especially for Mac OS X. The latest fix is just from 2 days ago, see: https://groups.google.com/forum/?fro...rs/rvqrhuizsvA

So I always use the latest wxWdgets version for Mac OS X.

Gerhard

[SethDart]

Originally Posted by CarCode

It only gives an assert here with wxWidgets 3.1, Xcode 5.0.2 and Mac OS X SDK 10.9 at this point and no where else. Might be strange but this was the fact. After changing the code as shown the assert was gone.

Gerhard

Can you try this fix instead?

diff --git a/plugins/dashboard_pi/src/dashboard_pi.cpp b/plugins/dashboard_pi/src/dashboard_pi.cpp
index 4239237..17ca645 100644
--- a/plugins/dashboard_pi/src/dashboard_pi.cpp
+++ b/plugins/dashboard_pi/src/dashboard_pi.cpp
@@ -1236,7 +1236,7 @@ bool dashboard_pi::SaveConfig( void )
         pConf->Write( _T("DashboardCount" ), (int) m_ArrayOfDashboardWindow.GetCount() );
         for( size_t i = 0; i < m_ArrayOfDashboardWindow.GetCount(); i++ ) {
             DashboardWindowContainer *cont = m_ArrayOfDashboardWindow.Item( i );
-            pConf->SetPath( wxString::Format( _T("/PlugIns/Dashboard/Dashboard%d"), i + 1 ) );
+            pConf->SetPath( wxString::Format( _T("/PlugIns/Dashboard/Dashboard%zu"), i + 1 ) );
             pConf->Write( _T("Name"), cont->m_sName );
             pConf->Write( _T("Caption"), cont->m_sCaption );
             pConf->Write( _T("Orientation"), cont->m_sOrientation );

Please report if the assert is gone...
I'd like to avoid platform specific changes. I guess that one is related to a glitch in some optimized code.

Thanks,
Jean-Eudes

[CarCode]

Jean-Eudes,

both lines (1239 + 1246) I have had to change to %zu instead of formerly %d.
Otherwise I get an assert and a crash later at SaveConfig():

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0 libsystem_kernel.dylib 0x00007fff8ca7f292 __kill + 10
1 libwx_baseu-3.1.dylib 0x000000010862cf02 wxTrap() + 18 (appbase.cpp:1054)
2 libwx_baseu-3.1.dylib 0x000000010862f7b8 wxDefaultAssertHandler(wxString const&, int, wxString const&, wxString const&, wxString const&) + 216 (appbase.cpp:1077)
3 libwx_baseu-3.1.dylib 0x000000010862d9a0 wxOnAssert(char const*, int, char const*, char const*, char const*) + 160 (appbase.cpp:1169)
4 libwx_osx_cocoau_core-3.1.dylib 0x00000001079e856e wxWindow::MacPaintBorders(int, int) + 398 (window_osx.cpp:1624)
5 libwx_osx_cocoau_core-3.1.dylib 0x00000001079ea2eb wxWindow::MacPaintChildrenBorders() + 555 (window_osx.cpp:2166)
6 libwx_osx_cocoau_core-3.1.dylib 0x0000000107b03e23 wxWidgetCocoaImpl::drawRect(void*, NSView*, void*) + 2659 (window.mm:1674)
7 libwx_osx_cocoau_core-3.1.dylib 0x0000000107b01543 wxOSX_drawRect(NSView*, objc_selector*, CGRect) + 707 (window.mm:1110)
8 com.apple.AppKit 0x00007fff90c533fb -[NSView _drawRect:clip:] + 3846
9 com.apple.AppKit 0x00007fff90c50386 -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVis ibleRect:rectIsVisibleRectForView:topView:] + 3199
10 com.apple.AppKit 0x00007fff90c50f0e -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVis ibleRect:rectIsVisibleRectForView:topView:] + 6151
11 com.apple.AppKit 0x00007fff90c50f0e -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVis ibleRect:rectIsVisibleRectForView:topView:] + 6151
12 com.apple.AppKit 0x00007fff90c4f201 -[NSThemeFrame _recursiveDisplayRectIfNeededIgnoringOpacity:isVis ibleRect:rectIsVisibleRectForView:topView:] + 314
13 com.apple.AppKit 0x00007fff90c4c209 -[NSView _displayRectIgnoringOpacity:isVisibleRect:rectIsVi sibleRectForView:] + 2828
14 com.apple.AppKit 0x00007fff90c2b63a -[NSView displayIfNeeded] + 1680
15 com.apple.AppKit 0x00007fff90c9089e _handleWindowNeedsDisplayOrLayoutOrUpdateConstrain ts + 884
16 com.apple.AppKit 0x00007fff91264cd1 __83-[NSWindow _postWindowNeedsDisplayOrLayoutOrUpdateConstraints UnlessPostingDisabled]_block_invoke1331 + 46
17 com.apple.CoreFoundation 0x00007fff876640a7 __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK _FUNCTION__ + 23
18 com.apple.CoreFoundation 0x00007fff87664017 __CFRunLoopDoObservers + 391
19 com.apple.CoreFoundation 0x00007fff876557b8 __CFRunLoopRun + 776
20 com.apple.CoreFoundation 0x00007fff87655275 CFRunLoopRunSpecific + 309
21 com.apple.HIToolbox 0x00007fff879b7f0d RunCurrentEventLoopInMode + 226
22 com.apple.HIToolbox 0x00007fff879b7b85 ReceiveNextEventCommon + 173
23 com.apple.HIToolbox 0x00007fff879b7abc _BlockUntilNextEventMatchingListInModeWithFilter + 65
24 com.apple.AppKit 0x00007fff90af428e _DPSNextEvent + 1434
25 com.apple.AppKit 0x00007fff90af38db -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 122
26 com.apple.AppKit 0x00007fff90e52c5e -[NSApplication _realDoModalLoopeek:] + 642
27 com.apple.AppKit 0x00007fff90e5136e -[NSApplication runModalForWindow:] + 117
28 com.apple.AppKit 0x00007fff90e50f1d -[NSAlert runModal] + 145
29 libwx_osx_cocoau_core-3.1.dylib 0x0000000107ae03db wxMessageDialog::ShowModal() + 3259 (msgdlg.mm:161)
30 libwx_osx_cocoau_core-3.1.dylib 0x00000001079c809a wxMessageBox(wxString const&, wxString const&, long, wxWindow*, int, int) + 202 (utilscmn.cpp:1367)
31 libwx_osx_cocoau_core-3.1.dylib 0x0000000107b0fae4 wxGUIAppTraitsBase::ShowAssertDialog(wxString const&) + 308 (appcmn.cpp:475)
32 libwx_baseu-3.1.dylib 0x000000010862ed6e ShowAssertDialog(wxString const&, int, wxString const&, wxString const&, wxString const&, wxAppTraits*) + 958 (appbase.cpp:1302)
33 libwx_baseu-3.1.dylib 0x000000010862e8c5 wxAppConsoleBase::OnAssertFailure(wchar_t const*, int, wchar_t const*, wchar_t const*, wchar_t const*) + 197 (appbase.cpp:781)
34 libwx_baseu-3.1.dylib 0x000000010862f939 wxDefaultAssertHandler(wxString const&, int, wxString const&, wxString const&, wxString const&) + 601 (appbase.cpp:1093)
35 libwx_baseu-3.1.dylib 0x000000010862d9a0 wxOnAssert(char const*, int, char const*, char const*, char const*) + 160 (appbase.cpp:1169)
36 libdashboard_pi.dylib 0x00000001112de7a9 dashboard_pi::SaveConfig() + 2537

So changing of both lines is needed.

Gerhard

[SethDart]

Originally Posted by CarCode

Jean-Eudes,

both lines (1239 + 1246) I have had to change to %zu instead of formerly %d.
Otherwise I get an assert and a crash later at SaveConfig():


So changing of both lines is needed.

Gerhard

Changes applied and pushed to git. Did you open a bug report for this?

Thanks,
Jean-Eudes

[CarCode]

No, I have not wrote it into Flyspray.

Gerhard

[Hakan]

Crash report in Dashboard using version from Git at ~UTC 11:00
Crash report sent today
Despite this update was meant for Mac I made a test.
Narration
WinXP no OpenGL
-Pulled Git - ok
-Build cmake - ok
-Debug OCPN VS10 - ok
-Release OCPN VS10 - ok. Copied .exe to standard lib and runs ok. (Didn't test Dashboard at this time)
-Debug Dashboard - ok
-Release Dashboard -ok
-Copied the new dashboard_pi.dll to standard lib\plugins
-Run OCPN and open dashboard. In dashboard right click to change configuration. Deleted last row of instruments.(COG) and added clock. Hit button "OK" - Crash!
-Run OCPN and open dashboard. In dashboard right click to change configuration. The COG was deleted from instrument list but no clock. Hit button "OK" - Crash! .....And repetition a couple of times.
-Put back the original 3.3.1117 dashboard-pi.dll to standard lib\plugins.
-Run OCPN and open dashboard. In dashboard right click to change configuration. Added the clock instrument Hit button "OK" - ok. The clock was added nicely.

Håkan

[CarCode]

I cannot check these diffs of dashboard for Linux or Windows or other configurations.
I suggest to include the diffs with
#ifdef __WXOSX__ and #if wxCHECK_VERSION(3,1,0)

They are needed for Mac OS X and wxWidgets 3.1 in any case.

Gerhard

[SethDart]

That's the info I found so far:

Unfortunately, Microsoft's C compiler does not support the z size modifier for printf()
z modifier is a part of C99 standard. Microsoft compilers so far used C89/90.

So we'll have to handle it separately :-( I'll come with another patch to fix this.

Thanks for reporting.

Jean-Eudes