OpenCPN Version 2.4 Release Candidate 720

[steffenp]

Hi Dave,

Originally Posted by bdbcat

Hi there....

Before I pull the trigger, lets have one more smoke test.

Compiles on all current versions of opensuse and starts up on at least opensue 11.4/X86_64

Will be available soon on my repo.

regards
Steffen

[SethDart]

Originally Posted by nohal

Just one thing left: Did you here from SethDart lately? We should either update the logbook plugin to the latest git code to have a version working with 2.5.0 or temporarily remove it from PlugIns | Official OpenCPN Homepage

Hi Pavel,

I updated i386 version 3 days ago but could not get 2.4.720 to compile on my Ubuntu 11.04 amd64 VM

CMakeFiles/opencpn.dir/src/gpxdocument.cpp.o: In function `GpxDocument::~GpxDocument()':
gpxdocument.cpp:(.text+0x1b2): undefined reference to `TiXmlString::nullrep_'
CMakeFiles/opencpn.dir/src/gpxdocument.cpp.o: In function `GpxDocument::~GpxDocument()':
gpxdocument.cpp:(.text+0x1e2): undefined reference to `TiXmlString::nullrep_'
CMakeFiles/opencpn.dir/src/gpxdocument.cpp.o: In function `GpxSimpleElement::GpxSimpleElement(wxString const&, wxString const&)':
gpxdocument.cpp:(.text+0x18d7): undefined reference to `TiXmlString::assign(char const*, unsigned long)'
CMakeFiles/opencpn.dir/src/gpxdocument.cpp.o: In function `TiXmlDocument::~TiXmlDocument()':
gpxdocument.cpp:(.text._ZN13TiXmlDocumentD2Ev[_ZN13TiXmlDocumentD5Ev]+0x12): undefined reference to `TiXmlString::nullrep_'
CMakeFiles/opencpn.dir/src/gpxdocument.cpp.o: In function `TiXmlDocument::~TiXmlDocument()':
gpxdocument.cpp:(.text._ZN13TiXmlDocumentD0Ev[_ZN13TiXmlDocumentD5Ev]+0x12): undefined reference to `TiXmlString::nullrep_'
collect2: ld returned 1 exit status

Dave, this may be related to reported failure to install to 11.04
That patch allowed me to compile cleanly:

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 5ec9233..6218453 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -325,9 +325,12 @@ SET(SRC_TINYXML
       )
 
 IF(TINYXML_FOUND)
+    message (STATUS "Building with tinyxml includes")
     INCLUDE_DIRECTORIES(${TINYXML_INCLUDE_DIR})
+    ADD_DEFINITIONS(-DTIXML_USE_STL)
 ELSE(TINYXML_FOUND)
   SET(SRCS ${SRCS} ${SRC_TINYXML})
+    message (STATUS "tinyxml library not found")
 ENDIF(TINYXML_FOUND)
 
 
diff --git a/include/gpxdocument.h b/include/gpxdocument.h
index 949865d..a138aa9 100644
--- a/include/gpxdocument.h
+++ b/include/gpxdocument.h
@@ -29,7 +29,6 @@
 
 #include <wx/wx.h>
 #include <tinyxml.h>
-#include <tinystr.h>
 #include <stdio.h>
 
 const wxString GpxxColorNames[] = { _("Black"), _("DarkRed"), _("DarkGreen"), _("DarkYellow"), _("DarkBlue"), _("Da
diff --git a/include/navutil.h b/include/navutil.h
index 549ba14..07d05bc 100644
--- a/include/navutil.h
+++ b/include/navutil.h
@@ -44,7 +44,7 @@
 #include "bbox.h"
 #include "s52s57.h"
 #include "chcanv.h"
-#include "tinyxml.h"
+#include <tinyxml.h>
 #include "gpxdocument.h"
 
 extern bool LogMessageOnce(wxString &msg);
diff --git a/src/navutil.cpp b/src/navutil.cpp
index 982a034..72f6956 100644
--- a/src/navutil.cpp
+++ b/src/navutil.cpp
@@ -58,7 +58,7 @@
 #include "routeman.h"
 #include "s52utils.h"
 #include "chartbase.h"
-#include "tinyxml.h"
+#include <tinyxml.h>
 #include "gpxdocument.h"
 
 #ifdef USE_S57

The only required part is ADD_DEFINITIONS in CMakeLists.txt others are cosmetic.

Pavel, now all logbook plugins should work. Tested on all 4 platforms/arches

[bdbcat]

Sethdart....

OK, I pushed the small patch to CMakeLists.txt for 11.04/64.

In git speak, it happens after 2.5.0, but I think I will let it stand, and not bump the Release to 2.5.1.....Just a slight imperfection....

Dave

[Littlechay]

Looks good here on windows 7, didnt have time to put it onto Ubuntu here, no bandwidth for the download. Well done!

There is glitch with the GE plugin. The status bar at the bottom of the GE window is overwritten by the OCPN status bar. This was probably the case before but I have only just started playing with GE so I'll mention this in a GE thread

[sinbad7]

Dave..

I had constructed a lot of extra .xpm icons for the Mark Properties box but since the new OCPN version they are all gone. I have re-entered them in both 'icons' as well as 'User icons' sub-directories together with the standard icons but they do not show up?

What could be the problem?

Tore

[Rodz]

I tried to install ver 2.3.1 on SUSE 11.3 - 32bit the Fedora flavor using YAST. It calls for mesa-libGL. I have mesa-3D graphics library .....

Steffen you installed on SUSE ... any comments?? Thanks !!

[steffenp]

Rodz,

I not really tried this old version but you may find prebuild binaries somewhere in the buildservice.

Version 2.5.0 builds without problems on opensuse or you use my packages on OBS here: 1-Klick-Installation (Opensuse 11.3)
I can not test for 11.3, reports welcome

regards Steffen