GPSBabel Integration in the Import of Nav Objects

[nohal]

Howdy!
Thought there are not enough new features to play with these days so hacked together a basic ability to import data in other formats than GPX

If it's possible to run GPSBabel (it's in the PATH environment variable or in the same directory as the OpenCPN executable), the types of data it supports are added to the list of file types in the file selection dialog and a conversion to GPX is attempted as part of the file opening.
There is virtually no error handling and I've done only a very limited testing on my Win machine with gpsbabel 1.4.2, so have absolutely no idea whether it will work on Linux or with other gpsbabel releases in it's present state at all...
Meant more like a proof of concept to investigate doability and usability of such a feature. Doing the same for export would of course be easy...
Opinions? Suggestions?
Patch generated against plain 2.3.1 source, if you want to try it.

Pavel

[rooiedirk]

Hoi Nohal,
I did give it a try at linux for you.
When compiling I had a few warnings.
[ 51%] Building CXX object CMakeFiles/opencpn.dir/src/navutil.cpp.o
/home/dirk/opencpn/GitOpenCPN/opencpn/src/navutil.cpp: In member function 'void MyConfig::ImportGPX(wxWindow*)':
/home/dirk/opencpn/GitOpenCPN/opencpn/src/navutil.cpp:4087: warning: cannot pass objects of non-POD type 'class wxString' through '...'; call will abort at runtime
/home/dirk/opencpn/GitOpenCPN/opencpn/src/navutil.cpp:4087: warning: cannot pass objects of non-POD type 'class wxString' through '...'; call will abort at runtime
/home/dirk/opencpn/GitOpenCPN/opencpn/src/navutil.cpp:4087: warning: cannot pass objects of non-POD type 'class wxString' through '...'; call will abort at runtime
[ 51%] Building CXX object CMakeFiles/opencpn.dir/src/routeman.cpp.o

And when I tried to import, there was a list with all kind of Import options, but when i chose one ( I used txt import) crash.
grjes
Dirk

[nohal]

ahhh,
my favorite coding error is back I have to find out how to produce this warning with msvc as well...

Thanks

Pavel

[nohal]

Dirk,
replacing line 4087 with

cmd = wxString::Format( wxT("gpsbabel -i %s -f \"%s\" -o gpx -F %s"), inputformat.mb_str(), path.mb_str(), tmpfile.mb_str());

should do do trick


Pavel

[rooiedirk]

Pavel,
Sorry, it does't. same behaviour and crashing when importing.

/home/dirk/opencpn/GitOpenCPN/opencpn/src/navutil.cpp: In member function 'void MyConfig::ImportGPX(wxWindow*)':
/home/dirk/opencpn/GitOpenCPN/opencpn/src/navutil.cpp:4087: warning: cannot pass objects of non-POD type 'const class wxCharBuffer' through '...'; call will abort at runtime
/home/dirk/opencpn/GitOpenCPN/opencpn/src/navutil.cpp:4087: warning: cannot pass objects of non-POD type 'const class wxCharBuffer' through '...'; call will abort at runtime
/home/dirk/opencpn/GitOpenCPN/opencpn/src/navutil.cpp:4087: warning: cannot pass objects of non-POD type 'const class wxCharBuffer' through '...'; call will abort at runtime

Dirk

[nohal]

c_str(), not mb_str() should it be...
I should place a new tattoo on my forearm
Will release a better patch in a few days.

Pavel

[rooiedirk]

It is an improvement. no warnings anymore and no crashing. unfortunally no import either. (Choise list from gpsbabel is there)
Dirk

[nohal]

Dirk,
thanx for info...
Did you try to import something that should actually be imported? I mean something you know gpsbabel can convert to gpx with gpsbabel -i FRM -f FILE -o gpx -F /tmp/xxx.gpx?
As I said before, there is no error handling right now so you can't tell me much more without digging into the code yourself...
Not that this behavior was not expected but I'm curious. Will do more on it past the weekend when I will also chance to see a linux version myself.

Pavel

[rooiedirk]

Pavel,
I convertet a gpx file in a terminal to comma seperated. Then again import in OCPN, super.
Dirk