WeatherFax ...

[ChuckSK]

Here is a wav file image.

[LeaseOnLife]

Originally Posted by ChuckSK

Try these fixes.

diff --git a/src/libaudiofile/modules/PCM.cpp b/src/libaudiofile/modules/PCM.cpp
index 832f0e8..010dd70 100644
--- a/src/libaudiofile/modules/PCM.cpp
+++ b/src/libaudiofile/modules/PCM.cpp
@@ -39,10 +39,10 @@
 
 bool _af_pcm_format_ok (AudioFormat *f)
 {
-    assert(!isnan(f->pcm.slope));
-    assert(!isnan(f->pcm.intercept));
-    assert(!isnan(f->pcm.minClip));
-    assert(!isnan(f->pcm.maxClip));
+    assert(!_isnan(f->pcm.slope));
+    assert(!_isnan(f->pcm.intercept));
+    assert(!_isnan(f->pcm.minClip));
+    assert(!_isnan(f->pcm.maxClip));
 
     return true;
 }

Works much better now.
Chuck

Chuck: Thanks!

everything compiles, except the last patchlet above:

[ 82%] Building CXX object plugins/weatherfax_pi/CMakeFiles/weatherfax_pi.dir/src/libaudiofile/modules/PCM.cpp.o
/NON-GENTOO-COMPILES/OPENCPN/OpenCPN/plugins/weatherfax_pi/src/libaudiofile/modules/PCM.cpp: In function 'bool _af_pcm_format_ok(AudioFormat*)':
/NON-GENTOO-COMPILES/OPENCPN/OpenCPN/plugins/weatherfax_pi/src/libaudiofile/modules/PCM.cpp:42:2: error: '_isnan' was not declared in this scope
make[2]: *** [plugins/weatherfax_pi/CMakeFiles/weatherfax_pi.dir/src/libaudiofile/modules/PCM.cpp.o] Error 1
make[1]: *** [plugins/weatherfax_pi/CMakeFiles/weatherfax_pi.dir/all] Error 2
make: *** [all] Error 2

I reverted this last portion and have a compiled weatherfax.pi now, on to testing now.

Dirk

PS: I had to do the patching manually, please remind me of the proper use of "patch"...

[LeaseOnLife]

new version does handle this fax now. I am going to try, and post a few more... = weatherfax porn

[LeaseOnLife]

I have some troubles aligning the color Fiji fax, maybe this the fijifax isn't really mercator, the largest error is in the middle (latitude).

But, not too bad for displaying a weatherfax though:

[LeaseOnLife]

similar distortion in latitude for the fax from French Polynesia:


Also, the FP fax can be downloaded, as png.
http://www.meteo.pf/bulletins/marines/preiso36.png
The plug-in does not recognise png as an image file, I had to convert it (to jpg)

[ChuckSK]

Hi Dirk

I think that last patchlet is required for older compilers. Re applying patches, I do not know. I look things up when the need arises.

Nice clips.

Chuck

[LeaseOnLife]

Originally Posted by ChuckSK

Hi Dirk

I think that last patchlet is required for older compilers. Re applying patches, I do not know. I look things up when the need arises.

Nice clips.

Chuck

chuck, thanks for the help!!

Here is a fax from Mauritius: Similar distortion in latitude. Equator and 40S are right on, anything in between is not.

Origin of fax: http://metservice.intnet.mu/synopticimages/chart.jpg

Dirk

[LeaseOnLife]

these line up nicely across the equator:

source:
http://www.bom.gov.au/fwo/IDD80100.png
http://www.bom.gov.au/fwo/IDD67950.png

[rgleason]

"Try these fixes." Gosh Chuck, that's great. Can you tell me a little about how I applly or use these fixes and what is happening? I've never done this.

I assume
diff --git a/src/WeatherFaxDialog.cpp b/src/WeatherFaxDialog.cpp

is some command and then the changes are applied. How is this used properly?
I'm using Win7 and can use CMD and dos commands, also MS VC++2010 Express.

Thanks.

[LeaseOnLife]

Originally Posted by rgleason

"Try these fixes." Gosh Chuck, that's great. Can you tell me a little about how I applly or use these fixes and what is happening? I've never done this.

I assume
diff --git a/src/WeatherFaxDialog.cpp b/src/WeatherFaxDialog.cpp

is some command and then the changes are applied. How is this used properly?
I'm using Win7 and can use CMD and dos commands, also MS VC++2010 Express.

Thanks.

Per Chuck's diff, I manually edited/modified two files:WeatherFaxDialog.cpp WeatherFaxDialog.h

attached are both files (remove .doc extension, then un-7-zip)

[ChuckSK]

Originally Posted by rgleason

"Try these fixes." Gosh Chuck, that's great. Can you tell me a little about how I applly or use these fixes and what is happening? I've never done this.

I assume
diff --git a/src/WeatherFaxDialog.cpp b/src/WeatherFaxDialog.cpp

is some command and then the changes are applied. How is this used properly?
I'm using Win7 and can use CMD and dos commands, also MS VC++2010 Express.

Thanks.

The diff file just shows the differences between the original files and the updated files. It is not a command file.

It specifies the files and the line numbers that have been changed. Replace the lines preceded by minus signs with lines preceded by plus signs.

Chuck

[mrm]

$ man patch

PATCH(1)                                                              PATCH(1)

NAME
       patch - apply a diff file to an original

SYNOPSIS
       patch [options] [originalfile [patchfile]]

       but usually just

       patch -pnum <patchfile

DESCRIPTION
[...]
       --dry-run
          Print the results of applying the patches without actually  changing
          any files.
[...]
       -pnum  or  --strip=num
          Strip  the  smallest prefix containing num leading slashes from each
          file name found in the patch file.  A sequence of one or more  adja‐
          cent  slashes  is counted as a single slash.  This controls how file
          names found in the patch file are treated, in  case  you  keep  your
          files  in  a  different  directory  than the person who sent out the
          patch.  For example, supposing the file name in the patch file was

             /u/howard/src/blurfl/blurfl.c

          setting -p0 gives the entire file name unmodified, -p1 gives

             u/howard/src/blurfl/blurfl.c

          without the leading slash, -p4 gives

             blurfl/blurfl.c

          and not specifying -p at all just gives you blurfl.c.  Whatever  you
          end  up  with  is looked for either in the current directory, or the
          directory specified by the -d option.
[...]

[rgleason]

Yikes! amazing help. Thank you all. I had just gotten to the point that I realized that "Diff" is a Linux/Unix command, which is different than "git-diff" and with all your help I think I can make these changes. Who knows, in time I may become able to make program changes. Right now you all seem like majicians, truely!!

Stay tuned, I'll let you know how it goes. Thanks again.

[rgleason]

Thank, decided to use Leaseonlife files as that was easiest. Downloaded and put in
plugins directory C:\Data-Dart\...\Navigation\opencpn-git\plugins\weatherfax_pi\src

Then ran cmake .. and cmake --build .

Got attached png with 4 errors (back to same # of errors as before)
Then ran MSVC++ Debug > Build got this output with NO failiures.

Will find the new weatherfax_pi.dll and put in plugin directory and let you know how it goes a bit later.

Thank You all!

[LeaseOnLife]

Originally Posted by rgleason

Thank, decided to use Leaseonlife files as that was easiest. Downloaded and put in
plugins directory C:\Data-Dart\...\Navigation\opencpn-git\plugins\weatherfax_pi\src

Then ran cmake .. and cmake --build .

Got attached png with 4 errors (back to same # of errors as before)
Then ran MSVC++ Debug > Build got this output with NO failiures.

Will find the new weatherfax_pi.dll and put in plugin directory and let you know how it goes a bit later.

Thank You all!

Chuck made changes in 3 files, I only sent you 2 modified files, here is the 3rd: replace your weatherfax_pi/src/libaudiofile/modules/PCM.cpp with the one attached.

Let us know how this compiles

Dirk

PS: hopefully Sean / boat_alexandra can clean up our mess and we get a fresh git soon