WeatherFax ...

[LeaseOnLife]

Neat!

• Test with a fiji weatherfax 930x652px, across the dateline, works, opengl on and off! (transparancy only works with opengl=on)
• Test with a weatherfax "Atlantic Tropical Surface 0-120W, 40N-0N", 986x716px, only shows a white area (inverted or not) with opengl on. With opengl=off it doesn't show anything.

Both images are attached, also see screenshots from opencpn.

Tested on Gentoo Linux

Dirk

[rgleason]

I'm envious. I wish I could get it working if only a little! This is going to be a great tool!

[LeaseOnLife]

Is there a full length weather-fax-wav file available on the web? I would like to test the wav-decoding, but can't find such a file.

Dirk

[rgleason]

This looks like the best webpage with samples
JVComm32 - sound samples
Let us know what you think, which ones, please. Have not tried.

Different types of sound samples:
Sound samples examples digi modes

Programs with samples?:
JVComm32 - FAX SSTV RTTY SYNOP NAVTEX program
Best navtex wav file sample downloads.

More programs
Navtex wav sample trend: Wav Sample Rate Converter, PC Navtex, NAVTEX Decoder

[LeaseOnLife]

Originally Posted by rgleason

This looks like the best webpage with samples
JVComm32 - sound samples
Let us know what you think, which ones, please. Have not tried.

Different types of sound samples:
Sound samples examples digi modes

Programs with samples?:
JVComm32 - FAX SSTV RTTY SYNOP NAVTEX program
Best navtex wav file sample downloads.

More programs
Navtex wav sample trend: Wav Sample Rate Converter, PC Navtex, NAVTEX Decoder

Thanks! I didn't try all the links, the ones I tried are too short, too small files. But with the help of above links I found this webpage: WeatherFax and Shortwave Radio which has two full length fax audio files:

• Sample WeatherFax transmission - WAV format. 48 Hour Wind and Wave Forecast, valid 2013 Feb 01 1200Z. Received from NOAA Pt Reyes, 17151 kHz on 2013 Jan 30
• Sample WeatherFax transmission - WAV format. 48 Hour Surface Forecast, valid 2013 Feb 01 1200Z. Received from NOAA Pt Reyes, 17151 kHz on 2013 Jan 30

These wav files are 10-12MB, but not of great quality. yahfax does decode them, see screenshots. The weatherfax plugin crashes opencpn when trying to import either one as a wav file.

boat_alexandra / Sean: let me know if the above files work for you. If they do, I need to start some debugging here...

Dirk

PS: these files do raise another issue: skewed weatherfaxes are rather common, the plugin needs a tool to de-scew them

[sailorF54]

Here is a complete one (start tone ...) .wav format 14.7 Mo

Appears quite slanted using JVCOMM32

Free - Envoyez vos documents

[LeaseOnLife]

Originally Posted by sailorF54

Here is a complete one (start tone ...) .wav format 14.7 Mo

Appears quite slanted using JVCOMM32

Free - Envoyez vos documents

I downloaded the wav file, and tried to open it with opencpn/weatherfax plugin. the decoder starts, finishes, then opencpn crashes.


I converted the wav file with yahfax, it shows the same scew as with jvcomm32. With airmail2000/viewfax, I was able to straighten the image. It's not Mercator though....

[rgleason]

Thanks, the first link PDF Presentation is good explanation for beginners on Weatherfax equipment w/o SSB.
WeatherFax and Shortwave Radio
Presentation in PDF format

This shows how to make an interconnecting cable between radio and computer.
Weatherfax - Make Your Own | YachtPals.com

[rgleason]

appbase.cpp
directly after define lat long. for weatherfax get WxWidget popup and code "Break" "Continue"

Hit Break

// break into the debugger
void wxTrap()
{
#if defined(__WXMSW__) && !defined(__WXMICROWIN__)
    DebugBreak();
#elif defined(__WXMAC__) && !defined(__DARWIN__)
    #if __powerc
        Debugger();
    #else
        SysBreak();
    #endif
#elif defined(_MSL_USING_MW_C_HEADERS) && _MSL_USING_MW_C_HEADERS
    Debugger();
#elif defined(__UNIX__)
    raise(SIGTRAP);
#else
    // TODO
#endif // Win/Unix
}                                   <------ARROW IS HERE Next step

// this function is called when an assert fails

[rgleason]

Downloaded and Tried all the wav files on this page
JVComm32 - sound samples
Did not seem to work. Select New, pick Wav files, select file,
goes back to the Weatherfax Window and there is no file listed in the window.
Nothing crashed, just kept trying to select various wav files successively.
This was all done using compiled Debug mode.

Then tried weatherfaxes again and got the same break and wx Warning.
I am starting to realize a few things. The Modules tab says "Cannot find PDB file"
I understand this is not a problem that would stop running the program, however there are a few confusing things happening:
I neglected to say that this computer has Win7 x 64
perhaps I should be running MS VC++ 2010 Express with "Debug" and "Win64 bit

It hasn't seemed to make a difference before, but perhaps something got changed?

[rgleason]

I've checked it, and I believe I've been compiling as Win32 bit and running in ProgramFiles(x86) directory all along. --So this should not be the problem. I am going to wait for revised update code.

[seandepagnier]

Hi, thanks for all the testing. It looks like there is some problem with the scrolled window. This is probably a bug in wxwidgets, because it should either work on all platforms or break on all platforms (if the bug is in my code)

Anyway, I don't regularly have internet where I'm anchored and I have to bike to the library here in whangarei to post updates so sometimes my replies may take days. I have been working on the next revision of the plugin to hopefully improve the user interface as well as added some more options. There is a bunch more logic, and a possible tendency to break on other platforms, so it will need some testing.

I tried with the wav file posted, and it decode but crashes.. I fixed it so the new version should work now.

There are still some improvements for the next revision not yet implemented, one to add to the list will be slant correction.

Please pull the git test and report back:
github.com/seandepagnier/weatherfax_pi

[LeaseOnLife]

Originally Posted by boat_alexandra

Hi, thanks for all the testing. It looks like there is some problem with the scrolled window. This is probably a bug in wxwidgets, because it should either work on all platforms or break on all platforms (if the bug is in my code)

Anyway, I don't regularly have internet where I'm anchored and I have to bike to the library here in whangarei to post updates so sometimes my replies may take days.

no problem, enjoy!

I have been working on the next revision of the plugin to hopefully improve the user interface as well as added some more options. There is a bunch more logic, and a possible tendency to break on other platforms, so it will need some testing.

I tried with the wav file posted, and it decode but crashes.. I fixed it so the new version should work now.

There are still some improvements for the next revision not yet implemented, one to add to the list will be slant correction.

Please pull the git test and report back:
github.com/seandepagnier/weatherfax_pi

I just pulled the latest from git, but can't compile (Gentoo Linux), even after a clean clone of opencpn + weatherfax

Dirk

[ 82%] Built target grib_pi                                                                                                                    
[ 82%] weatherfax-i18n: Done.                                                                                                                  
[ 82%] Built target weatherfax-i18n                                                                                                            
[ 82%] Building CXX object plugins/weatherfax_pi/CMakeFiles/weatherfax_pi.dir/src/WeatherFaxDialog.cpp.o                                       
/NON-GENTOO-COMPILES/OPENCPN/OpenCPN/plugins/weatherfax_pi/src/WeatherFaxDialog.cpp: In destructor 'virtual EditFaxDialog::~EditFaxDialog()':  
/NON-GENTOO-COMPILES/OPENCPN/OpenCPN/plugins/weatherfax_pi/src/WeatherFaxDialog.cpp:300:21: error: request for member 'lat1' in '((EditFaxDialog*)this)->EditFaxDialog::m_newCoords', which is of non-class type 'WeatherFaxImageCoordinates*'                                                
/NON-GENTOO-COMPILES/OPENCPN/OpenCPN/plugins/weatherfax_pi/src/WeatherFaxDialog.cpp:300:41: error: request for member 'lat2' in '((EditFaxDialog*)this)->EditFaxDialog::m_newCoords', which is of non-class type 'WeatherFaxImageCoordinates*'
/NON-GENTOO-COMPILES/OPENCPN/OpenCPN/plugins/weatherfax_pi/src/WeatherFaxDialog.cpp:301:21: error: request for member 'lon1' in '((EditFaxDialog*)this)->EditFaxDialog::m_newCoords', which is of non-class type 'WeatherFaxImageCoordinates*'
/NON-GENTOO-COMPILES/OPENCPN/OpenCPN/plugins/weatherfax_pi/src/WeatherFaxDialog.cpp:301:41: error: request for member 'lon2' in '((EditFaxDialog*)this)->EditFaxDialog::m_newCoords', which is of non-class type 'WeatherFaxImageCoordinates*'
make[2]: *** [plugins/weatherfax_pi/CMakeFiles/weatherfax_pi.dir/src/WeatherFaxDialog.cpp.o] Error 1
make[1]: *** [plugins/weatherfax_pi/CMakeFiles/weatherfax_pi.dir/all] Error 2
make: *** [all] Error 2

[rgleason]

Sean I also got about 26 Errors when I git clone and cmake the plugin.
I attach a pic of the bottom of the cmd screen. Sending you the output file from running MS VC++ 2010 Express trying to build a release, errors may help. It did not build a new plugin dll under release or debug. (via your email.)

[ChuckSK]

Try these fixes.

diff --git a/src/WeatherFaxDialog.cpp b/src/WeatherFaxDialog.cpp
index a922211..dbc68ab 100644
--- a/src/WeatherFaxDialog.cpp
+++ b/src/WeatherFaxDialog.cpp
@@ -241,7 +241,7 @@ EditFaxDialog::EditFaxDialog( WeatherFaxImage &img, wxString name,
     : EditFaxDialogBase( &parent ), m_parent(parent),
       m_img(img), m_curCoords(img.m_Coords),
       m_name(name), m_splits(0),
-      m_EditState(COORD), m_Coords(coords)
+      m_EditState(COORD1), m_Coords(coords)
 {
     m_swFaxArea->SetScrollbars(1, 1, m_img.GetWidth(), m_img.GetHeight()-1);
 
@@ -297,8 +297,8 @@ EditFaxDialog::~EditFaxDialog()
         sel = m_SelectedIndex;
 
     if(sel == 0 &&
-       (m_newCoords.lat1 || m_newCoords.lat2 ||
-        m_newCoords.lon1 || m_newCoords.lon2)) {
+       (m_newCoords->lat1 || m_newCoords->lat2 ||
+        m_newCoords->lon1 || m_newCoords->lon2)) {
         int cc = m_Coords.GetCount();
         wxString newname = m_newCoords->name, newnumberedname;
         for(int n=0, i=-1; i != cc; n++) {
@@ -321,7 +321,7 @@ EditFaxDialog::~EditFaxDialog()
 void EditFaxDialog::OnBitmapClick( wxMouseEvent& event )
 {
     switch(m_EditState) {
-        case COORD:
+        case COORD1:
         {
             wxPoint p = m_swFaxArea->CalcUnscrolledPosition(event.GetPosition());
 
@@ -374,7 +374,7 @@ void EditFaxDialog::OnBitmapClick( wxMouseEvent& event )
             wxRect r2(0, 0, m_img.GetWidth(), split.y);
             m_img = m_img.GetSubImage(r2);
             Refresh();
-            m_EditState = COORD;
+            m_EditState = COORD1;
         } break;
     }
 }
@@ -418,7 +418,7 @@ void EditFaxDialog::OnSplitImage( wxCommandEvent& event )
     if(w.ShowModal() == wxID_OK)
         m_EditState = SPLITIMAGE;
     else
-        m_EditState = COORD;
+        m_EditState = COORD1;
 }
 
 void EditFaxDialog::OnPhasing( wxScrollEvent& event )
diff --git a/src/WeatherFaxDialog.h b/src/WeatherFaxDialog.h
index 6d7d29a..81a1afb 100644
--- a/src/WeatherFaxDialog.h
+++ b/src/WeatherFaxDialog.h
@@ -72,7 +72,7 @@ protected:
     weatherfax_pi &m_weatherfax_pi;
 };
 
-enum EditState {COORD, SPLITIMAGE};
+enum EditState {COORD1, SPLITIMAGE};
 class EditFaxDialog : public EditFaxDialogBase
 {
 public:
diff --git a/src/libaudiofile/modules/PCM.cpp b/src/libaudiofile/modules/PCM.cpp
index 832f0e8..010dd70 100644
--- a/src/libaudiofile/modules/PCM.cpp
+++ b/src/libaudiofile/modules/PCM.cpp
@@ -39,10 +39,10 @@
 
 bool _af_pcm_format_ok (AudioFormat *f)
 {
-	assert(!isnan(f->pcm.slope));
-	assert(!isnan(f->pcm.intercept));
-	assert(!isnan(f->pcm.minClip));
-	assert(!isnan(f->pcm.maxClip));
+	assert(!_isnan(f->pcm.slope));
+	assert(!_isnan(f->pcm.intercept));
+	assert(!_isnan(f->pcm.minClip));
+	assert(!_isnan(f->pcm.maxClip));
 
 	return true;
 }

Works much better now.
Chuck