WeatherFax ...

[LJH]

Originally Posted by rgleason

Sean I think you nailed it!
Much much better. I like the lat/long again. Thank.

(Why do I have to delete the old dlls in build/plugins/debug to get a new one with today's current date to appear? Is it just over-writting into the existing file and not changing the file date? Never noticed that before.)

There were no breaks. I was able to do polar files I had breaks and trouble with. I was able to do polar files that I had not done before and I am reasonably confident that this is really working better. In debug mode it was smoother and more responsive and the zoom in zoom out problems seem better too!

I am pretty sure the attached release DLL will be 98% good.
By the way, I found that the transparency thing on the first screen goes away when you just grab the window and shake it a little, then everything is fine! So shake the window when you first load a file.

Test this file out by taking the doc of the end and placing in your plugins directory, after deleting your old weatherfax_pi.dll

yes well done Sean

Thanks also for Lat/Long.

With OpenGL on:
3 Mercator and 3 Polar faxes at the same time - no issues at all.
Opened Grib and AIS plugins as well - no conflicts.
Opened few layers that had over 1000 items all together - no issues.
Repeated with GL off - same results.
Panning and scaling worked well throughout.
I also had to shake the first screen if I wanted to see the image correction panel.

Thanks again for all the work from everyone involved. It is working well for my machine (W7 64 Bit NIVIDI GTX560M)

[Taarnskov]

I would also say that it works fine, but how do i delete all the presets that i don't need. The presets are very good.

Lars

[LJH]

Originally Posted by Taarnskov

I would also say that it works fine, but how do i delete all the presets that i don't need. The presets are very good.

Lars

They are stored in opencpn.ini
There was a post from rgleason earlier in the thread about it.

[ChuckSK]

This patch will remove the requirement to "shake" the first screen to see the Image Correction fields.

diff --git a/src/WeatherFaxWizard.cpp b/src/WeatherFaxWizard.cpp
index f5ce56b..d63466c 100644
--- a/src/WeatherFaxWizard.cpp
+++ b/src/WeatherFaxWizard.cpp
@@ -194,8 +194,8 @@ void WeatherFaxWizard::OnStopDecoding( wxCommandEvent& event )
 
 void WeatherFaxWizard::OnPaintPhasing( wxPaintEvent& event )
 {
-    if(!m_decoder)
-        return;
+//    if(!m_decoder)
+//        return;
 
     wxWindow *window = dynamic_cast<wxWindow*>(event.GetEventObject());
     if(!window)
@@ -203,6 +203,9 @@ void WeatherFaxWizard::OnPaintPhasing( wxPaintEvent& event )
 
     wxPaintDC dc( window );
 
+    if(!m_decoder)
+        return;
+
     dc.SetBrush(wxBrush(*wxBLACK));
     dc.SetPen(wxPen( *wxBLACK, 1 ));

[rgleason]

ChuckSK Thankyou. I know I've asked a similar question previously, but it would be helpful to understand which line(s) of src/weatherfaxwizard.cpp

@@-194,8 +194,8 @@ void WeaterFaxWizard::OnStopDecoding( wxCommandEvent&
event

...Code A

@@ -203,6 +203,9 @@ void WeatherFaxWizard::OnPaintPhasing( wxPaintEvent& event )

....Code

Is it line -194,8 +194,8 (or something like that?) then gets replaced by code A

And line 203,6 +203,9 (or something line that? then gets replaced by Code B?

[ChuckSK]

Here is the WinMerge screen showing the difference.

[rgleason]

Thanks ChuckSK I tried modifying the file as shown above with notepad++. When I tried to compile it MSVC complained and said I had files modified externally, do I want to reload or something, so I said yes, (otherwise I have to merge it manually?), a lot of files were scanned and then I tried compiling again and eventually brought up Weatherfax_pi.. It loaded fine and was not as transparent, but still had to be shaken to get the bars to show..... I see you moved some decoder process down until after the window was opened. Maybe it needs just a little more fine tuning?

Thanks for your efforts! I wonder if Sean makes this change and I git fetch --all now with my change what will happen? It will be interesting to see.

[ChuckSK]

You do know that you can edit files directly in MSVC? In any case, shaking is not required here.

[rgleason]

No, I did not know that! I am glad shaking is not required there. Maybe I did something wrong and it did not "take". I'll do it from withing MSVC and check again. Thanks.

[rgleason]

ChuckSK - Checked from within MSVC and the changes were there, so then I realized that I had not copied the compiled Debug DLL to the Build/Plugins directory! Silly mistake. So now it works great! No transparency issue. Thanks very much.

[seandepagnier]

chuck,

Thanks very much for the patch I'll put it in. I have no idea why that fixed it though (based on looking at the code) Do you know why? or was it just experimentation? Maybe you have to make a dc or else call event.skip()...

[rgleason]

Sean, when I git fetch --all the next update will it overwrite what I've done locally? Just trying to figure out how git does this.

[nohal]

Rick...

No, it will not until you apply some more evil. It was written by people who don't like loosing their work

Pavel

[ChuckSK]

Originally Posted by boat_alexandra

chuck,

Thanks very much for the patch I'll put it in. I have no idea why that fixed it though (based on looking at the code) Do you know why? or was it just experimentation? Maybe you have to make a dc or else call event.skip()...

With wxFormBuilder I moved the various elements on the screen to different positions. The problems always appeared in the fields displayed after the Phasing window. So ensuring a wxPaintDC was created for the window was a first guess.

[seandepagnier]

Ah, good so process of elimination. I learned something about wxwidgets. Too bad it doesn't always have the same behavior between platforms, but then again, I get this with qt too.

This plugin is looking like it's hopefully pretty stable. Lots of possible extensions though...