track to route crashing?

[nkiesel]

Hi,

O (complied from github master) crashes for me when trying to convert tracks into routes. Concrete steps where to create a weather routing, export that (which creates a track), then clicking on the "Route from Track" button of the "Tracks" tab of "Route and Mark Manager".

I just created a pull request [1] with a potential fix, but now I'm wondering if perhaps I do something wrong because this should be a fairly often used functionality and I can't find anyone else reporting this bug.

[1]: https://github.com/OpenCPN/OpenCPN/pull/690

[bdbcat]

nkiesel...

Thanks for the patch.

I think your code is probably OK. Sean has done major work done to refactor Tracks away from Routes, to support faster rendering of large/complex tracks. Not surprising that edge cases get missed.

Consider github commit:
639f9673057e92d4cc96b431e925e23af8dfbb7b
which brings in a whole new track list(vector) implementation.

Also, note that you can invoke
RouteManagerDialog::OnTrkMenuSelected()

by right-clicking on a track-point item(row) in the RouteManagerDialog.

If Sean has no comments, I'll merge your Pull Request.

Thanks again
Dave