SAR Plugin

[rgleason]

Mike, you are partly right about what you told Steve about the Plugin Manager process.
I forked your repos and made some changes. It now builds all the environments I believe, and it deploys to opencpn/sar-beta (also sar-alpha and sar-prod)

I incremented the version to 2.6.1 and push it to the "prod" repository.
https://cloudsmith.io/~opencpn/repos/sar-prod/packages/


Then from my local plugins git repos I pulled from upstream master, and then copied all the metadata files into the metadata directory, comitted and pushed up to my remote plugins using (--force). Then made a new PR to opencpn/plugins to be accepted by bdbcat.


Once accepted SAR will be in the master catalog. (12 environments, there is a 13th that seems to be missing) You can do this too. I am making a PR back to your github repos.


Dave just accepted the plugins PR, so now the sar_pi xml's are all the master catalog and available.
Note there is a problem with deb ubuntu, that needs to be fixed in each plugins code changing x86_64 to amd64 for debian.
Thomas found it look for his notes. That will be fixed shortly I think, but all plugins are affected with this change.

[Rasbats]

Rick... read your emails.

Mike

[Rasbats]

Nothing to do with me!

Windows 8.0, OpenCPN 5.1.620.

SAR_pi from the master catalog installs. No icon shown in the list. Install, enable ... nada. Close OpenCPN and restart ... the plugin is missing from the master list of plugins installed ... no SAR plugin is shown. 'SAR' is in the list of plugins available for install but it cannot be used.

Mike

[bcn]

For macOS the same.

[rgleason]

I tried renaming the repositories to SAR-alpha SAR-beta SAR-prod however that does not rename the slug which cannot be renamed in this way, I tried. I read the Cloudsmith documentation and did not get a definitive answer. Then wrote CS with this response:

Question:

I have a plugins programmer who wants his Opencpn repository named SAR-beta rather than sar-beta (for example).

1. Does it make any difference to Cloudsmith?

2. I tried changing the name to SAR-alpha which has no files in it right now. That seemed to change. Then I tried changing the slug from sar-alpha to SAR-alpha but it only allow "Go Back" so it will not execute, Is that because it is essentially the same name? I suppose I could change it twice, adding a character, then removing it.


To answer your questions:

1. The application will handle repositories with capitalisation in the name just fine
2. Repository slugs can only contain lowercase alphanumeric characters, hyphens, and underscores. Because of this I don't believe that you'll be able to use SAR-alpha for the repository slug

Mike there are several things you can try:


1. Making a new push and deployment to Cloudsmith Opencpn SAR-beta or SAR-prod to see if those metadata work better with the renaming to "SAR-xxxx" I have done (but the slug is not renamed). If they work using import plugin, you could save the metadata and push it to Dave on opencpn/plugins

2. First make certain you are using the commonname of the plugin. 99% of the time that is the problem when there are multiple SAR "puzzles" all over the place, and duplicate sar_pi in the plugin list. (I am getting these too in Windows.)

3. Try creating a new repository in CS Opencpn "SAR-beta" or even delete the sar-alpha repository because it is empty, and try recreating it as SAR-alpha. you are a manager with these rights.

5. Change the repository back to your personal repository if you think that is better ( but you'll be changing it back later when CS changes policies about Open source Organizations.) You'll still need to update the master catalog.

[rgleason]

I just tried cleaning out the "cache/tarballs" file of all SAR plugins, then all plugin tarballs. Sometimes old versions that are misnamed cause trouble.

C:\ProgramData\opencpn\plugins\cache\tarballs
Then updated the master catalog.
I get multiple green SAR puzzles still.


Then I removed SAR 2.5 from the plugins directory along with the directory SAR
C:\Program Files (x86)\OpenCPN 5.1.612+4f9c9c4\plugins
Restarted Opencpn and there is still a green puzzle SAR and I don't know which version it is. or where it is located yet.


We need to have the full version number listed in the Preferences title!!!!


In Win Using the path %localappdata%\opencpn\plugins
C:\Users\Rick\AppData\Local\opencpn\plugins

I found SAR_pi and removed it


Restarted Opencpn and there are no green puzzles now.
And there are no stray and unknown SAR_pi installed right now.


Update PI master catalog.
Then install SAR 2.6.1 and it now shows a green puzzle in the plugin list.
It is enabled in the Plugin List and there is no icon in the Toolbar.
So we know there is an issue with Sar 2.6.1 that needs resolution,
however the problem was being compounded by multiple old versions that were installed.


I have to go now, but can work on this more tonight. Sorry.

[rgleason]

So, I think one solution would be as Mike has asked many times, to delete and redo the sar repositories, to actually and be visiable as SAR which I will do tonight. It is a bit of a pain, to delete full repositories and recreate them, but that is the only way. Then we'll see if they work by pushing a new commit.

[bdbcat]

Mike/Rick...


Looks to me as though Cloudsmith does not handle uppercase characters in repo names well, since there is an implicit link between the repo name, and the constructed URIs accessed by both uploaders and downloaders. This can lead to confusion....



So, I propose the following:


1. I will delete all SAR-xxx/sar-xxx repos from Cloudsmith.
2. I will recreate as "sar-xxx".
3. I will remove sar_pi from master catalog.


Mike:
4. Modify your code to use lower-case sar-xxx. Use the newly constructed Cloudsmith repos to publish.


Rick:
5. Do nothing. sar_pi is Mike's plugin, and he will publish when ready.


Comments, before I start pushing buttons?


Dave

[bdbcat]

Mike..
re:
4. (above)
Of course, you are free to use any combination of upper/lower case chars for your plugin "common name" that you like. Just that Cloudsmith works best with lower case repo names and slugs.


Dave

[Rasbats]

Dave...

Thanks. No comments.

I will delete mike-rossiter 'SAR-beta' and make a new repo mike-rossiter 'sar-beta' and work with that. After testing I will push to the empty opencpn 'sar-beta' and test again.

There are translations to add to the plugin and the manual needs an overhaul.

Mike

[rgleason]

Thanks to both of you. Nothing to do on this!

[rgleason]

Rick: 5 Do nothing. sar_pi is Mike's plugin, and he will publish when ready.

Ok, however Mike's is one fork of Salty Paws' SAR_pi. Additionally sar_pi has had many contributors.

[Rasbats]

Let's do a reset.

The SAR plugin (beta) tarballs for importing with the latest OpenCPN RC1 are here:

https://cloudsmith.io/~mike-rossiter...beta/packages/

Too many choices. These are the packages for Ubuntu 18.04 and Windows:

sar_pi-2.6.1.0-ubuntu-x86_64-18.04-bionic-tarball
sar_pi-2.6.1.0-msvc-x86_64-10.0.14393-MSVC-tarball

The 'exe' installer for OpenCPN 5.x is also listed:

opencpn-package-sar-2.6.1.0-msvc-x86_64-10.0.14393-MSVC.exe

TODO: Translations are not coming through yet.

Would appreciate help with testing on as many OS as possible. MacOSX is not yet available. Waiting for CircleCI approval.

Mike

[Rasbats]

Built some 'traditional' installers:

https://github.com/Rasbats/sar_pi/releases/tag/v2.6.9.1

Windows and MacOSX. Should work with both OpenCPN 5.0 and 5.X.

I am using the 'master' branch of GitHub for managed plugins. For compiling traditional versions please use the zip file included in the release above.

Mike

[Rasbats]

The new plugin system is working! With OpenCPN 5.1.620 RC1 I cleared out old sar_pi stuff to avoid installing from the cache etc.

Updated the Plugin Catalog and found SAR in the list. Installed the plugin and it works.

Tested on Windows and Ubuntu 18.04 so far.

Thanks to all involved in getting the new managed plugin system up and running.

Mike