Cruisers Forum
 


Join CruisersForum Today

Reply
 
Thread Tools Search this Thread Rate Thread Display Modes
Old 23-05-2020, 07:48   #46
Registered User

Join Date: Dec 2005
Location: Helsingborg
Boat: Dufour 35
Posts: 3,763
Re: OpenCPN Version 5.1.518 Beta Test

Dave

Cleared cache.
Using Noaa raster charts.
Starting in Miami going North, panning and zooming along the way.
After about 3 min, in Lake Worth Area, I had a crash. See Below.
Cache size at this point -> 23.1 Mb

Click image for larger version

Name:	Screenshot_20200523_164111.png
Views:	31
Size:	114.7 KB
ID:	215620

Anything else I can do for you?

Thanks

Thomas
__________________

cagney is offline   Reply With Quote
Old 23-05-2020, 10:02   #47
Registered User

Join Date: Aug 2016
Posts: 110
Re: OpenCPN Version 5.1.518 Beta Test

raster cache should be disabled. I have been struggling with it for a long time on Raspi and since then I have been disabled first. It's a pity that with every update the OpenCPN is switched on again.
__________________

BlackSea is offline   Reply With Quote
Old 24-05-2020, 07:06   #48
Registered User
 
transmitterdan's Avatar

Join Date: Oct 2011
Boat: Valiant 42
Posts: 6,283
Re: OpenCPN Version 5.1.518 Beta Test

Quote:
Originally Posted by bdbcat View Post
TDan...
I'm looking at this.
Definitely repeatable. Total hang, requiring power-down to recover. Something eats all memory and CPU cycles....

Looking at:
void ChartDldrPanelImpl::SetSource( int id )


More as I discover.
Dave
Dave,

Try as I might I cannot reproduce from latest git master. I am using wxWidgets release 3.1.0 all built locally. If you can reproduce let me know.

Dan
transmitterdan is online now   Reply With Quote
Old 24-05-2020, 07:36   #49
Marine Service Provider
 
bdbcat's Avatar

Join Date: Mar 2008
Posts: 6,118
Re: OpenCPN Version 5.1.518 Beta Test

Dan...
Spent all last night working this. It is a problem deep inside of Windows, or at least in wxWidgets.
Setup:
1. Add a chart catalog that is very large, like NOAA, RNC, ALL. 1007 charts, currently.
You will need to add this catalog using older O5.0, because O5.1 will crash during the add. After adding with O5, start O5.1. In chart downloader, simply select that large catalog.


As the chart list (scrolled window) is populated in:
void ChartDldrPanelImpl::FillFromFile()


The line:
m_scrollWinChartList->FitInside();



never returns. Requires reboot to recover.


I am fiddling with it again today.
Dave
bdbcat is offline   Reply With Quote
Old 24-05-2020, 07:49   #50
Registered User
 
transmitterdan's Avatar

Join Date: Oct 2011
Boat: Valiant 42
Posts: 6,283
Re: OpenCPN Version 5.1.518 Beta Test

Quote:
Originally Posted by bdbcat View Post
Dan...
Spent all last night working this. It is a problem deep inside of Windows, or at least in wxWidgets.
Setup:
1. Add a chart catalog that is very large, like NOAA, RNC, ALL. 1007 charts, currently.
You will need to add this catalog using older O5.0, because O5.1 will crash during the add. After adding with O5, start O5.1. In chart downloader, simply select that large catalog.


As the chart list (scrolled window) is populated in:
void ChartDldrPanelImpl::FillFromFile()


The line:
m_scrollWinChartList->FitInside();



never returns. Requires reboot to recover.


I am fiddling with it again today.
Dave
That checked list control is something that has been around a long time. I suspect it is too well aged compared to present day wxWidgets.
transmitterdan is online now   Reply With Quote
Old 24-05-2020, 08:02   #51
Marine Service Provider
 
bdbcat's Avatar

Join Date: Mar 2008
Posts: 6,118
Re: OpenCPN Version 5.1.518 Beta Test

Dan...




We are using:
#define NEW_LIST.


So the chart list is a wxScrolled Window, instead of the older checked list control.


Code:
#ifdef NEW_LIST
    m_scrollWinChartList = new wxScrolledWindow( chartsPanel, wxID_ANY, wxDefaultPosition, wxDefaultSize, wxVSCROLL);
    chartsPanelBoxSizer->Add( m_scrollWinChartList, 0, wxEXPAND );
    m_scrollWinChartList->SetScrollRate(5, 5);
    m_scrollWinChartList->SetMinSize( wxSize( -1,12 * GetCharHeight() ) );
    
    m_boxSizerCharts = new wxBoxSizer(wxVERTICAL);
    m_scrollWinChartList->SetSizer(m_boxSizerCharts);
    
#else
    m_clCharts = new wxCheckedListCtrl(chartsPanel, wxID_ANY, wxDefaultPosition, wxDefaultSize, wxLC_REPORT|wxLC_SINGLE_SEL);
    m_clCharts->SetMinSize( wxSize( 100,10 * GetCharHeight() ) );
    chartsPanelBoxSizer->Add( m_clCharts, 0, wxEXPAND );

#endif
And it seems that Windows has trouble with a scrolled window of very large virtual size.


If I revert to the "checked list control", it works OK, although there are some layout problems.


Dave
bdbcat is offline   Reply With Quote
Old 24-05-2020, 08:35   #52
Registered User
 
transmitterdan's Avatar

Join Date: Oct 2011
Boat: Valiant 42
Posts: 6,283
Re: OpenCPN Version 5.1.518 Beta Test

Quote:
Originally Posted by bdbcat View Post
Dan...
Spent all last night working this. It is a problem deep inside of Windows, or at least in wxWidgets.
Setup:
1. Add a chart catalog that is very large, like NOAA, RNC, ALL. 1007 charts, currently.
You will need to add this catalog using older O5.0, because O5.1 will crash during the add. After adding with O5, start O5.1. In chart downloader, simply select that large catalog.


As the chart list (scrolled window) is populated in:
void ChartDldrPanelImpl::FillFromFile()


The line:
m_scrollWinChartList->FitInside();



never returns. Requires reboot to recover.


I am fiddling with it again today.
Dave
Dave,

I tried this with Debug and Release builds. Running in the debugger shows no crash or hang using latest git master and wx V3.1.0. What version of wx library are you using?

Dan
transmitterdan is online now   Reply With Quote
Old 24-05-2020, 08:38   #53
Marine Service Provider
 
bdbcat's Avatar

Join Date: Mar 2008
Posts: 6,118
Re: OpenCPN Version 5.1.518 Beta Test

Dan...
Same, 3.1, local build.


So, can you see the wxScrolledWindow with 1007 chart entries? And does it scroll correctly?


Dave
bdbcat is offline   Reply With Quote
Old 24-05-2020, 08:52   #54
Registered User
 
transmitterdan's Avatar

Join Date: Oct 2011
Boat: Valiant 42
Posts: 6,283
Re: OpenCPN Version 5.1.518 Beta Test

Quote:
Originally Posted by bdbcat View Post
Dan...




We are using:
#define NEW_LIST.


So the chart list is a wxScrolled Window, instead of the older checked list control.


Code:
#ifdef NEW_LIST
    m_scrollWinChartList = new wxScrolledWindow( chartsPanel, wxID_ANY, wxDefaultPosition, wxDefaultSize, wxVSCROLL);
    chartsPanelBoxSizer->Add( m_scrollWinChartList, 0, wxEXPAND );
    m_scrollWinChartList->SetScrollRate(5, 5);
    m_scrollWinChartList->SetMinSize( wxSize( -1,12 * GetCharHeight() ) );
    
    m_boxSizerCharts = new wxBoxSizer(wxVERTICAL);
    m_scrollWinChartList->SetSizer(m_boxSizerCharts);
    
#else
    m_clCharts = new wxCheckedListCtrl(chartsPanel, wxID_ANY, wxDefaultPosition, wxDefaultSize, wxLC_REPORT|wxLC_SINGLE_SEL);
    m_clCharts->SetMinSize( wxSize( 100,10 * GetCharHeight() ) );
    chartsPanelBoxSizer->Add( m_clCharts, 0, wxEXPAND );

#endif
And it seems that Windows has trouble with a scrolled window of very large virtual size.


If I revert to the "checked list control", it works OK, although there are some layout problems.


Dave
Dave,

In chardldrgui.h try this to avoid including checkedlistctrl.h:

#define NEW_LIST
#if !defined NEW_LIST
#include "checkedlistctrl.h"
#endif

Then fix every compile error that ensues by using #ifdef NEW_LIST to guard the old code that used checkedlistctrl.

Maybe some old checklistctrl code is still in there. For me I don't have any hangs or crashes.
transmitterdan is online now   Reply With Quote
Old 24-05-2020, 10:22   #55
Marine Service Provider
 
bdbcat's Avatar

Join Date: Mar 2008
Posts: 6,118
Re: OpenCPN Version 5.1.518 Beta Test

Dan...
Something funny going on here....

"Then fix every compile error that ensues by using #ifdef NEW_LIST to guard the old code that used checkedlistctrl."


if I simply say:
#define NEW_LIST
I get no compile errors.
Can you give me an example of an error that you see?
Thanks
Dave
bdbcat is offline   Reply With Quote
Old 24-05-2020, 11:19   #56
Registered User
 
transmitterdan's Avatar

Join Date: Oct 2011
Boat: Valiant 42
Posts: 6,283
Re: OpenCPN Version 5.1.518 Beta Test

Quote:
Originally Posted by bdbcat View Post
Dan...
Something funny going on here....

"Then fix every compile error that ensues by using #ifdef NEW_LIST to guard the old code that used checkedlistctrl."


if I simply say:
#define NEW_LIST
I get no compile errors.
Can you give me an example of an error that you see?
Thanks
Dave
Dave,

Around line 130 of chartdldrgui.h I had to add this compile time guard because I blocked inclusion of checkedlistctrl.h.

#if !defined NEW_LIST
wxCheckedListCtrl *m_clCharts;
#endif /* NEW_LIST */

I think there were a couple more errors but don't remember exactly. The NEW_LIST define wasn't originally used in chartdldrgui.h so it was still dragging in code from checkedlistctrl.h. I just had a hunch this might not be a good thing. Remember, I cannot reproduce this error even though I tried exactly what you tried. That leads me to think it is something peculiar to the build environment (compiler version, wx version, etc.).

I can post a link to a WIN10 installer built on my system if someone wants to try it.
transmitterdan is online now   Reply With Quote
Old 24-05-2020, 11:33   #57
Registered User

Join Date: Oct 2014
Posts: 264
Re: OpenCPN Version 5.1.518 Beta Test

Quote:
Originally Posted by transmitterdan View Post
Dave,

Around line 130 of chartdldrgui.h I had to add this compile time guard because I blocked inclusion of checkedlistctrl.h.

#if !defined NEW_LIST
wxCheckedListCtrl *m_clCharts;
#endif /* NEW_LIST */

I think there were a couple more errors but don't remember exactly. The NEW_LIST define wasn't originally used in chartdldrgui.h so it was still dragging in code from checkedlistctrl.h. I just had a hunch this might not be a good thing. Remember, I cannot reproduce this error even though I tried exactly what you tried. That leads me to think it is something peculiar to the build environment (compiler version, wx version, etc.).

I can post a link to a WIN10 installer built on my system if someone wants to try it.
Dan,

I'd like to try your build on Win10.

Thanks,
Paul
.Paul. is offline   Reply With Quote
Old 24-05-2020, 17:27   #58
Marine Service Provider
 
bdbcat's Avatar

Join Date: Mar 2008
Posts: 6,118
Re: OpenCPN Version 5.1.518 Beta Test

Dan...
Humor me, if you can, and install the "official" 5.1.518 Beta.
Prove that it fails, so that you will recognize the symptoms....


Thanks
Dave
bdbcat is offline   Reply With Quote
Old 24-05-2020, 17:40   #59
Marine Service Provider
 
bdbcat's Avatar

Join Date: Mar 2008
Posts: 6,118
Re: OpenCPN Version 5.1.518 Beta Test

Dan...
You must not be using current github.
On current github, "chartdldrgui.h" includes checkedlistctrl.h. So everything compiles OK.
I have tried building with your idea, to remove checkedlistctrl.h, and adding guards.
Still fails.


What other changes have you made?


Do you have a link to your built installer?


Thanks

Dave
bdbcat is offline   Reply With Quote
Old 24-05-2020, 19:06   #60
Marine Service Provider
 
bdbcat's Avatar

Join Date: Mar 2008
Posts: 6,118
Re: OpenCPN Version 5.1.518 Beta Test

TDan...
re:
"What i mean is the small box lower right that displays scale I want to click it and a dialog box lets me type in the scale. Then the existing zoom function takes that new ratio and runs."


Done, in github now.
Please have a look.


Thanks
Dave
__________________

bdbcat is offline   Reply With Quote
Reply

Tags
enc, opencpn

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes Rate This Thread
Rate This Thread:

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are Off
Pingbacks are Off
Refbacks are Off


Similar Threads
Thread Thread Starter Forum Replies Last Post
OpenCPN Version 5.1.511 Beta Test bdbcat OpenCPN 103 23-05-2020 04:02
OpenCPN Version 5.1.428 Beta Test bdbcat OpenCPN 289 19-05-2020 04:46
Version 5.0.518 / Intel UHD630 Minor Bugs Found Biggles OpenCPN 0 21-05-2019 05:13
OpenCPN Version 2.2 Beta Test bdbcat OpenCPN 437 15-12-2010 20:17
OpenCPN Version 2.2 Beta Test Bugs / Discussion bdbcat OpenCPN 120 26-09-2010 02:53

Advertise Here


All times are GMT -7. The time now is 18:16.


Google+
Powered by vBulletin® Version 3.8.8 Beta 1
Copyright ©2000 - 2020, vBulletin Solutions, Inc.
Social Knowledge Networks
Powered by vBulletin® Version 3.8.8 Beta 1
Copyright ©2000 - 2020, vBulletin Solutions, Inc.

ShowCase vBulletin Plugins by Drive Thru Online, Inc.