OpenCPN for Android Beta test 4.1.909

[tom_BigSpeedy]

Originally Posted by Ptizef

Compiled the last git ( 4.1.909 ++
I have stiill the crash with both Windows and Kubuntu described here :

http://www.cruisersforum.com/forums/...ml#post1900320
http://www.cruisersforum.com/forums/...ml#post1900441

Am I the only one ?

Jean Pierre

Hi Jean Pierre,

no problem for me, I can switch forth and back as needed. No crashes ...

I can test on Win7 Prof., VC2013, wxWidgets 3.02 only.
I'm using the latest windows beta (602) as a basis (installed 602, then then always copy my .exe + plugins into the directory) and run O with -p command line option from this directory. I.e. O has his own opencpn.ini file as well.

Thomas

[tom_BigSpeedy]

Found a bug in dashboard.
It definitely affects Windows, but possibly also other OSses (except MAC, I suppose). So I'll post it here. Feel free to move it ...

If you have more than one dashboards defined, you can right-mouse click on the dashboard, then a context menu pops up, where you can see all your defined dashboards. The active dashboard(s) has/have a tick set.
In the past it was simply possible to click any of you other dashboards in the context menu to activate (show) it.
This was quite useful and quick to e.g. temporarily open the wind history, etc.

This is not possible anymore since this 385ed6e6adc2ae49abca9ffb8647b48db199268c
commit from Jan 08, 2015 :
"Correct potential fault on Mac Dashboard Preferences dialog"
The commit affects dashboard_pi.cpp:
------------
void dashboard_pi::PopulateContextMenu( wxMenu* menu )
{
for( size_t i = 0; i < m_ArrayOfDashboardWindow.GetCount(); i++ ) {
DashboardWindowContainer *cont = m_ArrayOfDashboardWindow.Item( i );
wxMenuItem* item = menu->AppendCheckItem( i+1, cont->m_sCaption );
item->Check( cont->m_bIsVisible );
}
}
------------
It used to be .. menu->AppendCheckItem( i, cont-> ...

Now you have to right click to open the context menu, then select the settings submenu, the select the correct dashboard, then set the tick "Show", then OK ... quite a pain in the a...

Looking at the commit message, I do not really understand the reason for this commit (ahemm ... Dave ... ?), so I'm not sure if we can simply limit it to MAC users with a "#ifdef __WXOSX__" ...

BR,

Thomas

[CarCode]

Thomas,
it doesn't work with Mac OS X either as it should. Same as in Windows you described. But for Mac OS X it is not allowed to have a menuitem with ID zero. So to avoid an assert the developers have appended i+1 to the ID which is wrong in any way.

Another issue with dashboard is the number of GPS satellits item which shows sats in view but not sats in use which is quite different. Sats in view is mostly useless but sats in use is more importand for signal quality.

Gerhard

[Ptizef]

Originally Posted by tom_BigSpeedy

Hi Jean Pierre,

no problem for me, I can switch forth and back as needed. No crashes ...

I can test on Win7 Prof., VC2013, wxWidgets 3.02 only.
I'm using the latest windows beta (602) as a basis (installed 602, then then always copy my .exe + plugins into the directory) and run O with -p command line option from this directory. I.e. O has his own opencpn.ini file as well.

Thomas

It appends when there are CM93 and BSB in the same chart group
- manage to have only CM93 displayed. then move the chart to get a blue chart bar. The scale must be too big for the BSB to be displayed
click on the blue chart = crash

the same windows and linux
the same chart no problem with 4.0.0

Jean Pierre

[Hakan]

Thomas...
Ahaa...That's why! I have noticed it but didn't report. I've now tried your fix, in Win, and it works fine.
Håkan

[bdbcat]

Ptizef....

re:
"It appends when there are CM93 and BSB in the same chart group"

Cannot reproduce. Works fine wherever I try it.
I think we need specific lat/lon/scale to reproduce.
Give us a hint, please....

Thanks
Dave

[Hakan]

Ptizef...Dave...
re:
"It appends when there are CM93 and BSB in the same chart group"
WinXP:
I couldn’t either reproduce to a crash but memory usage increased from ~200 Mb to close to 500 when I clicked a blue bar from the attached view. The memory was released after zoom to a level decent for the BSB chart.
Håkan

[Ptizef]

Dave
In a chart group named "2011", I have a set of CM93 and a set of small bsb charts created by GE2KAP
You can see a screen shot with bsb outlines. In this configuration when I click on the blue bar, I get a crash with the backtrace as displayed in shot3
This is a Linux Kubuntu example, O was compiled under Code::Block and wx3.0.2 but I get exactly the same crash and same backtrace with Windows/wx3.0.2/vs2013

The problem has started a while ago, I suspect commit "improve performance of loading raster charts" to be the origin

Jean Pierre

[seandepagnier]

Ptizef,

Please apply https://github.com/OpenCPN/OpenCPN/pull/374

It has not been merged yet but should correct your problem.

[bdbcat]

Ptizef....

Still unable to reproduce. I think it must depend on the exact size and content of the KAP chart. Also, if the KAP chart has been already converted to a GL cached tile, there should be no crash, since this code only executes when the KAP file is initially read..

I applied Sean's patch, since it looks good anyway. Please try with the current github master.

Also, if you may post the charts at Ft Navalo, we could analyze more fully. I think we must understand this fully, otherwise it will come back later....

Thanks
Dave

[seandepagnier]

Dave,

I found a crash when you have kap files with exact tile dimensions (like 512 or 1024) with the optimized bsb loader.

Before it just wasted a bunch of memory and took longer by filling it with zero then never using it, but didn't crash.

[curl]

Performance much better now.

Will there be s-63 support?

Some gremlins:

Creating the route doesn't work for me, my short tap translates to pan (samsung s6).

Having just one raster chart , zooming out to where parts of outline are inside of the screen the chart is replaced by WChart. Not so in the 3.2.2 version.

Having raster and cm93 charts , raster acive, "pan" out from raster WChart shows up and no drop down chart menu. My solution go back to raster chart , select cm93 from drop down and than pan out again .
I also think the drop down menu needs some work.

Above is still valid after compiling with pull reguest #374,

Selecting "old" setting (options) somtimes the font is changed to a big fonttype , see attched pic.
Think this happen after screen flipping the screen before activate options. Solution restart the app.


App always crash om my android 5.1.1 device when gps activates and register movement.
FS#1853 - android 5.1.1 gps
Supplied a logacat

Have other crashes on android 4.4.2 device, have no idea why
FS#1854 - Crash on android 4.4.2
Supplied one dumpstat

[vincentapel]

Kudos.. but where is the ships position? Like the ones in pc version. Can this be feature on the next release?

[Ptizef]

Dave,Sean

Obviously Sean's patch fixes the bug
I tried several time in same conditions:
-without patch = crash
- with patch = no crash
So the last git works fine. Thanks
A remark:
among my many tests I noticed that when compiling in Windows by command line instead of inside vs2013, I didn't get this crash ... curious
and why not in Android as it's the same code ?
May be you understand that ?

Jean Pierre

[CarCode]

Originally Posted by Ptizef

A remark:
among my many tests I noticed that when compiling in Windows by command line instead of inside vs2013, I didn't get this crash ... curious
and why not in Android as it's the same code ?
May be you understand that ?

Same here with Mac OS X: Different compilers produce different results. Since a long time I don't use gcc anymore but Clang/LLVM for better products.

Gerhard