OpenCPN Beta Version 3.3.2118 Released

[Baikal]

Originally Posted by nohal

Baikal...
Isn't there a shorter term, something like "Overzoom"? I'm not exactly sure that "Чрезмерное приближение" fits on the screen...
This is not a rhetoric question, the reason for asking it is https://github.com/OpenCPN/OpenCPN/b...canv.cpp#L9523 - We don't display that text if it is wider than 500 pixels...

Pavel

The term "overzoom" not reaching some people it represents.
in our terminology applicable ECDIS is referred to as "Завышение масштаба"
Essential that the this translation is to hit the limit

[nohal]

Baikal...
Seems like a few more languages will have a similar problem, so the solution should be adjusting the size of the font and not increasing that limit to still support lower resolution displays.
Will do it later today.

Thanks for your help

Pavel

[bdbcat]

Pavel...

I guess we will reduce the font size (in a loop) and make it fit 500 wide....

oops, collision...

Dave

[nohal]

Fix is in the github master now.


Pavel

[rooiedirk]

Originally Posted by rooiedirk

Also noticed that:
On showing AIS names, OpenGL does not acknowledge font color settings. The name is always printed in black. Font size, style etc are working.

found a solution for this: Works for me under linux and Intel graphics using openGL.
made some changes to ocpndc.cpp DrawText. See comments in code.

void ocpnDC::DrawText( const wxString &text, wxCoord x, wxCoord y )
{
    if( dc ) dc->DrawText( text, x, y );
    else {
        wxCoord w = 0;
        wxCoord h = 0;
#ifdef __WXMAC__
        wxBitmap tbmp(200, 200);
        wxMemoryDC mac_dc(tbmp);
        mac_dc.GetTextExtent(text, &w, &h, NULL, NULL, &m_font);
#else
        GetTextExtent( text, &w, &h );
#endif

        if( w && h ) {
            /* create maskbitmap of appropriate size and select it */
            wxBitmap maskbmp( w, h );
            wxMemoryDC temp_dc;
            temp_dc.SelectObject( maskbmp );

            /* fill bitmap with black */
            temp_dc.SetBackground( wxBrush( wxColour( 0, 0, 0 ) ) );
            temp_dc.Clear();

            /* draw the text white */
            temp_dc.SetFont( m_font );
            temp_dc.SetTextForeground( wxColour( 255, 255, 255 ) );
            temp_dc.DrawText( text, 0, 0 );
            temp_dc.SelectObject( wxNullBitmap );
        
        wxMask mask( maskbmp, wxColour( 0, 0, 0 ) ); 
        //Create new bitmap and fill it with font colour
        wxBitmap* bmp = new wxBitmap( w, h );     
            temp_dc.SelectObject( *bmp );
            temp_dc.SetBackground( wxBrush( wxColour( m_textforegroundcolour.Red(), m_textforegroundcolour.Green(),
                    m_textforegroundcolour.Blue()  ) ) );
        temp_dc.Clear();
        temp_dc.SelectObject( wxNullBitmap );
        //Set the mask(containing the text)
        bmp->SetMask( &mask );
        //finaly paint draw bitmap to screen
        DrawBitmap( *bmp, x, y, true);        
    }
    }
}

Picture with blue AISName and Yellow chart text.

[rooiedirk]

Can't edit the above anymore.
Code does need some polishing aspecial adding night color scheme.
Dirk

[bdbcat]

Dirk....

Nice clean code.

We will need to tweak the idea somewhat, so that we don't pay a large performance penalty when there is lots of text displayed. This method is heavily used.

Probably need to not do the bitmap approach if the text color is default black, for example....

Thanks
Dave

[rooiedirk]

Yes that would help.
Also could double some code from the DrawBitmap methode without the safety testings etc, as we do know what we feed in. (Or split the DrawBitmap in 2 methodes one for checking and one do the actual drawing)

BTW normal ECDIS settings for AISname is using Green text
Dirk

[seandepagnier]

Originally Posted by rooiedirk

Yes that would help.
Also could double some code from the DrawBitmap methode without the safety testings etc, as we do know what we feed in. (Or split the DrawBitmap in 2 methodes one for checking and one do the actual drawing)

BTW normal ECDIS settings for AISname is using Green text
Dirk

I am trying to follow what you are talking about, but I cannot seem to find the code you posted in opcpndc.cpp, or why it is needed. Maybe you can give a full diff?

I have intel graphics and the font colors work fine. I believe the code in TexFont is what should be utilized instead of this one anyway because it's already much faster and supports colors without issues.

[rooiedirk]

Originally Posted by boat_alexandra

I have intel graphics and the font colors work fine. I believe the code in TexFont is what should be utilized instead of this one anyway because it's already much faster and supports colors without issues.

On my Gentoo machine the font colors are not working. Did try to play a bit with the settings for mesa but no colored fonts. Double checked on a "virtual" XP and there it was working fine.
The methode void ocpnDC:rawText (line 1019) is called from several places in the code (see screenshot). I do agree with you that the TexFont is a better way of doing this, (didn't notice it was there yet) but a bit behind my skills.

[rooiedirk]

See that for S52 charts you did implement TexFont(). Works also here if I use the US ENC's.
Dirk

[rooiedirk]

Skills are there to improve
With some try and error I have AisName writing to screen now using TexFont. TextColors are now working for me.
Dirk

[Gilletarom]

Hello Dave, Hello Pavel

I can finally have a good internet connection. I finally got to use all the possibilities of the plugin sQuiddio.

But when I use this plugin, I can close OpenCPN but I can not run it again.
Moreover, OpenCPN does not appear in applications of the main windows manager. But it appears in the process.
I have to go manually close the process in order to launch O again.

This is the first time I meet this problem. And as this is the first time I can fully experience sQuiddio, I guess it's related to this plugin. ????

Best regards, Gilletarom.

[bdbcat]

Gilletarom...

This is a known bug in the OCPN base. You may avoid the problem by never accessing the "Waypoint Properties" dialog.

I know this makes life difficult for testing. A new Beta comes soon.

Thanks
Dave

[Gilletarom]

Hello Dave,

Originally Posted by bdbcat

Gilletarom...
This is a known bug in the OCPN base. You may avoid the problem by never accessing the "Waypoint Properties" dialog.
.......
Dave

Oops ... Sorry. I will look forward in the flyspary.

That said, I must add that I have tried to open the characteristics of a visible waypoint, but located near several other waypoints. These hidden waypoints makes part of a route. Too often, it is the property window of route waypoints that opened.

B.R