New Plugin NmeaConvertor

[rgleason]

Updated to "fix compiler warnings"
https://github.com/rgleason/NmeaConverter_pi/releases

[wholybee]

I am playing with this on 2 machines. Both are running 4.8.2, installed from the .exe on the download page.

On one machine I am running NMEA converter which I compiled myself. (compiled on a separate 3rd machine then I copied the dll over) It isn't the latest update which accepts wildcards, but about 2 weeks old. It seems to work fine, although I have not run it for extended periods.

On the other machine I installed NMEA converter from the .exe that was posted by Rick. It freezes opencpn when I click on "new" from the preferences dialog.

Let me know how I can collect information to help track the issue. One difference I now realize is that on the machine that it freezes on, I don't have any incoming NMEA data presently.

Somewhat related, I pursued this for TWS and TWA, and the long and complex formula posted here seems to work fine for that on the machine this plugin is working on.

[rgleason]

Wollybee, I don't get a crash when I hit "New" but I do get a crash when I try to run a formula while playing an data stream.

I have tried to compile "out of tree" or "standalone mode" and I'm unable to create a debug dll, possibly because the CMAKE is not fully developed?

I then tried to move the nmeaconverter_pi "into the tree" and then run debug to get the required debug dll. That does not seem to work either, which makes me think it is a CMAKE problem.

So in short I cannot debug it, but I can confirm it is not working.

[rgleason]

The last update to packaging & Cmake was June6 &7, 2015.
https://github.com/RooieDirk/NmeaCon...commits/master

I am going to try a fresh git clone to make sure there isn't some anomaly, but github says my repos is identical to Dirks.

[rgleason]

Dirk
What Plugin API version number does this use?
I have been using Plugin API
pi113 (1.13) = OpenCPN 4.2 ←SVG Icons added (gtk,expat,vc,etc)
And it compiles with no complaint.
Has it changed?

I only found in a search for "API"

#include "version.h"

#define MY_API_VERSION_MAJOR 1
#define MY_API_VERSION_MINOR 8

#include "ocpn_plugin.h"

I certainly do not understand this number? 1.8? We don't have such a Plugin API that I know of.

[rgleason]

Using Plugin API Version 1.13 it compiles, but that does not make it right.

I get 33 warnings which might help (since I can't make this run in debug) and a comparison of the various CMAKE files with WMM_pi shows that some If WIN statements are missing for standalone and in tree compiling.

Build succeeded.

"C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\build\ALL_BUILD.
vcxproj" (default target) (1) ->
"C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\build\nmeaconver
ter_pi.vcxproj" (default target) (3) ->
(ClCompile target) ->
C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\src\ec_engine.c
pp(26): warning C4273: 'wxEcEngine::wxEcEngine' : inconsistent dll linkage [C:\
Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\build\nmeaconverter_
pi.vcxproj]
C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\src\ec_engine.c
pp(37): warning C4273: 'wxEcEngine::~wxEcEngine' : inconsistent dll linkage [C:
\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\build\nmeaconverter
_pi.vcxproj]
C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\src\ec_engine.c
pp(42): warning C4273: 'wxEcEngine::GetFormula' : inconsistent dll linkage [C:\
Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\build\nmeaconverter_
pi.vcxproj]
C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\src\ec_engine.c
pp(47): warning C4273: 'wxEcEngine::GetIndicator' : inconsistent dll linkage [C
:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\build\nmeaconverte
r_pi.vcxproj]
C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\src\ec_engine.c
pp(55): warning C4273: 'wxEcEngine::GetLastError' : inconsistent dll linkage [C
:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\build\nmeaconverte
r_pi.vcxproj]
C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\src\ec_engine.c
pp(60): warning C4273: 'wxEcEngine::GetLastResult' : inconsistent dll linkage [
C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\build\nmeaconvert
er_pi.vcxproj]
C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\src\ec_engine.c
pp(85): warning C4273: 'wxEcEngine::Reset' : inconsistent dll linkage [C:\Users
\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\build\nmeaconverter_pi.vc
xproj]
C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\src\ec_engine.c
pp(106): warning C4273: 'wxEcEngine::TranslateError' : inconsistent dll linkage
[C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\build\nmeaconve
rter_pi.vcxproj]
C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\src\ec_engine.c
pp(126): warning C4273: 'wxEcEngine:eleteConstant' : inconsistent dll linkage
[C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\build\nmeaconve
rter_pi.vcxproj]
C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\src\ec_engine.c
pp(131): warning C4273: 'wxEcEngine::GetConstant' : inconsistent dll linkage [C
:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\build\nmeaconverte
r_pi.vcxproj]
C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\src\ec_engine.c
pp(158): warning C4273: 'wxEcEngine::GetConstantCount' : inconsistent dll linka
ge [C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\build\nmeacon
verter_pi.vcxproj]
C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\src\ec_engine.c
pp(163): warning C4273: 'wxEcEngine::ListAllConstants' : inconsistent dll linka
ge [C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\build\nmeacon
verter_pi.vcxproj]
C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\src\ec_engine.c
pp(175): warning C4273: 'wxEcEngine::ResetConstants' : inconsistent dll linkage
[C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\build\nmeaconve
rter_pi.vcxproj]
C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\src\ec_engine.c
pp(186): warning C4273: 'wxEcEngine::SetConstant' : inconsistent dll linkage [C
:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\build\nmeaconverte
r_pi.vcxproj]
C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\src\ec_engine.c
pp(230): warning C4273: 'wxEcEngine::BracketLookup' : inconsistent dll linkage
[C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\build\nmeaconver
ter_pi.vcxproj]
C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\src\ec_engine.c
pp(268): warning C4273: 'wxEcEngine::ConvertToRadian' : inconsistent dll linkag
e [C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\build\nmeaconv
erter_pi.vcxproj]
C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\src\ec_engine.c
pp(279): warning C4273: 'wxEcEngine::CountChar' : inconsistent dll linkage [C:\
Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\build\nmeaconverter_
pi.vcxproj]
C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\src\ec_engine.c
pp(288): warning C4273: 'wxEcEngine::FindOperator' : inconsistent dll linkage [
C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\build\nmeaconvert
er_pi.vcxproj]
C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\src\ec_engine.c
pp(297): warning C4273: 'wxEcEngine::Function2ID' : inconsistent dll linkage [C
:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\build\nmeaconverte
r_pi.vcxproj]
C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\src\ec_engine.c
pp(311): warning C4273: 'wxEcEngine::FunctionLookUp' : inconsistent dll linkage
[C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\build\nmeaconve
rter_pi.vcxproj]
C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\src\ec_engine.c
pp(337): warning C4273: 'wxEcEngine::IsOperator' : inconsistent dll linkage [C:
\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\build\nmeaconverter
_pi.vcxproj]
C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\src\ec_engine.c
pp(344): warning C4273: 'wxEcEngine::IsParitySign' : inconsistent dll linkage [
C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\build\nmeaconvert
er_pi.vcxproj]
C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\src\ec_engine.c
pp(357): warning C4273: 'wxEcEngine::IsValid' : inconsistent dll linkage [C:\Us
ers\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\build\nmeaconverter_pi
.vcxproj]
C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\src\ec_engine.c
pp(390): warning C4273: 'wxEcEngine::LeftPool' : inconsistent dll linkage [C:\U
sers\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\build\nmeaconverter_p
i.vcxproj]
C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\src\ec_engine.c
pp(397): warning C4273: 'wxEcEngine::NextOperator' : inconsistent dll linkage [
C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\build\nmeaconvert
er_pi.vcxproj]
C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\src\ec_engine.c
pp(406): warning C4273: 'wxEcEngine::Simplify' : inconsistent dll linkage [C:\U
sers\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\build\nmeaconverter_p
i.vcxproj]
C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\src\ec_engine.c
pp(464): warning C4273: 'wxEcEngine::ApplyFunction' : inconsistent dll linkage
[C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\build\nmeaconver
ter_pi.vcxproj]
C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\src\ec_engine.c
pp(624): warning C4273: 'wxEcEngine::Compute' : inconsistent dll linkage [C:\Us
ers\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\build\nmeaconverter_pi
.vcxproj]
C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\src\ec_engine.c
pp(635): warning C4273: 'wxEcEngine::evalexp' : inconsistent dll linkage [C:\Us
ers\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\build\nmeaconverter_pi
.vcxproj]
C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\src\ec_engine.c
pp(670): warning C4273: 'wxEcEngine::evalf' : inconsistent dll linkage [C:\User
s\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\build\nmeaconverter_pi.v
cxproj]
C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\src\ec_engine.c
pp(764): warning C4273: 'wxEcEngine:erivate' : inconsistent dll linkage [C:\U
sers\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\build\nmeaconverter_p
i.vcxproj]
C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\src\ec_engine.c
pp(788): warning C4273: 'wxEcEngine::SetFormula' : inconsistent dll linkage [C:
\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\build\nmeaconverter
_pi.vcxproj]
C:\Users\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\src\ec_engine.c
pp(805): warning C4273: 'wxEcEngine::StackIt' : inconsistent dll linkage [C:\Us
ers\Frederick\Documents\GitHub\o-plugin\NmeaConverter_pi\build\nmeaconverter_pi
.vcxproj]

33 Warning(s)
0 Error(s)

[rgleason]

With fresh git clone, compile, opencpn.lib version PI-API 1.13, install, had to rename opencpn.ini because previous version of nmea had made opencpn so it would not load properly (Toolbar Icons missing). so then started opencpn and a new opencpn.ini was created. I could then Enable the plugin.

Then when I clicked "New" eventually after long blue circle spinning, I got an OpenCPN failure and Windows notice.

[rgleason]

Tried compile with v1.15 of opencpn.lib and installed. It fails in the same way, when I hit "new"
This is as far as I can take it, as it does not compile in debug mode either.

[rgleason]

The most recent version of this plugin, when compiled for Windows and run, hangs up and fails Opencpn when you hit "New" to enter a nmea conversion formula.

I have reported this earlier.. The debug version does not work either.
It would be great if we could get this fixed.

Dirk has just added a wildcard option.

Github https://github.com/rgleason/NmeaConverter_pi

Documentation
https://opencpn.org/wiki/dokuwiki/do...nmea_converter

I'd really appreciate a programmer looking at this. Is this a problem in Linux too?

[rgleason]

Mike R. [Rasbats] has figured out that RooieDirk's version is not the one that compiled for windows... The one compiled for windows that works is Pavels [nohal] "Bump version" commit.

I believe Mike will be comparing the two versions to come up with a fix. Thanks again Mike!

[Rasbats]

Rick ...

I did not figure anything out!

If an issue is being discussed on GitHub please can we keep the conversation there.

Thanks.
Mike

[rgleason]

Ok, I'll keep it there, but we now know that the one that works for windows is pavel's "bump version" commit, so that's much better than what we knew before, I was banging my head on that one.

[rgleason]

We've had to step back one commit, as the last commit to fix compiler warnings does not work. So this version is the previous version which "adds wildcards" which will be very useful if you don't know a devices id. So the note in the manual about this

Add Wildcards - NmeaConverter Manual

Beta download
nmeaconverter_pi-0.2-add-wildcard-win32

We really need this tested carefully by some pros. Please let us know how it is working, or we will not know and Dirk says he will not be able to release it from Beta.

Wollybee I hope you'll give this one a try.

[rgleason]

Some suggestions about how to test nmeaconverter if you are not on your boat and need nmea data. Additional examples and formulas are welcome, we will add them to the manual!

[wholybee]

Originally Posted by rgleason

We've had to step back one commit, as the last commit to fix compiler warnings does not work. So this version is the previous version which "adds wildcards" which will be very useful if you don't know a devices id. So the note in the manual about this

Add Wildcards - NmeaConverter Manual

Beta download
nmeaconverter_pi-0.2-add-wildcard-win32

We really need this tested carefully by some pros. Please let us know how it is working, or we will not know and Dirk says he will not be able to release it from Beta.

Wollybee I hope you'll give this one a try.

Wildcards don't seem to work for me. When I first enter a ?, the output line changes to "nodata" and then a few seconds later OpenCPN crashes.
-Warren