Cruisers Forum
 


Join CruisersForum Today

Reply
 
Thread Tools Rate Thread Display Modes
Old 28-03-2013, 05:08   #331
LJH
Registered User

Join Date: Mar 2012
Location: Nova Scotia
Boat: Wauquiez Centurion 42
Posts: 271
Re: WeatherFax...

Quote:
Originally Posted by rgleason View Post
Sean I think you nailed it!
Much much better. I like the lat/long again. Thank.

(Why do I have to delete the old dlls in build/plugins/debug to get a new one with today's current date to appear? Is it just over-writting into the existing file and not changing the file date? Never noticed that before.)

There were no breaks. I was able to do polar files I had breaks and trouble with. I was able to do polar files that I had not done before and I am reasonably confident that this is really working better. In debug mode it was smoother and more responsive and the zoom in zoom out problems seem better too!

I am pretty sure the attached release DLL will be 98% good.
By the way, I found that the transparency thing on the first screen goes away when you just grab the window and shake it a little, then everything is fine! So shake the window when you first load a file.

Test this file out by taking the doc of the end and placing in your plugins directory, after deleting your old weatherfax_pi.dll
yes well done Sean

Thanks also for Lat/Long.

With OpenGL on:
3 Mercator and 3 Polar faxes at the same time - no issues at all.
Opened Grib and AIS plugins as well - no conflicts.
Opened few layers that had over 1000 items all together - no issues.
Repeated with GL off - same results.
Panning and scaling worked well throughout.
I also had to shake the first screen if I wanted to see the image correction panel.

Thanks again for all the work from everyone involved. It is working well for my machine (W7 64 Bit NIVIDI GTX560M)
__________________

__________________
LJH is offline   Reply With Quote
Old 28-03-2013, 05:12   #332
Registered User

Join Date: Apr 2012
Location: Panama City, Panama
Boat: Van der Stadt Samoa 48
Posts: 118
Re: WeatherFax...

I would also say that it works fine, but how do i delete all the presets that i don't need. The presets are very good.

Lars
__________________

__________________
Taarnskov is offline   Reply With Quote
Old 28-03-2013, 05:27   #333
LJH
Registered User

Join Date: Mar 2012
Location: Nova Scotia
Boat: Wauquiez Centurion 42
Posts: 271
Re: WeatherFax...

Quote:
Originally Posted by Taarnskov View Post
I would also say that it works fine, but how do i delete all the presets that i don't need. The presets are very good.

Lars
They are stored in opencpn.ini
There was a post from rgleason earlier in the thread about it.
__________________
LJH is offline   Reply With Quote
Old 28-03-2013, 13:30   #334
Registered User

Join Date: Apr 2009
Location: Marina Del Rey
Boat: Hylas 44
Posts: 385
Re: WeatherFax...

This patch will remove the requirement to "shake" the first screen to see the Image Correction fields.

Code:
diff --git a/src/WeatherFaxWizard.cpp b/src/WeatherFaxWizard.cpp
index f5ce56b..d63466c 100644
--- a/src/WeatherFaxWizard.cpp
+++ b/src/WeatherFaxWizard.cpp
@@ -194,8 +194,8 @@ void WeatherFaxWizard::OnStopDecoding( wxCommandEvent& event )
 
 void WeatherFaxWizard::OnPaintPhasing( wxPaintEvent& event )
 {
-    if(!m_decoder)
-        return;
+//    if(!m_decoder)
+//        return;
 
     wxWindow *window = dynamic_cast<wxWindow*>(event.GetEventObject());
     if(!window)
@@ -203,6 +203,9 @@ void WeatherFaxWizard::OnPaintPhasing( wxPaintEvent& event )
 
     wxPaintDC dc( window );
 
+    if(!m_decoder)
+        return;
+
     dc.SetBrush(wxBrush(*wxBLACK));
     dc.SetPen(wxPen( *wxBLACK, 1 ));
__________________
ChuckSK is offline   Reply With Quote
Old 28-03-2013, 14:07   #335
Registered User
 
rgleason's Avatar

Join Date: Mar 2012
Location: Boston, MA
Boat: 1981 Bristol 32 Sloop
Posts: 7,633
Re: WeatherFax...

ChuckSK Thankyou. I know I've asked a similar question previously, but it would be helpful to understand which line(s) of src/weatherfaxwizard.cpp
@@-194,8 +194,8 @@ void WeaterFaxWizard::OnStopDecoding( wxCommandEvent&
event

...Code A

@@ -203,6 +203,9 @@ void WeatherFaxWizard::OnPaintPhasing( wxPaintEvent& event )

....Code
Is it line -194,8 +194,8 (or something like that?) then gets replaced by code A

And line 203,6 +203,9 (or something line that? then gets replaced by Code B?
__________________
rgleason is offline   Reply With Quote
Old 28-03-2013, 14:37   #336
Registered User

Join Date: Apr 2009
Location: Marina Del Rey
Boat: Hylas 44
Posts: 385
Re: WeatherFax...

Here is the WinMerge screen showing the difference.
Attached Thumbnails
Click image for larger version

Name:	wfwdiff.JPG
Views:	51
Size:	188.7 KB
ID:	58132  
__________________
ChuckSK is offline   Reply With Quote
Old 28-03-2013, 16:28   #337
Registered User
 
rgleason's Avatar

Join Date: Mar 2012
Location: Boston, MA
Boat: 1981 Bristol 32 Sloop
Posts: 7,633
Re: WeatherFax...

Thanks ChuckSK I tried modifying the file as shown above with notepad++. When I tried to compile it MSVC complained and said I had files modified externally, do I want to reload or something, so I said yes, (otherwise I have to merge it manually?), a lot of files were scanned and then I tried compiling again and eventually brought up Weatherfax_pi.. It loaded fine and was not as transparent, but still had to be shaken to get the bars to show..... I see you moved some decoder process down until after the window was opened. Maybe it needs just a little more fine tuning?

Thanks for your efforts! I wonder if Sean makes this change and I git fetch --all now with my change what will happen? It will be interesting to see.
__________________
rgleason is offline   Reply With Quote
Old 28-03-2013, 16:45   #338
Registered User

Join Date: Apr 2009
Location: Marina Del Rey
Boat: Hylas 44
Posts: 385
Re: WeatherFax...

You do know that you can edit files directly in MSVC? In any case, shaking is not required here.
__________________
ChuckSK is offline   Reply With Quote
Old 28-03-2013, 16:49   #339
Registered User
 
rgleason's Avatar

Join Date: Mar 2012
Location: Boston, MA
Boat: 1981 Bristol 32 Sloop
Posts: 7,633
Re: WeatherFax...

No, I did not know that! I am glad shaking is not required there. Maybe I did something wrong and it did not "take". I'll do it from withing MSVC and check again. Thanks.
__________________
rgleason is offline   Reply With Quote
Old 28-03-2013, 20:04   #340
Registered User
 
rgleason's Avatar

Join Date: Mar 2012
Location: Boston, MA
Boat: 1981 Bristol 32 Sloop
Posts: 7,633
Re: WeatherFax...

ChuckSK - Checked from within MSVC and the changes were there, so then I realized that I had not copied the compiled Debug DLL to the Build/Plugins directory! Silly mistake. So now it works great! No transparency issue. Thanks very much.
__________________
rgleason is offline   Reply With Quote
Old 28-03-2013, 22:24   #341
Registered User
 
boat_alexandra's Avatar

Join Date: Aug 2009
Location: grenada
Boat: bristol 27
Posts: 2,510
Re: WeatherFax...

chuck,

Thanks very much for the patch I'll put it in. I have no idea why that fixed it though (based on looking at the code) Do you know why? or was it just experimentation? Maybe you have to make a dc or else call event.skip()...
__________________
boat_alexandra is offline   Reply With Quote
Old 29-03-2013, 06:28   #342
Registered User
 
rgleason's Avatar

Join Date: Mar 2012
Location: Boston, MA
Boat: 1981 Bristol 32 Sloop
Posts: 7,633
Re: WeatherFax...

Sean, when I git fetch --all the next update will it overwrite what I've done locally? Just trying to figure out how git does this.
__________________
rgleason is offline   Reply With Quote
Old 29-03-2013, 09:13   #343
Registered User

Join Date: Feb 2010
Location: On the go. Not in Prague.
Posts: 3,902
Rick...

No, it will not until you apply some more evil. It was written by people who don't like loosing their work

Pavel
__________________
nohal is offline   Reply With Quote
Old 29-03-2013, 09:52   #344
Registered User

Join Date: Apr 2009
Location: Marina Del Rey
Boat: Hylas 44
Posts: 385
Re: WeatherFax...

Quote:
Originally Posted by boat_alexandra View Post
chuck,

Thanks very much for the patch I'll put it in. I have no idea why that fixed it though (based on looking at the code) Do you know why? or was it just experimentation? Maybe you have to make a dc or else call event.skip()...
With wxFormBuilder I moved the various elements on the screen to different positions. The problems always appeared in the fields displayed after the Phasing window. So ensuring a wxPaintDC was created for the window was a first guess.
__________________
ChuckSK is offline   Reply With Quote
Old 29-03-2013, 17:45   #345
Registered User
 
boat_alexandra's Avatar

Join Date: Aug 2009
Location: grenada
Boat: bristol 27
Posts: 2,510
Re: WeatherFax...

Ah, good so process of elimination. I learned something about wxwidgets. Too bad it doesn't always have the same behavior between platforms, but then again, I get this with qt too.

This plugin is looking like it's hopefully pretty stable. Lots of possible extensions though...
__________________

__________________
boat_alexandra is offline   Reply With Quote
Reply

Tags
paracelle

Thread Tools
Display Modes Rate This Thread
Rate This Thread:

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are Off
Pingbacks are Off
Refbacks are Off


Similar Threads
Thread Thread Starter Forum Replies Last Post
For Sale: SSB, Tuner, Amp, WeatherFax Palarran Classifieds Archive 7 19-03-2011 08:22
Help with WeatherFax and SeaTTY desierto Navigation 2 12-12-2008 21:36
Basic Weatherfax reception Tnflakbait Marine Electronics 3 23-09-2008 22:55
How do I set myself up with weatherfax? tracker_46 Marine Electronics 4 12-10-2006 15:51
Weatherfax Recommendations Please Salacia Marine Electronics 3 03-07-2005 14:28


Our Communities

Our communities encompass many different hobbies and interests, but each one is built on friendly, intelligent membership.

» More about our Communities

Automotive Communities

Our Automotive communities encompass many different makes and models. From U.S. domestics to European Saloons.

» More about our Automotive Communities

Marine Communities

Our Marine websites focus on Cruising and Sailing Vessels, including forums and the largest cruising Wiki project on the web today.

» More about our Marine Communities


Copyright 2002- Social Knowledge, LLC All Rights Reserved.

All times are GMT -7. The time now is 01:30.


Google+
Powered by vBulletin® Version 3.8.8 Beta 1
Copyright ©2000 - 2016, vBulletin Solutions, Inc.
Social Knowledge Networks
Powered by vBulletin® Version 3.8.8 Beta 1
Copyright ©2000 - 2016, vBulletin Solutions, Inc.

ShowCase vBulletin Plugins by Drive Thru Online, Inc.