Tactics Plugin

[ptulp]

I tried to build the opencpn+tactics for OSX and Linux and see two problems.

1. Function rad2deg is declared twice in dial.cpp and tactics_pi.cpp.
Only used in dial.cpp. Causes errors during compilation.

2. Both OSX and Linux versions crash when in preferences the manual heel setting is used and no NMEA data is available.
See issues in github.

Peter.

[Neptune's Gear]

Your cleverer than me! I must learn how to do that one day....

[tom_BigSpeedy]

Hi,
I'm back from sailing ...
I added an option to use SOG instead of STW for the true wind calculation.

Next I integrated the TWD into the "App. & True Wind Angle" dial instrument


And finally, concerning the green puzzle icon :
On github, there's a data subdirectory in the plugin path

It contains the svg icons:
For now (until an installer is available, and in case you're annoyed by the puzzle icons) you can simply navigate to the plugins directory of your O installation, create a subdirectory tactics_pi/data and copy those 3 icons into it.
Just compare with dashboard_pi. Same setup.

Originally Posted by ptulp

I tried to build the opencpn+tactics for OSX and Linux and see two problems.

1. Function rad2deg is declared twice in dial.cpp and tactics_pi.cpp.
Only used in dial.cpp. Causes errors during compilation.

2. Both OSX and Linux versions crash when in preferences the manual heel setting is used and no NMEA data is available.
See issues in github.

Peter.

Peter,

thanks for testing under Linux.
ad 1. :
I already noticed last week and removed it from the code in tactics_pi.cpp
ad 2. :
Just to make sure I understand correctly :
Does it crashes, when you play around with the plugin and there isn't any NMEA data available ?
Or ...
"Does it crash when you set it to manual heel input and there is no NMEA-heel-data available ?


I'll upload the latest commit to github in a couple of minutes.

Thanks,

Thomas

[ptulp]

Originally Posted by tom_BigSpeedy

Peter,

ad 2. :
Just to make sure I understand correctly :
Does it crashes, when you play around with the plugin and there isn't any NMEA data available ?
Or ...
"Does it crash when you set it to manual heel input and there is no NMEA-heel-data available ?

Thomas,

I am testing standalone, so no NMEA data at all.
Then the moment I set the manual heel option and press OK after a few seconds it crashes.

If I add "if (wxIsNaN(mTWS)) mTWS = 0;" before line 4115 in tactics_pi.cpp
and the same for mTWA, then I don't see any crashes.

BTW, I took the liberty to take your tactics_pi and changed it to a build standalone version and put it in github/ptulp/tactics_pi.
As I never build for android I don't know how to incorporate that in the standalone build, so I discarded that part from the CMakeLists part.
CMake is now split in the CMakeLists.txt and the common files in the cmake directory.
See if you want to take over the standalone build version.

PS: I can't build for Windows so I don't know if this standalone build for windows works but I think it would as is does for other plugins.

Regards,
Peter

[tom_BigSpeedy]

Thanks Peter,

I included your fix and uploaded the latest source changes to github.

I'll try your CMake file(s) under windows.

As Rick already mentioned last week, I planned to separate the plugin anyway, but simply ran out of time, before we left for the cruise.

Best,

Thomas

[tom_BigSpeedy]

I separated the tactics plugin from my main O branch.
You can find the source here :
https://github.com/tom-r/tactics_pi


I adopted the code to Peters changes, so hopefully it'll compile under Windows (I tested with Win7) and Linux now.

@Peter : I had to change only one minor thing in cmake/PluginConfigure.cmake, compared to your proposal:

In line 51, I had to add
SET(wxWidgets_USE_LIBS base core net xml html adv aui)
to be able to link under Win7, VC2013.

Latest version of the documentation is included as well in the root directory.

Thomas

[Moontide]

Is this available as a "regular" plugin or only if I can compile the program? If as a regular (i.e. self install, etc.) can someone put up a link since I seem to have missed it in the thread.
Bill

[rgleason]

Tom, Thank you. Your branch https://github.com/tom-r/tactics_pi
builds and creates a Windows executable. It works like a charm and I like the improved App/True and Bearing Displays.

Also many thanks to Peter (Ptulp) for his work changing to a standalone plugin.

The SHA signature is

SHA256:3b1b6567236189e1d87ae279094ff8ebdab036279ca c9be86b126ec030f640c6
File name: tactics_pi-0.6001-win32.exe
Detection ratio:0 / 54
Analysis date:2016-06-28 01:42:23 UTC ( 3 minutes ago )

You can find this file in Opencpn Beta File Thingie rguser rgpass
Under the 4.2.0 PI Win directory. Be sure to get the correct filename AND to check the SHA above using VirsusTotal.com

Good luck Windows Testers, note the nmea files and .pol file that you can use in your testing, located in 4.2.0 PI Win
----
One suggestion for consideration, after some thought, perhaps make a
C:\ProgramData\opencpn\plugins\tactics\data\polars
siimilar to
C:\ProgramData\opencpn\plugins\weather_routing\dat a\polars
and put the single polar in it?

Just a quick image:
PS Image is a combination of ODraw GuardZones and Tactics_pi

[Hakan]

Hi
Rick asked me to facilitate the localization task. I've found a git repository at: https://github.com/tom-r/tactics_pi.
Is that the master source for tactics_pi? If so and if you're ready for a translation file to Crowdin I can manage that and also a preparatory pull request to that source.
Please advice.
Håkan

[tom_BigSpeedy]

Hakan,

thanks for assisting

Yes that's the repository.

Please wait till tomorrow (Monday) night (European time), there will be some minor changes.
As the plugin is originally a copy of dashboard_pi, it has already the latest tranlation files from dashboard_pi.
Maybe you can import them to Crowdin ?

Thanks again and best regards,

Thomas

[Hakan]

Thomas
Yes, calm...., I'll wait until you say. I've no hurry at all.

re: "it has already the latest tranlation files from dashboard_pi."
And you sure you haven't added any own texts at all???
Håkan

[CarCode]

Originally Posted by Hakan

And you sure you haven't added any own texts at all???
Håkan

Yes, there are several. See my own pot file attached.

Gerhard

[tom_BigSpeedy]

Hakan, Gerhard,
I'm not an expert on that topic ...

What I meant is, that I used the translation files (~/po/*.po) from dashboard. I guess that 80% of the texts are the same, and I thought : why should we start from scratch with all translations ...
But maybe I'm mislead ...
I did not update the ~/po/tactics_pi.pot manually (at least I don't remember).
If you're not in a hurry give me some more days please, I'm experimenting with the context menu right now ...

Anyway, I updated the source to Rev 0.7:
• Polarspeed, Target-VMG, Target-CMG, Target-CMG Angle instruments are corrected for user speed settings
• I added STW to Polar Performance instrument as second graph
• other minor corrections

Implementiation of user speed/distance settings is ongoing and far from being completed, though...

Best,

Thomas

[Hakan]

Thomas.
No hurry at all. You just tell me when I can support you. I raised this the other day because I wanted to test a small routine I made to detect which files containing strings to translate and tactics_pi was a suitable source to test, not aimed to stress.
When you're ready I'll make a new pot-file and potfile.in based on texts to translate in your source. I also have some suggestions to facilitate a secure translation*. All will be a pull request afterwards when needed.
As you say, I saw that most of the -po files in your repository already has translations from dashboard and these will be fine to load into Crowdin so that folks don't have to redo all strings but only those you've created.

Gerhard, thanks a lot but since Thomas have more to do I'll build a fresh pot-file when it's time.

/Håkan

* Like this: A user may have trouble to translate this without creating a mismatch. I think it's better to translate the strings only. This example could be one way.

- dc->DrawText(wxString::Format(_(" Max %.1f since %02d:%02d  Overall Max %.1f Min %.1f "),m_MaxPress,hour,min,m_TotalMaxPress,m_TotalMinPress), m_LeftLegend+3+2+degw, m_TopLineHeight-degh+5);
+ // Single text var to facilitate correct translations:
+  wxString s_Max = _("Max");
+  wxString s_Since = _("since");
+  wxString s_OMax = _("Overall Max");
+  wxString s_Min = _("Min");
+  dc->DrawText(wxString::Format(_T(" %s %.1f %s %02d:%02d  %s %.1f %s %.1f "), s_Max, m_MaxPress, s_Since, hour, min, s_OMax, m_TotalMaxPress, s_Min, m_TotalMinPress), m_LeftLegend + 3 + 2 + degw, m_TopLineHeight - degh + 5);

There are two similar coding.

[Hakan]

Thomas - all
Based on now existing source I made a pull request of a new pot file and others.

The same POT file as well as po-files based on that are now also uploaded to Crowdin /tactics_pi and all languages would be ready for translations.
I hope everything went well, if not please note here.
Happy translations.

Håkan