Some More Copyright Things (based on Debian Inclusion Reject)

[antonm]

Hello All.

We got a reject in debian inclusion because there are still some files with no license specified. This is based on 2.5.0 tarball. Note that we strip some non relevant things from original one, like Windows DLL, but do not add anything.

opencpn-2.5.0/plugins/demo_pi_sample/src/nmea0183/hdt.hpp
opencpn-2.5.0/plugins/dashboard_pi/src/nmea0183/hdt.hpp
opencpn-2.5.0/src/nmea0183/hdt.hpp

License is "You can use it any way you like.". Not sure if it will work. Again the word "use" does not clearly state that it provide a right to distribute and modify. There are contacts in that files.

opencpn-2.5.0/plugins/grib_pi/src/icons.sh
opencpn-2.5.0/plugins/dashboard_pi/src/icons.sh
opencpn-2.5.0/src/bitmaps/13xX_svg_src/create_all_13xX.sh
opencpn-2.5.0/src/bitmaps/16x16_svg_src/create_all_16x16.sh
opencpn-2.5.0/src/bitmaps/optimize_png.sh
opencpn-2.5.0/src/bitmaps/other_svg_src/create_opencpn_main_icon.sh
opencpn-2.5.0/src/bitmaps/other_svg_src/create_ship.sh
opencpn-2.5.0/src/bitmaps/32x32_svg_src/cursor/create_all_32x32.sh
opencpn-2.5.0/src/bitmaps/32x32_svg_src/ribbon/create_all_32x32.sh
opencpn-2.5.0/src/bitmaps/create_all.sh
opencpn-2.5.0/src/bitmaps/28x28_svg_src/create_all_28x28.sh

Do not list any copyright. Looks like those are not needed for building and can be stripped? But maybe it would be good to add copyright header so we have our traball in sync as much as possible.

opencpn-2.5.0/src/garmin/jeeps/gpsport.h
opencpn-2.5.0/src/garmin/jeeps/garmin_gps.h
opencpn-2.5.0/src/garmin/jeeps/gpscom.h
opencpn-2.5.0/src/garmin/jeeps/gpsproj.h
opencpn-2.5.0/src/garmin/jeeps/gpsfmt.h
opencpn-2.5.0/src/garmin/jeeps/gpsprot.h
opencpn-2.5.0/src/garmin/jeeps/gpsinput.h
opencpn-2.5.0/src/garmin/jeeps/gpsapp.h
opencpn-2.5.0/src/garmin/jeeps/gpssend.h
opencpn-2.5.0/src/garmin/jeeps/gpsmem.h
opencpn-2.5.0/src/garmin/jeeps/gpsserial.h
opencpn-2.5.0/src/garmin/jeeps/gpsmath.h
opencpn-2.5.0/src/garmin/jeeps/gpsread.h
opencpn-2.5.0/src/garmin/jeeps/gpsutil.h
opencpn-2.5.0/src/garmin/jeeps/gpsrqst.h
opencpn-2.5.0/src/garmin/jeeps/gpsdatum.h
opencpn-2.5.0/src/mygdal/cpl_config.h

Do not have any copyright/license headers at all.

opencpn-2.5.0/src/tinystr.cpp
opencpn-2.5.0/include/triangulate.h
opencpn-2.5.0/include/tinystr.h

This file has zlib/libpng license header but do not have any copyright indication. Not sure if it is ok yet.

opencpn-2.5.0/plugins/grib_pi/src/icons.cpp
opencpn-2.5.0/plugins/grib_pi/src/icons.h
opencpn-2.5.0/plugins/dashboard_pi/src/icons.cpp
opencpn-2.5.0/plugins/dashboard_pi/src/icons.h
opencpn-2.5.0/src/bitmaps/icons.cpp
opencpn-2.5.0/src/bitmaps/png2wx.pl
opencpn-2.5.0/src/bitmaps/icons.h

Generated files. Do not have copyright headers. Not sure how to deal with them yet.

Also a lot of files has incorrect FSF address "59 Temple Place - Suite 330, Boston, MA 02111-1307, USA." the correct one will be "51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA." see http://www.gnu.org/licenses/old-licenses/gpl-2.0.html#SEC4 Not sure about how critical it is (probably not that). Can potentially be corrected by the script.

I use licensecheck program from devscripts package (Debian,Ubuntu):

licensecheck -r opencpn-2.5.0/

This is just a first recup from findings. I may have missed something.

[antonm]

Originally Posted by antonm

opencpn-2.5.0/plugins/demo_pi_sample/src/nmea0183/hdt.hpp
opencpn-2.5.0/plugins/dashboard_pi/src/nmea0183/hdt.hpp
opencpn-2.5.0/src/nmea0183/hdt.hpp

License is "You can use it any way you like.". Not sure if it will work. Again the word "use" does not clearly state that it provide a right to distribute and modify. There are contacts in that files.

For this one we already contacted the author as it is the part of nmea0183. We just need to add the following header to hdt.hpp like it is done for other files:

* S Blackburn's original source license: *
* "You can use it any way you like." *
* More recent (2010) license statement: *
* "It is BSD license, do with it what you will" *

[cagney]

antonm

This will take some time to sort out, as Dave has no WiFi connection for about another month. Gone fishing.....


Thomas

[nohal]

Anton...
Thanks for the info.
Created FS#732 : License note fixes to satisfy debian with patch containing proposed fixes. Will have to wait for Dave's approval, but probable should not be too problematic....

Originally Posted by antonm

opencpn-2.5.0/plugins/demo_pi_sample/src/nmea0183/hdt.hpp
opencpn-2.5.0/plugins/dashboard_pi/src/nmea0183/hdt.hpp
opencpn-2.5.0/src/nmea0183/hdt.hpp

License is "You can use it any way you like.". Not sure if it will work. Again the word "use" does not clearly state that it provide a right to distribute and modify. There are contacts in that files.

Updated to the same copyright notice the respective cpp file has.

opencpn-2.5.0/plugins/grib_pi/src/icons.sh
opencpn-2.5.0/plugins/dashboard_pi/src/icons.sh
opencpn-2.5.0/src/bitmaps/13xX_svg_src/create_all_13xX.sh
opencpn-2.5.0/src/bitmaps/16x16_svg_src/create_all_16x16.sh
opencpn-2.5.0/src/bitmaps/optimize_png.sh
opencpn-2.5.0/src/bitmaps/other_svg_src/create_opencpn_main_icon.sh
opencpn-2.5.0/src/bitmaps/other_svg_src/create_ship.sh
opencpn-2.5.0/src/bitmaps/32x32_svg_src/cursor/create_all_32x32.sh
opencpn-2.5.0/src/bitmaps/32x32_svg_src/ribbon/create_all_32x32.sh
opencpn-2.5.0/src/bitmaps/create_all.sh
opencpn-2.5.0/src/bitmaps/28x28_svg_src/create_all_28x28.sh

Do not list any copyright. Looks like those are not needed for building and can be stripped? But maybe it would be good to add copyright header so we have our traball in sync as much as possible.

Added GPLv2 copyright notices - funny to insert 20 lines of a copyright notice to a one line long helper script If the same should have been done to all the SVG drawings and generated PNG and XPM images, I would probably prefer stripping this whole thing out of the tarball as it is really not needed for the build...

opencpn-2.5.0/src/garmin/jeeps/gpsport.h
opencpn-2.5.0/src/garmin/jeeps/garmin_gps.h
opencpn-2.5.0/src/garmin/jeeps/gpscom.h
opencpn-2.5.0/src/garmin/jeeps/gpsproj.h
opencpn-2.5.0/src/garmin/jeeps/gpsfmt.h
opencpn-2.5.0/src/garmin/jeeps/gpsprot.h
opencpn-2.5.0/src/garmin/jeeps/gpsinput.h
opencpn-2.5.0/src/garmin/jeeps/gpsapp.h
opencpn-2.5.0/src/garmin/jeeps/gpssend.h
opencpn-2.5.0/src/garmin/jeeps/gpsmem.h
opencpn-2.5.0/src/garmin/jeeps/gpsserial.h
opencpn-2.5.0/src/garmin/jeeps/gpsmath.h
opencpn-2.5.0/src/garmin/jeeps/gpsread.h
opencpn-2.5.0/src/garmin/jeeps/gpsutil.h
opencpn-2.5.0/src/garmin/jeeps/gpsrqst.h
opencpn-2.5.0/src/garmin/jeeps/gpsdatum.h
opencpn-2.5.0/src/mygdal/cpl_config.h

Do not have any copyright/license headers at all.

Added copies of the licensing header from the respective .c files

opencpn-2.5.0/src/tinystr.cpp
opencpn-2.5.0/include/tinystr.h

Part of TinyXML, which if I remember well had to be removed due to debian's no code redundancy with library packages policy. These files should also be removed.

opencpn-2.5.0/include/triangulate.h
opencpn-2.5.0/src/bitmaps/png2wx.pl

Public domain code, stated in both files - is there a way to make the PD statement compliant with debian? png2wx.pl can be dropped if needed.

Also a lot of files has incorrect FSF address "59 Temple Place - Suite 330, Boston, MA 02111-1307, USA." the correct one will be "51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA." see http://www.gnu.org/licenses/old-licenses/gpl-2.0.html#SEC4 Not sure about how critical it is (probably not that). Can potentially be corrected by the script.

I've done a quick search/replace, maybe something is still left somewhere

Pavel

[antonm]

Originally Posted by nohal

Updated to the same copyright notice the respective cpp file has.
Added GPLv2 copyright notices - funny to insert 20 lines of a copyright notice to a one line long helper script If the same should have been done to all the SVG drawings and generated PNG and XPM images, I would probably prefer stripping this whole thing out of the tarball as it is really not needed for the build...

In theory we can strip out anything that is not needed for Linux build. But I personaly think that having copyright headers on all files with any code inside is a helpful thing.

Originally Posted by nohal

Public domain code, stated in both files - is there a way to make the PD statement compliant with debian? png2wx.pl can be dropped if needed.

I checked them now and those look to be a bug of licensecheck and I also them missed it somehow when did manual check. I think those files are already compilant. Will just document them in our package copyright file.

[SethDart]

opencpn-2.5.0/plugins/grib_pi/src/icons.sh
opencpn-2.5.0/plugins/dashboard_pi/src/icons.sh
opencpn-2.5.0/src/bitmaps/13xX_svg_src/create_all_13xX.sh
opencpn-2.5.0/src/bitmaps/16x16_svg_src/create_all_16x16.sh
opencpn-2.5.0/src/bitmaps/optimize_png.sh
opencpn-2.5.0/src/bitmaps/other_svg_src/create_opencpn_main_icon.sh
opencpn-2.5.0/src/bitmaps/other_svg_src/create_ship.sh
opencpn-2.5.0/src/bitmaps/32x32_svg_src/cursor/create_all_32x32.sh
opencpn-2.5.0/src/bitmaps/32x32_svg_src/ribbon/create_all_32x32.sh
opencpn-2.5.0/src/bitmaps/create_all.sh
opencpn-2.5.0/src/bitmaps/28x28_svg_src/create_all_28x28.sh

I rewrote these in sept. 2010 with a big patch to cleanup the mess in src/bitmaps/ GPLv2 or later as all my contribs. Initial work from Manimaul IIRC

The best would be to remove all bitmaps and create them with these scripts when packaging. This would save som space in the archive. Unfortunately, that'd require more dependency (listed in src/bitmaps/README.TXT)

[SethDart]

opencpn-2.5.0/src/tinystr.cpp
opencpn-2.5.0/include/tinystr.h

These should simply be removed. They're only needed it tinyxml is built without STL support. It must be removed from include/gpxdocument.h first (not required, already handled by #include <tinyxml.h>).

PS: I'm trying to get OpenCPN included in Fedora so I'm facing similar problems ;-)

[nohal]

J-E...
Thanks for the clarification for the scripts, will modify the copyright info to give the credits to you
If you feel like you want to, you can use https://github.com/nohal/OpenCPN/tree/debian_lic and post any mods there - this patch is going to be huge, so it would probably be more convenient to bake it on github than manually...

Pavel

[HamishB]

In FS#732 Dave wrote:

Implemented for next Beta.

Also, deleted tinystr.cpp and tinystr.h as unused.


Dave

As for OpenCPN 2.5.0 in Debian, IMHO the way to do is to augment the debian/copyright file, then shrink it again in for the next release. Massive patch sets are not really needed here and are a PITA to maintain.

Frankie indicated that he's happy to re-upload the package for submission whenever we are ready. Anton: is the copyright file up to scratch now or is there more to do?

aka is there anything blocking us moving on with this?


Hamish
(away in a fjord for the next week)

[bdbcat]

All...

The 2.6 Beta currently on sourceforge repo should be clean as regards license headers. The giant patch was applied, as best I could interpret the requirements.

We are planning a formal release in late May. Now would be an excellent time to come to resolution on any open license issues in the code base.

Who knows the status, and can evaluate the current (2.6 Beta) code base?

Thanks
Dave

[HamishB]

Originally Posted by HamishB

Frankie indicated that he's happy to re-upload the package for submission whenever we are ready. Anton: is the copyright file up to scratch now or is there more to do?

ping?


Since it has already been reviewed to death by the reviewers, I would rather upload 2.5.0 -right now- with a longish debian/copyright file and not wait for 2.6.0 where things will be cleaner in the file headers (i.e. before the packaging cycle maturity clock gets reset to 0). The 2.5 package is otherwise good to go, let's get it in :-)


thanks,
Hamish

[bdbcat]

HamishB...

Sounds good. How do we proceed?

Dave

[HamishB]

Originally Posted by bdbcat

How do we proceed?

Since the last submission round Anton did a lot of work improving the 2.5.0 debian/copyright file so that it made note of the file header comment changes that went into the 2.6.dev code.

Before resubmitting to the Debian ftpmasters I'd like to know if he felt that the job was complete, or if there are some more TODOs which we could help with.


Hamish

[HamishB]

Hi,

I've been working on this a bit in DebianGIS svn, and I think we're fairly close to having every file in 2.5.0 audited & documented. i.e. if the file itself doesn't list the copyright then the debian/copyright file does (rather than backporting the large header patch).

One remaining question -- these files are auto-generated by png2wx.pl:

./plugins/grib_pi/src/icons.cpp
./plugins/grib_pi/src/icons.h
./src/bitmaps/icons.cpp
./src/bitmaps/icons.h

and so since they have no author are in no-man's land and have no copyright statement.

Dave, is it fair to say that these files are covered by the project's copyright? (i.e. you assert GPLv2+ over them)


thanks,
Hamish

[bdbcat]

Hamish...

You are correct. The"source" svg files->png files->icons.cpp/icons.h are all included in OpenCPN's copyright, and covered by GPLv2+.
We could, of course, modify png2wx.pl to prepend a GPL header. Would this be useful?

I appreciate all the fussing around with this that you have done, and are doing.

Is it time to submit 3.0 to the "Spanish inquisition"?

Dave