Cruisers Forum
 


Join CruisersForum Today

Reply
 
Thread Tools Rate Thread Display Modes
Old 01-05-2014, 08:37   #1
Marine Service Provider
 
bdbcat's Avatar

Join Date: Mar 2008
Posts: 4,883
Sean's Optimum Branch Merge

Ahoy testers...

We have started the process of merging Sean's excellent optimization work into the OCPN github master branch. This will be an incremental process, pulling in small and not-so-small diffs individually so that we may manage regression problems cleanly. We plan to get most of Sean's work integrated and stabilized before the next Beta.

The first diff, in place now, applies OpenGL texture-based text rendering to vector charts.

Those who have source build capabilities are encouraged to clone/pull the latest github master branch, build it, and beat it with a stick.

I'll try to keep this thread updated with our progress reports. Please report build/run problems here, as well.

Thanks
Dave
__________________

__________________
bdbcat is offline   Reply With Quote
Old 01-05-2014, 10:06   #2
Registered User

Join Date: Nov 2012
Location: Orust Sweden
Boat: Najad 34
Posts: 1,967
Re: Sean's Optimum branch merge

Dave..
On Win32-XP&7, CM93, VC++:
Nice built w/o warnings nor errors.
Runs as expected. If texts was the issue I haven't seen anything to comment. All text are nicely following zoom and movements. (Font colours are still black when using OpenGL irrespective of font settings but I suppose this was not an issue?)

I've also tested running br24radar_pi ver. 40412 w/o comments.
Håkan
__________________

__________________
Hakan is offline   Reply With Quote
Old 01-05-2014, 10:33   #3
Registered User

Join Date: Jul 2010
Location: Monastir, Tunisia
Boat: Amel Sharki
Posts: 1,774
Re: Sean's Optimum branch merge

Dave,

I have announced that your diffs "Updates to PlugIn chart interface, especially S57 extended sectors and NATSUR attributes display." from April, 23. crashed here. Have you ever checked this?

See:
OpenCPN Beta Version 3.3.1418

Gerhard
__________________
CarCode is online now   Reply With Quote
Old 01-05-2014, 10:46   #4
Registered User

Join Date: Dec 2005
Location: WNA
Boat: Dufour 35
Posts: 3,247
Re: Sean's Optimum branch merge

I have the same experience as Håkan. No problems.

Thomas
__________________
cagney is offline   Reply With Quote
Old 01-05-2014, 13:40   #5
Registered User
 
rooiedirk's Avatar

Join Date: Aug 2010
Location: Netherlands
Boat: Oneoff
Posts: 300
Re: Sean's Optimum branch merge

Compiles withouth errors but a view warnings. I left out the warnings for dashboard and grib plugin.
Code:
#/OpenCPN/src/tri.c: In function 'do_triangulate_polygon':
#/OpenCPN/src/tri.c:689:7: warning: this decimal constant is unsigned only in ISO C90 [enabled by default]
#/OpenCPN/src/wxJSON/jsonval.cpp: In member function 'wxJSONRefData* wxJSONValue::COW()':
#/OpenCPN/src/wxJSON/jsonval.cpp:3057:20: warning: variable 'data' set but not used [-Wunused-but-set-variable]
#/OpenCPN/src/wxJSON/jsonval.cpp: At global scope:
#/OpenCPN/src/wxJSON/jsonval.cpp:35:22: warning: 'traceMask' defined but not used [-Wunused-variable]
#/OpenCPN/src/wxJSON/jsonval.cpp:36:22: warning: 'compareTraceMask' defined but not used [-Wunused-variable]
#/OpenCPN/src/wxJSON/jsonval.cpp:37:22: warning: 'cowTraceMask' defined but not used [-Wunused-variable]
First impression, seem to run OK
Dirk
__________________
rooiedirk is offline   Reply With Quote
Old 01-05-2014, 17:58   #6
Marine Service Provider
 
bdbcat's Avatar

Join Date: Mar 2008
Posts: 4,883
Re: Sean's Optimum branch merge

Gerhard....

Is current github still crashing on Mac as mentioned before?
Works fine for me on Lion, wx2.95

Any more info? Screen shot of crash report?

Dave
__________________
bdbcat is offline   Reply With Quote
Old 02-05-2014, 02:05   #7
Registered User

Join Date: Jul 2010
Location: Monastir, Tunisia
Boat: Amel Sharki
Posts: 1,774
Re: Sean's Optimum branch merge

Quote:
Originally Posted by bdbcat View Post
Gerhard....

Is current github still crashing on Mac as mentioned before?
Works fine for me on Lion, wx2.95

Any more info? Screen shot of crash report?

Dave
I will check further.
The mentioned diffs however has leaded to an infinitiv loop while starting OpenCPN after compiling with no errors or warnings. So I left out this diff.

The last Sean's Optimum diffs are OK however with OS X Mavericks, Xcode 5.1 and wxWidgets 3.1.

Gerhard
__________________
CarCode is online now   Reply With Quote
Old 05-05-2014, 13:23   #8
Registered User

Join Date: Sep 2009
Location: Angers - France
Boat: Beneteau First 29 Ptizef
Posts: 743
Re: Sean's Optimum branch merge

Hi all
New git built and run as expected
Starting tests .. chart texts OK, no visible difference.
But what the does mean "Enabled Responsive graphic Interface" ?
It result in very big menu bar icons and dialog font on my Vista Notebook, that I can't change.
Jean Pierre
__________________
Ptizef is online now   Reply With Quote
Old 05-05-2014, 20:36   #9
Marine Service Provider
 
bdbcat's Avatar

Join Date: Mar 2008
Posts: 4,883
Re: Sean's Optimum branch merge

jp...

"Responsive" option is incompletely implemented. What it will eventually do is cause icons/text to conform to an absolute minimum size, so that when used on a high definition tablet screen, say 8", the icons and other GUI elements will not be too small to touch cleanly, or read clearly.

As I say, it is incomplete in github now. This is not ready for Beta yet.

Thanks
Dave
__________________
bdbcat is offline   Reply With Quote
Old 06-05-2014, 07:27   #10
Registered User

Join Date: Sep 2009
Location: Angers - France
Boat: Beneteau First 29 Ptizef
Posts: 743
Re: Sean's Optimum branch merge

Thanks Dave
understood
JP
__________________
Ptizef is online now   Reply With Quote
Old 10-05-2014, 10:34   #11
Marine Service Provider
 
bdbcat's Avatar

Join Date: Mar 2008
Posts: 4,883
Re: Sean's Optimum branch merge

Hi folks...

The next stage in OCPN Optimum branch merge is now available.

Changes:
  • remove unused texture from ocpndc
  • improve performance as well as appearance of thick line rendering
  • variable step count ellipse, use faster float since double is not needed, cleanup unused code, and a few rendering corrections
  • Fix introduced bug I missed do to merging.
  • correct end cap rendering logic
  • corrections to drawing thick lines

The latest merge may be pulled from github master now.
It will be called 3.3.1710

Thanks Sean

Dave
__________________
bdbcat is offline   Reply With Quote
Old 10-05-2014, 21:26   #12
Registered User
 
boat_alexandra's Avatar

Join Date: Aug 2009
Location: Masachusetts
Boat: bristol 27
Posts: 2,803
Re: Sean's Optimum branch merge

This is going well. It gives me a chance to re-review things, and then dave makes important fixes as well which were not obvious to me. The next change (smooth panning improvements) is awaiting merging.

A possible point of discussion:

I added the keys '[' ]' '|' for setting arbitrary rotations. I personally like this feature so I can set arbitrary angles rather than relying on the course-up algorithm. This allows south up, route-up, and general course-up without changing the angle all the time.

It greatly helps in narrowing down many rotation-related bugs (many which are fixed in the optimum branch), but many users may find it confusing. What do you think? Should it be enabled by a configuration option only? Apparently it is difficult on some foreign keyboards. I believe user rotation control is needed for testing purposes to verify course up works for all angles, but it is also an important feature.
__________________
boat_alexandra is offline   Reply With Quote
Old 11-05-2014, 02:08   #13
Registered User

Join Date: Nov 2012
Location: Orust Sweden
Boat: Najad 34
Posts: 1,967
Re: Sean's Optimum branch merge

Quote:
Originally Posted by boat_alexandra View Post
............Apparently it is difficult on some foreign keyboards. .............
Sean... There must be another key board independent way to interpret key strokes? I think the problem in OCPN is that I, using the Swedish board, have to press the Alt-key to get the "|" sign and you read the "Alt-code". But that's not a problem for any word processor or when I write here?
__________________
Hakan is offline   Reply With Quote
Old 11-05-2014, 02:25   #14
Registered User
 
boat_alexandra's Avatar

Join Date: Aug 2009
Location: Masachusetts
Boat: bristol 27
Posts: 2,803
Re: Sean's Optimum branch merge

Quote:
Originally Posted by Hakan View Post
Sean... There must be another key board independent way to interpret key strokes? I think the problem in OCPN is that I, using the Swedish board, have to press the Alt-key to get the "|" sign and you read the "Alt-code". But that's not a problem for any word processor or when I write here?
Yes, there is, but the problem is I do not know the magic number to use. See chcanv.cpp line 1899. If you can set a breakpoint there, then press what key, then look at the value of key_char then you could provide the keycodes needed.
__________________
boat_alexandra is offline   Reply With Quote
Old 11-05-2014, 06:27   #15
Registered User
 
AISEAG's Avatar

Join Date: May 2012
Location: Dahouet (Brittany)
Boat: BENETEAU
Posts: 407
Re: Sean's Optimum branch merge

Quote:
Originally Posted by bdbcat View Post
Hi folks...

.......
The latest merge may be pulled from github master now.
It will be called 3.3.1710

......

Dave
Hi Dave

Is this version will be made public in the download page ?

Serge
__________________

__________________
AISEAG is offline   Reply With Quote
Reply

Thread Tools
Display Modes Rate This Thread
Rate This Thread:

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are Off
Pingbacks are Off
Refbacks are Off


Similar Threads
Thread Thread Starter Forum Replies Last Post
Two-pole branch protection witzgall Electrical: Batteries, Generators & Solar 12 19-11-2013 09:53
Optimum Dagger Board Use solarbri Multihull Sailboats 15 03-03-2013 14:56
Linux link error on master branch teotwawki OpenCPN 4 19-10-2012 07:13
VHF antenna optimum height bobalpep Marine Electronics 13 04-03-2009 10:38
Marine Accident Investigation Branch (UK Govt) David_Old_Jersey Health, Safety & Related Gear 3 05-02-2007 16:30



Copyright 2002- Social Knowledge, LLC All Rights Reserved.

All times are GMT -7. The time now is 14:47.


Google+
Powered by vBulletin® Version 3.8.8 Beta 1
Copyright ©2000 - 2017, vBulletin Solutions, Inc.
Social Knowledge Networks
Powered by vBulletin® Version 3.8.8 Beta 1
Copyright ©2000 - 2017, vBulletin Solutions, Inc.

ShowCase vBulletin Plugins by Drive Thru Online, Inc.