Plugin: DashBoard

[nohal]

Gunther,
not worth posting a patch - just change

SET(wxWidgets_USE_LIBS base core net xml html adv)

to

SET(wxWidgets_USE_LIBS base core net xml html adv aui)

in plugins\dashboard_pi\src\CMakeLists.txt - line 61

I get some hangs and crashes - will report on them later today.

Pavel

[Netsurfer]

Hi Pavel,

thanks for the help - worked!

@Jean-Eudes
For me OCPN also crashes as soon as I try to change/ add instruments. And none of the three deafult one's is visible.

Undocking and docking the dashboard to the left or right works!
I can't tell you how happy I am with this solution!!!
Really great - incredible!!!

And also the config tab looks pretty well (though changing anything else than the width currently causes OCPN to crash).

The toolbar button is awesome ...
Just a remark: IMHO the button should show its state (like the 'A+' text button) as it is like a on/off switch.

Congratulations - fantastic job!
And for me already close to perfect by now.

Thanks,
Gunther

PS: I am sure there are lots of users out there who will be very satisfied, too.

[SethDart]

Even easier to test: here are 2 files, .deb for debian/ubuntu and .rpm for fedora/centos built on each platform respectively. These files are for testing and will be removed as soon as next beta comes out.

http://opencpn.org/sites/default/fil...018-1_i386.deb

http://opencpn.org/sites/default/fil...018-1_i386.rpm

PS: I noticed the report about failing to build on windows. Thanks for the patch. Strangely it did not occured on Linux.

Thanks

[nohal]

Jean-Eudes,
attached is a trace of a crash in the Dashboard config on Windows on either selection from the list of instruments or after adding a new instrument.
If you need any more info, let me know.

Pavel

[SethDart]

Originally Posted by nohal

Jean-Eudes,
attached is a trace of a crash in the Dashboard config on Windows on either selection from the list of instruments or after adding a new instrument.
If you need any more info, let me know.

Pavel

I can't see what's wrong there... Can you try to add parenthesis?

diff --git a/plugins/dashboard_pi/src/dashboard_pi.cpp b/plugins/dashboard_pi/src/dashboard_pi.cpp
index c46aeba..b85ce6a 100644
--- a/plugins/dashboard_pi/src/dashboard_pi.cpp
+++ b/plugins/dashboard_pi/src/dashboard_pi.cpp
@@ -828,7 +828,7 @@ void dashboard_pi::UpdateButtonsState()
       m_pButtonDelete->Enable(enable);
       m_pButtonEdit->Enable(false); // TODO: Properties
       m_pButtonUp->Enable(item > 0);
-      m_pButtonDown->Enable(item != -1 && item < m_pListCtrlInstruments->GetItemCount()-1);
+      m_pButtonDown->Enable((item != -1) && (item < m_pListCtrlInstruments->GetItemCount()-1));
 }
 
 void dashboard_pi::OnInstrumentAdd(wxCommandEvent& event)

And this eventually, to see if it's the GetItemCount that fail?

diff --git a/plugins/dashboard_pi/src/dashboard_pi.cpp b/plugins/dashboard_pi/src/dashboard_pi.cpp
index c46aeba..7c537b7 100644
--- a/plugins/dashboard_pi/src/dashboard_pi.cpp
+++ b/plugins/dashboard_pi/src/dashboard_pi.cpp
@@ -828,7 +828,8 @@ void dashboard_pi::UpdateButtonsState()
       m_pButtonDelete->Enable(enable);
       m_pButtonEdit->Enable(false); // TODO: Properties
       m_pButtonUp->Enable(item > 0);
-      m_pButtonDown->Enable(item != -1 && item < m_pListCtrlInstruments->GetItemCount()-1);
+      long cnt = m_pListCtrlInstruments->GetItemCount();
+      m_pButtonDown->Enable((item != -1) && (item < cnt-1));
 }
 
 void dashboard_pi::OnInstrumentAdd(wxCommandEvent& event)

Can you also track variables to see if m_pButtonDown and m_pListCtrlInstruments are correctly defined. I don't have build system on Windows OS but will try to test.

[nohal]

Looks like the problem is m_pListCtrlInstruments as m_pListCtrlInstruments->GetItemCount(); returns bogus (-842150656 in the test run)
Perhaps related to no instruments being shown as Gunther reported earlier?
I will try to trace it a bit more later, now I have to catch the train...

Pavel

[nohal]

Originally Posted by nohal

I will try to trace it a bit more later

Memory corruption?
Have a look at the two screenshots: 1st one is at the end of SetupToolboxPanel() while Toolbox is open, the 2nd when OnInstrumentSelected() is caled two clicks later...
Tracing where the corruption actually happened is still a bit out of my reach

Pavel

[SethDart]

can you try this patch?

diff --git a/plugins/dashboard_pi/src/dashboard_pi.cpp b/plugins/dashboard_pi/src/dashboard_pi.cpp
index c46aeba..57e2691 100644
--- a/plugins/dashboard_pi/src/dashboard_pi.cpp
+++ b/plugins/dashboard_pi/src/dashboard_pi.cpp
@@ -142,9 +142,8 @@ wxString getInstrumentCaption(unsigned int id)
       return _T("");
 }
 
-wxListItem getListItemForInstrument(unsigned int id)
+void getListItemForInstrument(wxListItem &item, unsigned int id)
 {
-      wxListItem item;
       item.SetData(id);
       item.SetText(getInstrumentCaption(id));
       switch (id)
@@ -175,7 +174,6 @@ wxListItem getListItemForInstrument(unsigned int id)
             item.SetImage(1);
             break;
       }
-      return item;
 }
 
 //---------------------------------------------------------------------------------------------------------
@@ -778,7 +776,8 @@ void dashboard_pi::SetupToolboxPanel(int page_sel, wxNotebook* pnotebook)
 
       for (size_t i = 0; i < m_aInstrumentList.GetCount(); i++)
       {
-            wxListItem item = getListItemForInstrument(m_aInstrumentList.Item(i));
+            wxListItem item;
+            getListItemForInstrument(item, m_aInstrumentList.Item(i));
             item.SetId(m_pListCtrlInstruments->GetItemCount());
             m_pListCtrlInstruments->InsertItem(item);
       }
@@ -837,7 +836,8 @@ void dashboard_pi::OnInstrumentAdd(wxCommandEvent& event)
 
       if (pdlg.ShowModal() == wxID_OK)
       {
-            wxListItem item = getListItemForInstrument(pdlg.GetInstrumentAdded());
+            wxListItem item;
+            getListItemForInstrument(item, pdlg.GetInstrumentAdded());
             item.SetId(m_pListCtrlInstruments->GetItemCount());
             m_pListCtrlInstruments->InsertItem(item);
             m_pListCtrlInstruments->SetColumnWidth(0, wxLIST_AUTOSIZE);
@@ -1020,7 +1020,8 @@ AddInstrumentDlg::AddInstrumentDlg(wxWindow *pparent, wxWindowID id)
 
       for (unsigned int i = ID_DBP_I_POS; i <= ID_DBP_D_GPS; i++)
       {
-            wxListItem item = getListItemForInstrument(i);
+            wxListItem item;
+            getListItemForInstrument(item, i);
             item.SetId(i);
             m_pListCtrlInstruments->InsertItem(item);
       }

I'll try to debug this in a few hours once I've a Windows build system ready.

Thanks

[nohal]

Same result
It looks to me like the problem actually isn't in the plug-in itself as it does nothing between the instantiation of the config page and handling the button click event when the crash happens.

Pavel

[nohal]

The problem is fixed in git 2.2.1024
There is just a small issue left - the instrument you move up or down in the toolbox looses it's icon and caption.

Pavel

[cagney]

Originally Posted by nohal

The problem is fixed in git 2.2.1024
There is just a small issue left - the instrument you move up or down in the toolbox looses it's icon and caption.

Pavel

Very nice. Good job SethDart!

I'm just compiling 1024. On my 64 bit ubuntu 10.4, the issue nohal mention above with the toolbox, is a non issue. In other words it works!
1024 will soon be available for download at opencpn.org.
Thomas

[Netsurfer]

Pavel,

Originally Posted by nohal

The problem is fixed in git 2.2.1024
There is just a small issue left - the instrument you move up or down in the toolbox looses it's icon and caption.

cannot confirm.

v1024 causes a lot of trouble for me. Cannot even activate the GRIB and Dashboard plugin, as OCPN crashes immediately when I click on OK. Celst is the only one which can be enabled but crashes also when trying to display.

BTW: Do I have to update to wxWidgets 2.9.1 or may I still use 2.8.11?

Gunther

[cagney]

Netsurfer

BTW: Do I have to update to wxWidgets 2.9.1 or may I still use 2.8.11?

Stay with the 2.8.x version. OpenCPN assumes this. Apparently it is a major undertaking to port OpenCPN to the 2.9.x or later, that is coming up in the future...

Thomas

[Netsurfer]

Originally Posted by cagney

Stay with the 2.8.x version.

OK, thanks Thomas.

Gunther

[cagney]

Further testing reveals a problem with 1024.

When coming back to OpenCPN after while, having used other applications in between, the screen is all grayed out an OpenCPN is hung. See the backtrace.

Thomas