Cruisers Forum
 


Join CruisersForum Today

Reply
 
Thread Tools Rate Thread Display Modes
Old 29-06-2011, 05:33   #16
Registered User

Join Date: Mar 2010
Location: Normandy, France
Boat: Flush Poker, 8.25m (Point Barre)
Posts: 335
Re: OpenCPN Version 2.4 Beta Build 628

Thanks Hamish & Thomas.

And I guess for Ubuntu 32bits there's only /usr/lib. Maybe lib32 as a softlink to /usr/lib. What a clever idea! That means /usr/lib can contains either 32 or 64 bits depending on your local arch.

For Fedora /usr/lib is always 32 bits (probably noarch as well), /usr/lib64... 64 bits. Same for /usr/local

I've just created a patch with a new option to handle this. I'll send it to flyspray and ping Dave.

Thanks.
__________________

__________________
SethDart is offline   Reply With Quote
Old 29-06-2011, 05:38   #17
Registered User
 
HamishB's Avatar

Join Date: Jan 2010
Location: New Zealand
Posts: 286
Re: OpenCPN Version 2.4 Beta Build 628

Quote:
Originally Posted by SethDart View Post
And I guess for Ubuntu 32bits there's only /usr/lib. Maybe lib32 as a softlink to /usr/lib.
ubuntu 10.04 32bit (i686) has only /usr/lib. No symlink or lib32.


Hamish
__________________

__________________
HamishB is offline   Reply With Quote
Old 29-06-2011, 06:05   #18
Registered User

Join Date: Mar 2010
Location: Normandy, France
Boat: Flush Poker, 8.25m (Point Barre)
Posts: 335
Re: OpenCPN Version 2.4 Beta Build 628

Quote:
Originally Posted by HamishB View Post
I notice a few stray executable bits remain in 628:
README
plugins/demo_pi_sample/src/nmea0183/
plugins/dashboard_pi/src/nmea0183/
What do you mean? Each plugin uses its own codebase, including this nmea0183 library. Even if named the same, it's different between core OpenCPN and each plugin. For example the dashboard plugin handle more sentences than core OpenCPN, so it's not a common library. I don't know if there exists a generic libnmea0183 that could be included instead of this local copy ; but if there was, we must ensure all the required sentences are handled properly.

Quote:
Originally Posted by HamishB View Post
I'd like to have the build use the system's libtinyxml instead of the embedded copy. As there is no /usr/share/cmake-2.8/Modules/FindTinyXML.cmake to make things easy, and I'm not a cmake expert, I'm a bit stuck. any ideas on how to do that?
This one looks fine:
FindTinyXML.cmake in trunk/cmake

The same was done for bzip2 in this commit, you can take it for reference. Ping me if you need help.
https://github.com/OpenCPN/OpenCPN/c...91d9d6b#diff-1

Quote:
Originally Posted by HamishB View Post
any ideas on how to enable cmake's parallel build? (whatever the equivalent of `make -j4` is)
You can use `make -j4` after running the initial `cmake ../`
__________________
SethDart is offline   Reply With Quote
Old 29-06-2011, 07:29   #19
Registered User
 
HamishB's Avatar

Join Date: Jan 2010
Location: New Zealand
Posts: 286
Re: OpenCPN Version 2.4 Beta Build 628

Quote:
Originally Posted by HamishB
I notice a few stray executable bits remain in 628:
Quote:
Originally Posted by SethDart View Post
What do you mean?
the UNIX filesystem executable boolean flag is set, indicating that the file is a runnable program. Most of these we cleaned up in the last week, but a few slipped by. see FS#420 : fix file properties in git archive


Quote:
This one looks fine:
FindTinyXML.cmake in trunk/cmake

The same was done for bzip2 in this commit, you can take it for reference. Ping me if you need help.
thanks - that hasn't made it into debian yet and I guess I didn't look far enough.. now where can I stash that file in my local source tree?

CMakeLists.txt:
set(CMAKE_MODULE_PATH ${CMAKE_SOURCE_DIR}/cmake/Modules)

cmake/CMakeLists.txt:
add_subdirectory(Modules)

cmake/Modules/FindTinyXML.cmake

?

Quote:
You can use `make -j4` after running the initial `cmake ../`
well, the thing is I'm not running `cmake ../` directly, the debian build scripts are doing that. You can pass them a '--parallel' flag and if the cmake script has standardized parallel build hooks in it the number of cores will be automatically detected and the gears turn that much faster.
AFAIU it's a standard optional setting which is built into cmake, somewhere.


thanks,
Hamish
__________________
HamishB is offline   Reply With Quote
Old 29-06-2011, 08:12   #20
Registered User

Join Date: Mar 2010
Location: Normandy, France
Boat: Flush Poker, 8.25m (Point Barre)
Posts: 335
Re: OpenCPN Version 2.4 Beta Build 628

Quote:
Originally Posted by HamishB View Post
the UNIX filesystem executable boolean flag is set, indicating that the file is a runnable program. Most of these we cleaned up in the last week, but a few slipped by. see FS#420 : fix file properties in git archive
OK. I guess Dave will solve that. Easy fix.

Quote:
Originally Posted by HamishB View Post
thanks - that hasn't made it into debian yet and I guess I didn't look far enough.. now where can I stash that file in my local source tree?
This is not cmake, it's another software requiring tinyxml and they created the appropriate cmake module. You may file a RFE to cmake to get it included. To use it right now, you can place it in opencpn/ There's already a Findgps.cmake there. That one is used in CMakeLists.txt around line 177

Quote:
Originally Posted by HamishB View Post
well, the thing is I'm not running `cmake ../` directly, the debian build scripts are doing that. You can pass them a '--parallel' flag and if the cmake script has standardized parallel build hooks in it the number of cores will be automatically detected and the gears turn that much faster.
AFAIU it's a standard optional setting which is built into cmake, somewhere.
cmake cannot run in parallel. cmake just create standard Makefile. Then you can compile with make, gmake, whatever... with any option that compiler offer:

Dis you try:
dpkg-buildpackage -j4
or
export MAKEFLAGS=-j4

More info here:
#538826 - cmake: Parallel Builds - Debian Bug report logs
__________________
SethDart is offline   Reply With Quote
Old 29-06-2011, 08:30   #21
Marine Service Provider
 
bdbcat's Avatar

Join Date: Mar 2008
Posts: 4,884
Re: OpenCPN Version 2.4 Beta Build 628

Hello...

Update:

balp:
Sorry, my git config excluded buildosx dir. The required files have been pushed to repo now.

Cagney:
Never saw Nohal patch to WMM plugin. Did not come by private email.

Dave
__________________
bdbcat is offline   Reply With Quote
Old 29-06-2011, 08:41   #22
Marine Service Provider
 
bdbcat's Avatar

Join Date: Mar 2008
Posts: 4,884
Re: OpenCPN Version 2.4 Beta Build 628

HamishB

unix file permissions fixed and pushed.

Thanks
Dave
__________________
bdbcat is offline   Reply With Quote
Old 29-06-2011, 18:21   #23
Senior Cruiser
 
sinbad7's Avatar

Cruisers Forum Supporter

Join Date: Sep 2003
Location: Ubatuba,SP,Brazil (Ex Norway)
Boat: (Ex) Alu. 60' yacht-"Eight Bells"
Posts: 2,717
Images: 57
Send a message via Skype™ to sinbad7
Re: OpenCPN Version 2.4 Beta Build 628

Dan..

The Windows ver. 628 seems to be faulty. I have downloaded it twice but it will not install giving error message as incomplete.

Tore
__________________
"And all I ask is a tall ship and a star to steer her by."
sinbad7 is offline   Reply With Quote
Old 29-06-2011, 18:36   #24
Registered User
 
HappySeagull's Avatar

Join Date: Dec 2010
Location: B.C.,Canada
Boat: 29'
Posts: 2,395
Re: OpenCPN Version 2.4 Beta Build 628

Working great on xp,in my armchair.(sigh)
__________________
HappySeagull is offline   Reply With Quote
Old 29-06-2011, 20:51   #25
Registered User

Join Date: Oct 2008
Location: San Diego, CA
Boat: Beneteau Oceanis 38.1
Posts: 244
Re: OpenCPN Version 2.4 Beta Build 628

Quote:
Originally Posted by sinbad7 View Post
Dan..

The Windows ver. 628 seems to be faulty. I have downloaded it twice but it will not install giving error message as incomplete.

Tore
It's working fine for me on both Win 7 and XP. I have occasional problems with both machines getting into weird states with the install after a slew of betas. Try completely uninstalling from the control (save your config first!) and do a completely clean install of 628. That worked fine for me.
__________________
gjorgensen is offline   Reply With Quote
Old 29-06-2011, 20:53   #26
Registered User
 
HamishB's Avatar

Join Date: Jan 2010
Location: New Zealand
Posts: 286
Re: OpenCPN Version 2.4 Beta Build 628

re. parallel build: nevermind/thanks; I figured it out now. PBKAC.

re. TinyXML + cmake: installed libtinyxml-dev pkg and applied this patch

Code:
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 9d4e9c6..ddedcd7 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -126,6 +126,8 @@ IF(UNIX)
     INCLUDE_DIRECTORIES(${BZIP2_INCLUDE_DIR})
     FIND_PACKAGE(ZLIB REQUIRED)
     INCLUDE_DIRECTORIES(${ZLIB_INCLUDE_DIR})
+    FIND_PACKAGE(TinyXML REQUIRED)
+    INCLUDE_DIRECTORIES(${TINYXML_INCLUDE_DIR})
 ENDIF(UNIX)
 
 # For convenience we define the sources as a variable. You can add 
@@ -224,7 +226,6 @@ SET(HDRS
                 include/pluginmanager.h
                 include/ocpn_plugin.h
                include/tinystr.h
-               include/tinyxml.h
                include/gpxdocument.h
 )
 
@@ -251,9 +252,6 @@ SET(SRCS
                src/about.cpp
                src/ais.cpp
                 src/pluginmanager.cpp
-               src/tinyxml.cpp
-               src/tinyxmlerror.cpp
-               src/tinyxmlparser.cpp
                src/tinystr.cpp
                src/gpxdocument.cpp
     )
@@ -606,6 +604,7 @@ TARGET_LINK_LIBRARIES(${PACKAGE_NAME}
       ${GETTEXT_LIBRARY}
       ${BZIP2_LIBRARIES}
       ${ZLIB_LIBRARY}
+      ${TINYXML_LIBRARIES}
 )
 ENDIF(UNIX)
tinystr.h & .so do not seem to be provided with libtinyxml-dev 2.5.3, so I had to leave those in. I worry that they could get out of sync at some point.


Hamish
__________________
HamishB is offline   Reply With Quote
Old 29-06-2011, 21:41   #27
Marine Service Provider
 
bdbcat's Avatar

Join Date: Mar 2008
Posts: 4,884
Re: OpenCPN Version 2.4 Beta Build 628

HamishB...

Your patch for TinyXML works fine, but.....

Its a bit of a chore to find and get the required packages.
They are not in very many default repos....
They are not in mine.

I found them here for debian:
Ubuntu -- Details of package libtinyxml-dev in maverick
Ubuntu -- Details of package libtinyxml2.5.3 in maverick

Note "Maverick".....

I dunno about rh.


Do we really need to do this?

Although experienced developers can do this stuff, it seems that the packager requirements are way ahead of average users.....

I think that the goal should be for an "average" linux user to be able to say

Code:
$sudo apt-get install opencpn
and have it just do the right thing.

Help me understand...
Dave
__________________
bdbcat is offline   Reply With Quote
Old 29-06-2011, 21:49   #28
Marine Service Provider
 
bdbcat's Avatar

Join Date: Mar 2008
Posts: 4,884
Re: OpenCPN Version 2.4 Beta Build 628

HamishB....

On further testing, the only precompiled packages of TinyXML that I could find crashed for me....

What now?

Dave
__________________
bdbcat is offline   Reply With Quote
Old 30-06-2011, 02:06   #29
Registered User
 
HamishB's Avatar

Join Date: Jan 2010
Location: New Zealand
Posts: 286
Re: OpenCPN Version 2.4 Beta Build 628

Quote:
Originally Posted by bdbcat View Post
Your patch for TinyXML works fine, but.....
actually if it were for general consumption instead of removing the embedded .h and .ccp files from the make lists it should conditionalize and += them if needed. but I'm working in a controlled environment with that patch and so can get away with it.

Quote:
Its a bit of a chore to find and get the required packages.
They are not in very many default repos....
They are not in mine.

I found them here for debian:
Ubuntu -- Details of package libtinyxml-dev in maverick
Ubuntu -- Details of package libtinyxml2.5.3 in maverick

Note "Maverick".....
hmmm, in ubuntu since 10.10, in debian since squeeze:

Ubuntu -- Package Search Results -- tinyxml
Debian -- Package Search Results -- tinyxml

so for a general-use version of a patch (if one was desired) the library+includes would not be Required, and it would fall back to using the embedded version if the system one was not found..? :-/


Quote:
I dunno about rh.
me neither, but if the patterns follow the latest six-monthly FedoraCore might have it, but the latest RHEL & CentOS probably doesn't.

Quote:
Do we really need to do this?
in HEAD: nope, not at all.
in the debian build package: needed, but it doesn't have to concern you.

Quote:
Although experienced developers can do this stuff, it seems that the packager requirements are way ahead of average users.....
no argument on that point, just that the great payoff for all of the packaging sweat is a stable and strong greater OS for the end user who only sees the pre-built end result.

Quote:
I think that the goal should be for an "average" linux user to be able to say

Code:
$sudo apt-get install opencpn
and have it just do the right thing.
and that's exactly how it works. The debian packaging control file notes that the build depends on the libtinyxml-dev package, and during the build realizes that it needs to link against the library and so automatically sets up the package to depend on the libtinyxml2.5.3 package. When you do "apt-get install opencpn" it automatically knows that it needs to call in the tinyxml package too, and installs that for you.

Of course that is only relevant for OS versions where the library exists, but if the library doesn't exist the relevant package won't/can't depend on it anyway, so a bit of a moot point.

Quote:
On further testing, the only precompiled packages of TinyXML that I could find crashed for me....
what version/platform? how to trigger the crash? ubu 10.10 packages grafted into 10.04 LTS? (mixing OS versions is not likely to work anyway, especially not backwards)

what's an effective test for tinyxml? ie a test that touches both tinystr and tinyxml?
I tried exporting all to a XML file in debian/squeeze, all worked ok.
any ideas why tinystr would not be distributed along side tinyxml?
were there any local modifications to them?


Hamish
__________________
HamishB is offline   Reply With Quote
Old 30-06-2011, 03:23   #30
Registered User

Join Date: Dec 2005
Location: WNA
Boat: Dufour 35
Posts: 3,249
Re: OpenCPN Version 2.4 Beta Build 628

Quote:
Originally Posted by bdbcat View Post
HamishB....

On further testing, the only precompiled packages of TinyXML that I could find crashed for me....

What now?

Dave
Dave
Ubuntu updated the C library with 10.10 (Maverick), so a package compiled on 10.10 will probably not work with you 8.?.
Just out of curiosity, what happens i you try to install the latest beta i386 deb on your system?
Thomas
__________________

__________________
cagney is offline   Reply With Quote
Reply

Tags
opencpn

Thread Tools
Display Modes Rate This Thread
Rate This Thread:

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are Off
Pingbacks are Off
Refbacks are Off


Similar Threads
Thread Thread Starter Forum Replies Last Post
OpenCPN Version 2.4 Beta Build 620 bdbcat OpenCPN 33 28-06-2011 20:27



Copyright 2002- Social Knowledge, LLC All Rights Reserved.

All times are GMT -7. The time now is 20:44.


Google+
Powered by vBulletin® Version 3.8.8 Beta 1
Copyright ©2000 - 2017, vBulletin Solutions, Inc.
Social Knowledge Networks
Powered by vBulletin® Version 3.8.8 Beta 1
Copyright ©2000 - 2017, vBulletin Solutions, Inc.

ShowCase vBulletin Plugins by Drive Thru Online, Inc.