Visit our Popular Forums

jimbo3123 · 22-05-2010, 06:12

I've got a minor bug to report for the 5/20 release.
With quilting turned on, using ENC charts the translucent Feet/Meters display overlay in the top right corner always shows Meters, even when I set the chart to display feet.

It happens on both of my windows computers (one running WinXP, one Windows 7)

scotte · 22-05-2010, 07:39

Quote:

Originally Posted by jimbo3123

I've got a minor bug to report for the 5/20 release.
With quilting turned on, using ENC charts the translucent Feet/Meters display overlay in the top right corner always shows Meters, even when I set the chart to display feet.

Confirms post #529...

BluegillBoy · 22-05-2010, 08:16

OK, I found some trends that may shed light on the quilting problems with BSB charts. (XP, build 520a)

Charts that are skewed slightly positive (SK=0.0562481 for example) quilt fine. the chart shows as a blue bar at the bottom and the red slash shows in the bar as a warning. Just fine.

Charts that have a slight negative skew (SK=359.9924311 for example) show in the bar at the bottom with a skew warning but don't appear in the display except as a pink outline.

my guess is that you prevent charts with a large skew from quilting and set a "if SK>than X.XXX then don't quilt", but didn't allow for that 359.xxx skew as acceptable?

i confirmed this working all up the Wisconsin coast, NOAA RNC charts in the series 14901, 14903, 14904 and 14910. every chart in those folders (12 in all) with a positive skew quilts, every chart with a negative skew doesn't.

hope that helps fix it! I've gotten addicted to OCPN!!!!

cagney · 22-05-2010, 09:42

BluegillBoy
You're spot on in your conclusions. Searching a bit in the code I had a look at line 868 in chcanv.cpp

Code:

if(ChartData->GetDBChartSkew(i) < 1.0)                // only unskewed charts may be quilted....

I changed this to

Code:

if(ChartData->GetDBChartSkew(i) < 1.0 ||ChartData->GetDBChartSkew(i) > 359.0 )

Testing this on the chart folders you mentioned,
I specially looked at:
Chart 14903_1 with SK=359.9897549, and
Chart 14901_1 with SK=359.9924313
None of these charts quilted with the original code, both worked fine after compiling with my change.

Hopefully this will be included in the next beta.

Thomas

BluegillBoy · 22-05-2010, 15:51

Tremendous! Hope it comes soon too; I'm not a compiler myself, and cruising 4 days next weekend. Hope to test it.

thanks for the fix and all the hard work on this.

Psyches · 22-05-2010, 21:26

Quote:

Originally Posted by bdbcat

Hello...

Will the knowledgeable parties please give me an update on:

1. cross platform cmake script, including latest changes (gsv.cpp....)
Is the sourceforge patch tracker version accurate?

I'd like to get this into CVS, and eliminate the gnu build stuff and the native MSW/VS project. Any dependency problems? What version of cmake? etc, etc.....

2. Mac Build. Does it build? Does it run?

Thanks
Dave

Dave,

Fwiw, getting rid of vsproj build & combining/simplifying sounds great, but I haven't had time to try or track others progress. Sorry!

Mark

Netsurfer · 23-05-2010, 04:53

There is a bug in the Route Manager concerning the 'To' field.
When you have a route loaded with the correct values (from the properties window 'Depart from' and 'Destination') and you import another route, set the values in the properties window, then these values are shown in the line of the other route. The line of the actual route (where you added the values) is empty. In the properties window all values are still correct.

In other words:
The 'To' values are always shown just for one route/ track and that's not even the correct one.

It is a little bit difficult to explain but I hope you'll get me anyway.

And another point:
Added values in the fields 'Name', 'Depart from' and 'Destination' are not saved to the file. So you always have to export the route/ track to save the values. Maybe this could be changed?

Gunther

jpiebrig · 23-05-2010, 09:56

Hi Dave,

I have some charts which depth units are "Meters and decimeters". In this case the Depth Unit is not shown on the screen.

Jean-Pierre

cagney · 23-05-2010, 10:44

Depth Units isn't shown on the screen, because this case isn't covered in chartimg.cpp starting on line 1723.
It ought to be a simple change, to treat this case similar to the case "Fathoms and Feet", which displays "Fathoms" on the screen.
I can't recall having seen this depth unit before.
Of course, you can also edit the kap file directly, while you are waiting for the change in the next beta (?). Don't forget to run "bsbfix" if you do.
Thomas

Ptizef · 23-05-2010, 13:16

Quote:

Originally Posted by Netsurfer

There is a bug in the Route Manager concerning the 'To' field.
When you have a route loaded with the correct values (from the properties window 'Depart from' and 'Destination') and you import another route, set the values in the properties window, then these values are shown in the line of the other route. The line of the actual route (where you added the values) is empty. In the properties window all values are still correct.

In other words:
The 'To' values are always shown just for one route/ track and that's not even the correct one.

It is a little bit difficult to explain but I hope you'll get me anyway.
Gunther

I confirm this point .
Curiously ,I have the same problem as Gunther with the loaded compiled .exe file but not with the compiled by myself .exe file from cvs
you can see in shot 520-5 the two last lines are correct (myself compile from cvs) and in shot 520-6 the wrong same lines (loaded .exe file)
I use exactly the same environment
In addition , the loaded file is 5MB but my own compiled file is 3.97MB !

bdbcat · 23-05-2010, 15:59

Gunther:

Regarding your post 547:

Code:

 And another point:
Added values in the fields 'Name', 'Depart from' and 'Destination' are not saved to the file. So you always have to export the route/ track to save the values. Maybe this could be changed?

I think we do this now. At least it works for me. Or maybe I don't understand the question.....

Anyway, if you set Name, Depart, Destination.... in RouteProperties dialog, these settings are saved in the config file. They will be loaded from the config the next time you start opencpn, and assigned to this route.

Am I missing something?

Dave

bdbcat · 23-05-2010, 16:34

Hello...

CVS updated for Build 523a

Changelog (partial)

132. Correct Depth unit indicator in quilt mode.
133. Correct for chart skew values of both polarities.
134. Update chart info window for S57 ENCs.
135. Implement NMEA GGA sentence.
136. New Icons, thanks Will.
137. Correct quilt logic in Course-Up mode.
138. Correct StackUp/StackDown tool logic for quilting.
139. Correct for "Meters and decimeters" display
140. Correct RouteManager "To" field contents update.

Notes:

Especially interested in quilting anomalies, like Ptizef post #531.
Also, any "Fail to start" conditions, faults of any kind.....

135. Windows source builders will need to add gga.cpp and gga.hpp to VS project file. Testing of GGA sentence in real life would be good.

Real Beta maybe tomorrow....

Thanks, and good luck
Dave

Ptizef · 24-05-2010, 00:26

Hi Dave

523a loaded and built without any problem .
Many thanks again for all

just a precision I would like to give about start and end name .
1)no problem for "routes" , saved in .ini file , but not saved for "Tracks" in navobj file , so lost when you exiting opencpn , (the same for the invisible status)
2)not included for both in gpx exported files so lost when exporting and re-importing .

Test ongoing , but what to test exactly about GGA sentence (sorry for that beginner's question)

regards
Jean Pierre

Netsurfer · 24-05-2010, 02:04

Dave,

Quote:

Originally Posted by bdbcat

Gunther:
Regarding your post 547:

Code:

 And another point:
Added values in the fields 'Name', 'Depart from' and 'Destination' are not saved to the file. So you always have to export the route/ track to save the values. Maybe this could be changed?

I think we do this now. At least it works for me. Or maybe I don't understand the question.....

Anyway, if you set Name, Depart, Destination.... in RouteProperties dialog, these settings are saved in the config file. They will be loaded from the config the next time you start opencpn, and assigned to this route.

Am I missing something?

sorry, sometimes it is hard to explain things right in English.

Jean Pierre explained it in post 553 point 2.

So when you use the Route Manager in the way to often import, delete and re-import your routes/ tracks, the values get lost. Therefor it is a kind of Feature Request, to save these values (also) in the respective route/ track file.

And thanks again for all your work!

Gunther