Cruisers Forum
 


Join CruisersForum Today

Reply
 
Thread Tools Rate Thread Display Modes
Old 21-04-2016, 15:55   #16
Marine Service Provider
 
bdbcat's Avatar

Join Date: Mar 2008
Posts: 4,878
Re: OpenCpn Tide time 1 hour out

jp...

And what is the fix?

Dave
__________________

__________________
bdbcat is offline   Reply With Quote
Old 21-04-2016, 17:32   #17
Registered User

Join Date: Sep 2009
Location: Angers - France
Boat: Beneteau First 29 Ptizef
Posts: 743
Re: OpenCpn Tide time 1 hour out

Dave
the patch I have tested only with Windows :

@@ -106,6 +106,10 @@ TCWin::TCWin( ChartCanvas *parent, int x, int y, void *pvIDX )

int diff_mins = diff.GetMinutes();

+ //correct wxWidgets 3x bug
+ if( diff_mins == 0 && this_now.IsDST() )
+ diff_mins +=60;
+
int station_offset = ptcmgr->GetStationTimeOffset( pIDX );

m_corr_mins = station_offset - diff_mins;


Jean Pierre
__________________

__________________
Ptizef is offline   Reply With Quote
Old 22-04-2016, 03:44   #18
Registered User

Join Date: May 2012
Posts: 405
Re: OpenCpn Tide time 1 hour out

p_dub,

Pretty sure it is a wxWidgets 3.0.2 bug. When I use the same harmonics in O 4.0.0 and O 4.2.0 the error only happens with 4.2.0.

Mike
__________________
Rasbats is offline   Reply With Quote
Old 22-04-2016, 06:08   #19
Registered User

Join Date: Nov 2012
Location: Orust Sweden
Boat: Najad 34
Posts: 1,967
Re: OpenCpn Tide time 1 hour out

JP
On Win10

My timezone is UTC + 2
If I show a tide curve for a location in my own timezone the red line is on correct time.
If I show a tide curve for a location in a UTC+1 zone the red line is one hour late, compared to my PC-time.

I tested your proposed change without success, it's still the same differences.

Håkan
__________________
Hakan is offline   Reply With Quote
Old 23-04-2016, 02:00   #20
Registered User

Join Date: Sep 2009
Location: Angers - France
Boat: Beneteau First 29 Ptizef
Posts: 743
Re: OpenCpn Tide time 1 hour out

Hasan

Normally, the time shown in the graph are the time of the station, not the time of the PC
If your PC is +1 (+2 now are we are summer time) and you look at a UTC (+1 summer time) you will see Z+1 and the time will be shown accordingly and has always be like that
The problem I tried to correct is when the PC is set UTC ans summer time ( London for example)
Jean Pierre

Sent from my D5803 using Cruisers Sailing Forum mobile app
__________________
Ptizef is offline   Reply With Quote
Old 23-04-2016, 04:39   #21
Registered User

Join Date: May 2012
Posts: 405
Re: OpenCpn Tide time 1 hour out

jp,

Your patch works here (Windows). (London)(DST)

Mike
__________________
Rasbats is offline   Reply With Quote
Old 23-04-2016, 12:37   #22
Registered User

Join Date: Nov 2012
Location: Orust Sweden
Boat: Najad 34
Posts: 1,967
Re: OpenCpn Tide time 1 hour out

JP
Aha! My misunderstanding then.
Håkan
__________________
Hakan is offline   Reply With Quote
Old 24-04-2016, 21:17   #23
Marine Service Provider
 
bdbcat's Avatar

Join Date: Mar 2008
Posts: 4,878
Re: OpenCpn Tide time 1 hour out

Folks...

I have applied Ptizef's proposed patch to github master. Works for me.

AFAICT, wxWidgets timezone and DST handling is very inconsistent, and recently introduced "fixes" did not do much to correct the issues...

Thanks to all for the detailed analysis.
Dave
__________________
bdbcat is offline   Reply With Quote
Old 25-04-2016, 02:33   #24
Registered User
 
rgleason's Avatar

Join Date: Mar 2012
Location: Boston, MA
Boat: 1981 Bristol 32 Sloop
Posts: 9,320
Re: OpenCpn Tide time 1 hour out

Thanks bdbcat and others. May I make a request that some of you TIDE gurus take a look at the Tracker TIDE entries to see if they can be closed / combined/ dups/ fixed? Thanks.
__________________
rgleason is offline   Reply With Quote
Old 25-04-2016, 05:37   #25
Registered User
 
rgleason's Avatar

Join Date: Mar 2012
Location: Boston, MA
Boat: 1981 Bristol 32 Sloop
Posts: 9,320
Re: OpenCpn Tide time 1 hour out

Does this fix
FS#2058 : Tide curve displaced by one hour
__________________

__________________
rgleason is offline   Reply With Quote
Reply

Tags
enc, opencpn

Thread Tools
Display Modes Rate This Thread
Rate This Thread:

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are Off
Pingbacks are Off
Refbacks are Off


Similar Threads
Thread Thread Starter Forum Replies Last Post
Time an hour out from UTC conachair OpenCPN 2 24-03-2013 03:22
The "Time Bowl" Lexan Cased, O-ring Sealed, 24 hour Marine Chronometer Wireless1 Navigation 14 01-09-2012 14:24
OpenCPN Route Planning with Time and Tide PjotrC OpenCPN 14 28-11-2011 13:11
Currents: Scroll Through Hour-by-Hour Chart View prjacobs OpenCPN 8 27-08-2010 12:16



Copyright 2002- Social Knowledge, LLC All Rights Reserved.

All times are GMT -7. The time now is 03:59.


Google+
Powered by vBulletin® Version 3.8.8 Beta 1
Copyright ©2000 - 2017, vBulletin Solutions, Inc.
Social Knowledge Networks
Powered by vBulletin® Version 3.8.8 Beta 1
Copyright ©2000 - 2017, vBulletin Solutions, Inc.

ShowCase vBulletin Plugins by Drive Thru Online, Inc.