OpenCPN for Android Alpha test 4.1.427

[Ptizef]

Dave
Ok. This is not a central point.
I like the compromise : move by either icon

Jean Pierre

[CarCode]

Originally Posted by Ptizef

Anyway it has nothing to do with wxFormBuilder. What are the other adjustements you have to do?

wxFormBuilder generates buggy code for Mac OS X.
Please see the differences of same code for Windows and for Mac in these attachments.

Gerhard

[Ptizef]

Originally Posted by CarCode

wxFormBuilder generates buggy code for Mac OS X.
Please see the differences of same code for Windows and for Mac in these attachments.

Gerhard

Gerhard

Sorry but I still don't see what is the wrong code.
From your shot and the one attached from a W8.1 device ( but I get exactly the same with Vista and Linux), the only true difference except the specific OSX style is the spacer (line 789) you said having removed.

The reason of this spacer is to push back the transparency parameter to the bottom , whatever the numbers of parameters for the different data type assuming that the dialog has always the same hight related to the screen size. For example Pressure has less parameters than Wind so need less space. The extra space is taken by the spacer. I you use a big font size and there is not enough space, the dialog become scrollable.

wxFormBuilder is a complementary tool making very easy the dialogs definition, but don't focus on that, it must not be an obstacle.
Off course I'm ready to do my best but I really don't see what to do in this case.
Jean Pierre

[CarCode]

JP,
I often have had problems with code generated by wxFormBuilder for some plugins. Examples:
- Using wxADJUST_MINSIZE results in a crash.
- Asserts with wrong numbers for rows and cols of wxGridSizer or wxFlexGridSizer which can be avoided if only cols are used.
The wxWidgets docs say:

Usually only the number of columns in the flex grid sizer needs to be specified using cols argument. The number of rows will be deduced automatically depending on the number of the elements added to the sizer.

However you are correct, here are some other issues as well. Please check e.g. GribSettingsDialog::SetSettingsDialogSize(). It doesn't work as expected for Mac OS X. The window is far higher as in Windows or Linux and it doesn't adjust to the different length of the 3 pages.

There is also a typo in line 536 of GribSettingsDialog.cpp
scroll() should be Scroll()
Otherwise the Mac OS X function scroll() is refererenced.

Gerhard

[Ptizef]

Gerhard

1 ) there is no "wxADJUST_MINSIZE" in the plugin code
2 ) Please list the lines where you have problem with the sizer rows and lines number. I don't see what is different in the code and it has always been, and it is in the other part of O.
3) Please read carefully what I have written in #138 about the height of the setting dialog.
May be it's not satisfactory but for the moment it's not coded to adjust the height for each page but to adjust on the screen size (as it is in the option dialog)
4) Ok for line 536, I can suppress, it is useless. (old code)

Jean Pierre