OpenCPN Beta Version 3.3.2410 Released

[nkiesel]

Originally Posted by bdbcat

nkiesel...

San Mateo buoys...

I made a correction in the latest github.

Does the problem still exist?

Dave

This does not compile for me because of commit 4f98759 which changed code to unconditionally call UseAlpha which is no longer available in (Ubuntu's version of) wx-3.0. (change replaces #if condition around that with 1)

I reverted that single line change, and the resulting binary no longer has the problem. Good work! What was the bug/fix?

[rgleason]

San Mateo Issue
Now I am convinced it is a layering problem. Order of rendering.... background textures then bouys last.

Have now compiled the commits from last 3 of Dec 23 and Dec 24.
Will check again.

No. The problem still exists. I turn off opengl, shutdown, open opencpn,
turn on opengl, slow pan up to the bouys. ...the bouys don't show at all this time. I hit page up and the elements of the chart are redrawn in the proper order and the bouys show.

It is a layering problem, order of rendering.
Problem still exists in Windows.

Could add the two screenshots for you, but they'd be similar to the ones above. If you want them, let me know.

[jongough]

Pavel,
I have made a local change to allow me to compile and test some mods I have submitted. I have not pushed this changes up with the mods I have made, I just wanted to note that there was a change that may not work. The change in styles.cpp effectively comments out a version check of wxWidgets. The version check is for 2.9.4.

I will see if I can change back to version 2.8 of wxWidgets.

Jon

[nkiesel]

Originally Posted by jongough

Pavel,
I have made a local change to allow me to compile and test some mods I have submitted. I have not pushed this changes up with the mods I have made, I just wanted to note that there was a change that may not work. The change in styles.cpp effectively comments out a version check of wxWidgets. The version check is for 2.9.4.

I will see if I can change back to version 2.8 of wxWidgets.

Jon

I think that commit has to be reverted or reworked, because I can't see that we really want to drop support for wx-3.0 becuase of this. If anything, we should try to drop support for wx-2.8...

[nohal]

We never (officially) supported wx3.0 on Linux and Windows. If it's just a question of one #ifdef, the fix is trivial.

Pavel

[jongough]

It is a change to an ifdef, however, there are two files in the commit which was to try and fix a rendering issue. There is a co-requisite change to toolbar.cpp as well, so Dave may need to have another look at it.

Jon

Originally Posted by nohal

We never (officially) supported wx3.0 on Linux and Windows. If it's just a question of one #ifdef, the fix is trivial.

Pavel

[CarCode]

Happy Christmas.

The above commit doesn't hurt on Mac OS X which HAS TO compiled with wxWidgets >3.0.
However users are soon waiting now 2 years for a new stable version of OpenCPN...
Gerhard

[nohal]

As far as I can tell

diff --git a/src/styles.cpp b/src/styles.cpp
index 46930de..e15dce3 100644
--- a/src/styles.cpp
+++ b/src/styles.cpp
@@ -53,7 +53,7 @@ void bmdump(wxBitmap bm, wxString name)
 wxBitmap MergeBitmaps( wxBitmap back, wxBitmap front, wxSize offset )
 {
     wxBitmap merged( back.GetWidth(), back.GetHeight(), back.GetDepth() );
-#if 1 // (!wxCHECK_VERSION(2,9,4) && (defined(__WXGTK__) || defined(__WXMAC__)))
+#if !wxCHECK_VERSION(2,9,4)
 
     // Manual alpha blending for broken wxWidgets platforms.
     merged.UseAlpha();

should make everybody happy, assuming that wx3.0+ is not broken anymore on Linux and Windows, which I can't test...

Pavel

[nkiesel]

Originally Posted by jongough

It is a change to an ifdef, however, there are two files in the commit which was to try and fix a rendering issue. There is a co-requisite change to toolbar.cpp as well, so Dave may need to have another look at it.

Jon

Some googling and looking at the wx-3.0 files seems to indicate that the UseAlpha calls can simply be omitted for 3.0. So one approach would be to rework that commit to have explicit #if just around these.

[bdbcat]

rgleason...

Rick.

San Mateo
Please attach your logfile with recent OpenGL entries only.

Thanks
Dave

[nkiesel]

Originally Posted by nohal

Jon...
We don't support wx3.0 on Linux as it is still not available on all the mainstream distros, you will have to downgrade to wx2.8 (or put some more #ifdefs in place).

Pavel

Hmm, wx-3.0 used to work for me on Linux for quite some time now (and I removed wx-2.8 some time ago and nerv looked back). This `#if 1` in the source code anyway looks more like a hack than a real fix to me. The proposed

+#if !wxCHECK_VERSION(2,9,4)

would definitely work for me.

[bdbcat]

Folks...

Re wxBitmap::UseAlpha()...

Pavel has the right of it. It seems that alpha channel bitmap support is broken everywhere on wx2.8. We just did not notice it on Windows until I cleaned up the ghosts on the toolbar. Look carefully at the corners of the "Tide" toolbar icon when it is activated. You should "see" transparent pixels making the rounded corners. If you don't then let me know.

Alpha channel bitmap support clearly works on wx3.0.2 for Mac, which is the only wx3 platform we support. Probably OK on Win and linux, too. But right now we don't care about those. Next month maybe...

In github now...

Related comment: If you are building locally and submitting bug reports, please use the same wxWidgets library versions that we will use in production. We are looking for OCPN bugs, not wxWidgets bugs.

You know who you are.....


Thanks
Dave

[nkiesel]

I don't want to hijack this thread but I just tried to check the "wx-3.0 is not officially supported under Linux" on the ocpn web site but links like `http://opencpn.org/ocpn/compiling_source_windows` are broken. I see a Drupal error page instead. Anyone knows what's going on?

[nkiesel]

I got the following warning after a `git pull`:

/home/nkiesel/Projects/OpenCPN/po/opencpn_it_IT.po:4037: format specifications in 'msgid' and 'msgstr' for argument 1 are not the same
/usr/bin/msgfmt: found 1 fatal error

The lines there are

#: src/pluginmanager.cpp:692
#, c-format
msgid "PlugIn [ %s ] version %i.%i"
msgstr "%i.%i versione PlugIn [%s]"

I guess it does not like the argument reordering going on here.

[bdbcat]

nkiesel...

I "fixed" the Italian .po file.

In github now

Thanks
Dave