Cruisers Forum
 


Join CruisersForum Today

Reply
 
Thread Tools Rate Thread Display Modes
Old 04-03-2010, 05:26   #1
Registered User

Join Date: Feb 2010
Posts: 619
Colors and Segments in Tracks

As per description in the Feature Requests thread, attached is the source patch #6.

To keep it small, I did not do immediate redrawing of just closed track, so it will stay red until next screen refresh.

Piotr
Attached Files
File Type: doc navutil_patch6_cpp.txt.doc (7.2 KB, 67 views)
__________________

__________________
PjotrC is offline   Reply With Quote
Old 06-03-2010, 04:17   #2
Registered User

Join Date: Feb 2010
Posts: 619
Comment on patch sequence

For those, who are willing to try this (& other source patches from my little factory) I include the summary of previous patches. They need to be applied in sequence (#5 is missing and not needed - will be never published).

opencpn_patch_bob - Forums - Post 401932">AIS-IRJDSUNE9932123321222xxeww-&-IRJDSUNE9932123321222xxeww-Bells

patch2_pv - Forums - Post 403951">AIS-IRJDSUNE9932123321222xxeww-Pleasure-IRJDSUNE9932123321222xxeww-Vessel

patch2a_bel - bells bug fix
patch3_trk - track properties dialog (as above)

patch3a_trk - track properties bug fix

patch4_awr - anchor watch
patch4a_snd - anchor alarm (sound), as above

patch6_col_seg - colors&segments in tracks

If necessary, I will prepare the cumulative patch, but the smaller patches are easier to look at and evaluate. At least two people reported success in applying them in Vista environment, so I think it is a better arrangement. Also, these patches will become irrelevant with the next release of OCPN...
__________________

__________________
PjotrC is offline   Reply With Quote
Old 06-03-2010, 04:54   #3
Senior Cruiser
 
idpnd's Avatar

Cruisers Forum Supporter

Join Date: Sep 2007
Location: Almería, ES
Boat: Chiquita 46 - Libertalia
Posts: 1,551
I will try.. Shouldn't this go into the CVS or into the GIT server as a branch?
__________________
sv Libertalia
idpnd is offline   Reply With Quote
Old 06-03-2010, 06:15   #4
Senior Cruiser
 
idpnd's Avatar

Cruisers Forum Supporter

Join Date: Sep 2007
Location: Almería, ES
Boat: Chiquita 46 - Libertalia
Posts: 1,551
Got some errors on that sadly:

Code:
user@mariner:~/opencpn$ sudo make clean
test -z "opencpn" || rm -f opencpn
rm -f *.o
user@mariner:~/opencpn$ sudo make > make.txt
In file included from src/chart1.cpp:288:
././include/grib.h:83: warning: ‘typedef’ was ignored in this declaration
src/chart1.cpp: In member function ‘virtual int MyApp::OnExit()’:
src/chart1.cpp:1682: warning: cannot pass objects of non-POD type ‘class wxString’ through ‘...’; call will abort at runtime
src/chart1.cpp:1682: warning: cannot pass objects of non-POD type ‘class wxString’ through ‘...’; call will abort at runtime
src/chart1.cpp:1686: warning: cannot pass objects of non-POD type ‘class wxString’ through ‘...’; call will abort at runtime
src/chart1.cpp:1686: warning: cannot pass objects of non-POD type ‘class wxString’ through ‘...’; call will abort at runtime
src/chart1.cpp: In member function ‘void MyFrame::OnFrameTimer1(wxTimerEvent&)’:
src/chart1.cpp:3726: warning: cannot pass objects of non-POD type ‘class wxString’ through ‘...’; call will abort at runtime
src/chart1.cpp:3726: warning: cannot pass objects of non-POD type ‘class wxString’ through ‘...’; call will abort at runtime
src/chart1.cpp:3730: warning: cannot pass objects of non-POD type ‘class wxString’ through ‘...’; call will abort at runtime
src/chart1.cpp:3730: warning: cannot pass objects of non-POD type ‘class wxString’ through ‘...’; call will abort at runtime
src/chart1.cpp: In function ‘double AnchorDistFix(double, double, double)’:
src/chart1.cpp:6151: warning: suggest explicit braces to avoid ambiguous ‘else’
src/chart1.cpp:6155: warning: suggest explicit braces to avoid ambiguous ‘else’
src/chart1.cpp:6159: warning: control reaches end of non-void function
src/chart1.cpp: At global scope:
src/chart1.cpp:657: warning: ‘bells_sound_file_name’ defined but not used
In file included from src/chcanv.cpp:284:
././include/grib.h:83: warning: ‘typedef’ was ignored in this declaration
src/chcanv.cpp:2524: error: expected declaration before ‘}’ token
src/chcanv.cpp:406: warning: ‘mouse_leftisdown’ defined but not used
make: *** [chcanv.o] Error 1
__________________
sv Libertalia
idpnd is offline   Reply With Quote
Old 06-03-2010, 06:59   #5
Registered User

Join Date: Feb 2010
Posts: 619
I see you are at patch #4a

Did the previous sets compile OK? On Vista I only had the warning about AnchorDistFix control reaching end of non-void fn, which is true, but irrelevant, and no errors.

I have no Linux machine on hand to try...

Piotr
__________________
PjotrC is offline   Reply With Quote
Old 06-03-2010, 07:03   #6
Senior Cruiser
 
idpnd's Avatar

Cruisers Forum Supporter

Join Date: Sep 2007
Location: Almería, ES
Boat: Chiquita 46 - Libertalia
Posts: 1,551
Hehe!

Quote:
They need to be applied in sequence
I applied them in sequence (all patches) and then compiled.. This is the first set I am compiling as I have been on holiday without pc

The error is definitely in one of the chcanv.o patches isnt it.. Perhaps I didn't apply them right?

Edit: Perhaps I didn't apply the chcanv.h patch from patch_bob, I had to put them in manually as I didn't manage to execute the .txt file.
__________________
sv Libertalia
idpnd is offline   Reply With Quote
Old 06-03-2010, 10:39   #7
Registered User

Join Date: Feb 2010
Posts: 619
cumulative patch script

Perhaps the attached cumulative patch script will help to prevent omissions.

Please note that it also contains reference to two patches to file georef.c, provided in a post by HamishB about calculating Mercator distances.
Attached Files
File Type: doc patch_upto_6_seg.txt.doc (1.4 KB, 55 views)
__________________
PjotrC is offline   Reply With Quote
Old 06-03-2010, 11:29   #8
Senior Cruiser
 
idpnd's Avatar

Cruisers Forum Supporter

Join Date: Sep 2007
Location: Almería, ES
Boat: Chiquita 46 - Libertalia
Posts: 1,551
Thanks for your patience Pjotr, unfortunately I still get the same error having done everything from scratch - must be a linux issue?
__________________
sv Libertalia
idpnd is offline   Reply With Quote
Old 06-03-2010, 11:43   #9
Registered User

Join Date: Feb 2010
Posts: 619
I assume you are patching against the base 1.3.6 release as provided in sourceforge file opencpn-1.3.6.tar.bz2 ?
Besides this, I am aware of the 2 patches to georef.c and a patch to nmea.h, which I do not use.
__________________
PjotrC is offline   Reply With Quote
Old 06-03-2010, 11:46   #10
Senior Cruiser
 
idpnd's Avatar

Cruisers Forum Supporter

Join Date: Sep 2007
Location: Almería, ES
Boat: Chiquita 46 - Libertalia
Posts: 1,551
I am patching the current CVS download, I have also pulled in the hamish patch set but couldn't get it to work. I don't think that would have any impact on this error I'm getting?
__________________
sv Libertalia
idpnd is offline   Reply With Quote
Old 09-03-2010, 14:43   #11
Registered User

Join Date: Feb 2010
Posts: 619
This does not explain the current problem you are experiencing, but I have indeed omitted one simple file from the patch #6. It is attached here. Of course, it should be added to the cumulative patch script as well.

P.
Attached Files
File Type: txt navutil_patch6_h.txt (855 Bytes, 63 views)
__________________

__________________
PjotrC is offline   Reply With Quote
Reply

Thread Tools
Display Modes Rate This Thread
Rate This Thread:

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are Off
Pingbacks are Off
Refbacks are Off


Similar Threads
Thread Thread Starter Forum Replies Last Post
Hull Colors dheaslip Construction, Maintenance & Refit 60 26-10-2016 13:30
Lines, Sheets, Ropes and Colors MV Deck hardware: Rigging, Sails & Hoisting 46 20-06-2016 15:57
Colors and Sails MV General Sailing Forum 24 25-07-2008 20:06
Genoa tracks? bmiller General Sailing Forum 15 12-04-2006 17:02
Genoa tracks and rails. Alan Wheeler General Sailing Forum 6 23-02-2005 23:49



Copyright 2002- Social Knowledge, LLC All Rights Reserved.

All times are GMT -7. The time now is 15:45.


Google+
Powered by vBulletin® Version 3.8.8 Beta 1
Copyright ©2000 - 2017, vBulletin Solutions, Inc.
Social Knowledge Networks
Powered by vBulletin® Version 3.8.8 Beta 1
Copyright ©2000 - 2017, vBulletin Solutions, Inc.

ShowCase vBulletin Plugins by Drive Thru Online, Inc.