Calculator_pi New Finished Plugin for OpenCPN

[rgleason]

Originally Posted by Rasbats

Rasbats version 1.8 implements the cross-compiling suggested by SaltyPaws. Tested on Windows and Ubuntu 16.04.

https://github.com/Rasbats/calculator_pi/releases

Still working on the translations problem.

Mike

Great!

FYI Stelian sent me the following from my If win then xxx elseif linux questn. Also Wally was very helpful on this issue https://github.com/SaltyPaws/calculator_pi/issues/13

Hi Rick, You don't want to do this at runtime but at compile time, using conditional primitives (#ifdef...) So I would code something like:

#if defined(__LINUX__) ...
#elif defined(_WIN32) || defined(__WIN32__) || defined(WIN32) ...
#elif defined(__WXOSX__) ... (not really mac but wxwindows running on mac, maybe there is a better way
#else
#error Unknown platform
#endif Stelian.

[Hakan]

Originally Posted by Rasbats

The translation problem was because of the files being referenced in POTFILES.in. Hope I have not missed any important ones.

My 'calculator_pi.pot' file on GitHub should now be useable. Not pretty!
Mike

Crowdin's loaded with the new POT file. Existing translations so far in a PR. I'll schedule new Crowdin load in two weeks. Pls advice if needed earlier.
Håkan

[Gilletarom]

Hello All,

Pfuuuu .... What a disaster .... I just opened the crowdin. I saw that there is now 97% of the items to translate. .... But in reality, in the new crowdin language file, there are only 14 items ....

In reality, another nightmare is emerging. A large part of the existing items have disappeared ... And all their translations with ....



Gilletarom

[Rasbats]

Is it better to wait until Walbert has updated the SaltyPaws code and use his POT file?

Mike

[Gilletarom]

Originally Posted by Rasbats

Is it better to wait until Walbert has updated the SaltyPaws code and use his POT file?

Mike

If necessary, this is a good idea. Gilletarom

[Hakan]

Maybe I don't understand what's going on.....Are there two calculator_pi??
If so, why the same naming?

[rgleason]

Hakan,

Sorry, history

• SaltyPaws main repository.
• Rick compiled it for windows for a long time.
• SaltyPaws improved it but then it would not compile under Windows.
• Rasbats fixed it for windows on his repos.
• We are now working on melding the two versions into one with a cross compiling version.
• SaltyPaws just needs to accept Rasbats PR.

That is where we are now.

Hope that helps.

[Gilletarom]

Originally Posted by rgleason

Hakan,
Sorry, history

• SaltyPaws main repository.
• Rick compiled it for windows for a long time.
• SaltyPaws improved it but then it would not compile under Windows.
• Rasbats fixed it for windows on his repos.
• We are now working on melding the two versions into one with a cross compiling version.
• SaltyPaws just needs to accept Rasbats PR.

That is where we are now.
Hope that helps.

It's just a problem of patience on our part. It is obvious that it is enough if it allows to take the time to make a single version of the plugin.

Gilletarom

[skipperearly]

downloaded latest version calculator-pi 1.8 yesterday.
W10, ocpn 4.2.8 : always crashes e.g hull speed etc

Also, don't understand why we need 2 icons in the toolbar for this pi. seems overkill to me.

[skipperearly]

Originally Posted by skipperearly

downloaded latest version calculator-pi 1.8 yesterday.
W10, ocpn 4.2.8 : always crashes e.g hull speed etc

Also, don't understand why we need 2 icons in the toolbar for this pi. seems overkill to me.

did some more testing: crash is when preferences are set to precise - thousand seperator. Does not crash with precise (default)

[Rasbats]

skipperearly,

Thanks for the report. I have deleted the release details for the 1.8 version. 1.7 has exactly the same functions/calculations and works on 4.8.2 on my W8.1 machine. Investigating the problem.

Mike

[Rasbats]

Problem was started by a pull request. I have reverted that request. Source code should now be good for Win/Lin.

Mike

[Gilletarom]

Originally Posted by Rasbats

skipperearly,

Thanks for the report. I have deleted the release details for the 1.8 version. 1.7 has exactly the same functions/calculations and works on 4.8.2 on my W8.1 machine. Investigating the problem.

Mike

This is an old fault that I had already noticed.

[rgleason]

Using Rasbat's most recent cross compile code, compiling it, running with v4.8.2 under Win10. My compile available here
This work fine although there are some functions that result in an error. See Issues

My compile of Rasbats PR to SaltyPaws for Cross Compile complete the Hull Speed calc. see below.

The second Icon is very useful for controlling the Function Menu show/hide. Saves screen space. I like it. However you can control its appearance in both the menu and toolbar, from the preferenes.

SkipperEarly is this on Linux?

"did some more testing: crash is when preferences are set to precise - thousand seperator. Does not crash with precise (default)"

Interesting, there were a few changes for precision, by Wally in the code.

[rgleason]

I can confirm skipperearly's bug. Selecting thousands in the Preference window causes calculations to crash Opencpn.

Mike, check the recent changes made to precision, I think there was a change which came from SaltyPaws repos. #16 see line 710 (check for others?)