BSB4 plugin for V5

[bdbcat]

Rick, et al...


I build the BSB4_PI locally using VS2017, no trouble.
Uploaded to github Release point, available for download now.
https://opencpn.org/OpenCPN/plugins/bsb4.html


Don't know about appveyor build troubles, no time to investigate at the moment.


Dave

[Johnk]

Hi All


V5 now running with BA raster charts on both machines.


Many thanks


John

[rgleason]

Thanks Dave. I've fetched and merged yours.
When I compile the PI in standalone, the path to opencpn.lib is missed.


In my local build
build\CMakeCache.txt
Line 360 //Dependencies for the target
Line 361 bsb4_pi_LIB_DEPENDS:STATIC=general;C:/Projects/opencpn/build/$(Configuration)/opencpn.lib;debug;C...


When build is done in standalone, the pathname is different.

It would be something like C:\Users\Rick\Documents\GitHub\bsb4_pi\build\relea se
so perhaps a relative path would be better?


In CMakeLists.txt I changed Line 34 on this way
IF(WIN32)
SET(OPENCPN_IMPORT_LIB "C:/Users/Rick/Documents/Github/bsb4_pi/build/${CMAKE_CFG_INTDIR}/opencpn.lib")
TARGET_LINK_LIBRARIES( ${PACKAGE_NAME} ${OPENCPN_IMPORT_LIB} )
ENDIF(WIN32)


and it builds successfully.



This relative path works too (I had to take the ".lib" off because for some reason there was one added like this "opencpn.lib.lib"



SET(OPENCPN_IMPORT_LIB "../build/${CMAKE_CFG_INTDIR}/opencpn")



Sorry it took me so long to figure it out.

Do you want a PR?

[rgleason]

I made a mistake, found my local repository was not current. Pulled bdbcat's repository again and now it builds with no changes, just liike a charm.

Thank you Dave!


PS. But that is because the CMakeLists.txt change I made to a relative path, still exists.


PSS: I am not going to make a pull request because the appveyor build isn't working yet.. all the created files are landing in \build not \build\release\ and the relative path for opencp.lib is not working right.


So to summarize the CMake files need some Rx at some point.

[rgleason]

Appveyor built after it got the good path directions to opencpn.lib
https://ci.appveyor.com/project/rgle...uilds/24561450


I have this in my CMakeLists.txt file now


IF(WIN32)
# SET(OPENCPN_IMPORT_LIB "C:/Projects/opencpn/build/${CMAKE_CFG_INTDIR}/opencpn.lib") <---bdbcat inline build
# SET(OPENCPN_IMPORT_LIB "C:/Users/Rick/Documents/Github/bsb4_pi/build/${CMAKE_CFG_INTDIR}/opencpn.lib") <--works standalone for me
# SET(OPENCPN_IMPORT_LIB "../build/${CMAKE_CFG_INTDIR}/opencpn") <---locally standalone
# SET(OPENCPN_IMPORT_LIB "../build/opencpn") <---for Appveyor
SET(OPENCPN_IMPORT_LIB "../build/opencpn")
TARGET_LINK_LIBRARIES( ${PACKAGE_NAME} ${OPENCPN_IMPORT_LIB} )
ENDIF(WIN32)


So I think CMake could be improved.