Cruisers Forum
 


Join CruisersForum Today

Reply
 
Thread Tools Search this Thread Rate Thread Display Modes
Old 14-05-2019, 19:40   #16
Marine Service Provider
 
bdbcat's Avatar

Join Date: Mar 2008
Posts: 5,557
Re: BSB4 plugin for V5

Rick, et al...


I build the BSB4_PI locally using VS2017, no trouble.
Uploaded to github Release point, available for download now.
https://opencpn.org/OpenCPN/plugins/bsb4.html


Don't know about appveyor build troubles, no time to investigate at the moment.


Dave
__________________

bdbcat is online now   Reply With Quote
Old 15-05-2019, 02:22   #17
Registered User

Join Date: Jan 2013
Posts: 6
Re: BSB4 plugin for V5

Hi All


V5 now running with BA raster charts on both machines.


Many thanks


John
__________________

Johnk is offline   Reply With Quote
Old 15-05-2019, 04:44   #18
Registered User
 
rgleason's Avatar

Join Date: Mar 2012
Location: Boston, MA
Boat: 1981 Bristol 32 Sloop
Posts: 12,639
Re: BSB4 plugin for V5

Thanks Dave. I've fetched and merged yours.
When I compile the PI in standalone, the path to opencpn.lib is missed.


In my local build
build\CMakeCache.txt
Line 360 //Dependencies for the target
Line 361 bsb4_pi_LIB_DEPENDS:STATIC=general;C:/Projects/opencpn/build/$(Configuration)/opencpn.lib;debug;C...


When build is done in standalone, the pathname is different.

It would be something like C:\Users\Rick\Documents\GitHub\bsb4_pi\build\relea se
so perhaps a relative path would be better?


In CMakeLists.txt I changed Line 34 on this way
IF(WIN32)
SET(OPENCPN_IMPORT_LIB "C:/Users/Rick/Documents/Github/bsb4_pi/build/${CMAKE_CFG_INTDIR}/opencpn.lib")
TARGET_LINK_LIBRARIES( ${PACKAGE_NAME} ${OPENCPN_IMPORT_LIB} )
ENDIF(WIN32)


and it builds successfully.



This relative path works too (I had to take the ".lib" off because for some reason there was one added like this "opencpn.lib.lib"



SET(OPENCPN_IMPORT_LIB "../build/${CMAKE_CFG_INTDIR}/opencpn")



Sorry it took me so long to figure it out.

Do you want a PR?
rgleason is offline   Reply With Quote
Old 15-05-2019, 05:00   #19
Registered User
 
rgleason's Avatar

Join Date: Mar 2012
Location: Boston, MA
Boat: 1981 Bristol 32 Sloop
Posts: 12,639
Re: BSB4 plugin for V5

I made a mistake, found my local repository was not current. Pulled bdbcat's repository again and now it builds with no changes, just liike a charm.

Thank you Dave!


PS. But that is because the CMakeLists.txt change I made to a relative path, still exists.


PSS: I am not going to make a pull request because the appveyor build isn't working yet.. all the created files are landing in \build not \build\release\ and the relative path for opencp.lib is not working right.


So to summarize the CMake files need some Rx at some point.
rgleason is offline   Reply With Quote
Old 15-05-2019, 05:33   #20
Registered User
 
rgleason's Avatar

Join Date: Mar 2012
Location: Boston, MA
Boat: 1981 Bristol 32 Sloop
Posts: 12,639
Re: BSB4 plugin for V5

Appveyor built after it got the good path directions to opencpn.lib
https://ci.appveyor.com/project/rgle...uilds/24561450


I have this in my CMakeLists.txt file now


IF(WIN32)
# SET(OPENCPN_IMPORT_LIB "C:/Projects/opencpn/build/${CMAKE_CFG_INTDIR}/opencpn.lib") <---bdbcat inline build
# SET(OPENCPN_IMPORT_LIB "C:/Users/Rick/Documents/Github/bsb4_pi/build/${CMAKE_CFG_INTDIR}/opencpn.lib") <--works standalone for me
# SET(OPENCPN_IMPORT_LIB "../build/${CMAKE_CFG_INTDIR}/opencpn") <---locally standalone
# SET(OPENCPN_IMPORT_LIB "../build/opencpn") <---for Appveyor
SET(OPENCPN_IMPORT_LIB "../build/opencpn")
TARGET_LINK_LIBRARIES( ${PACKAGE_NAME} ${OPENCPN_IMPORT_LIB} )
ENDIF(WIN32)


So I think CMake could be improved.
__________________

rgleason is offline   Reply With Quote
Reply

Tags
bsb, plug

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes Rate This Thread
Rate This Thread:

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are Off
Pingbacks are Off
Refbacks are Off


Similar Threads
Thread Thread Starter Forum Replies Last Post
BsB4 plugin for Linux? jakobcornelis OpenCPN 6 01-06-2017 09:12
BSB4 Plugin problem lake_fever OpenCPN 1 02-06-2015 21:47
4.0, skewed chart, OpenGL, BSB4 plugin bobofthenorth OpenCPN 9 05-03-2015 08:07
BSB4 plugin chs windows 8.1 Courtship OpenCPN 39 16-07-2014 11:11
Cannot activate BSB4 Plugin Grainne OpenCPN 8 28-10-2013 13:25



Copyright 2002- Social Knowledge, LLC All Rights Reserved.

All times are GMT -7. The time now is 22:08.


Google+
Powered by vBulletin® Version 3.8.8 Beta 1
Copyright ©2000 - 2019, vBulletin Solutions, Inc.
Social Knowledge Networks
Powered by vBulletin® Version 3.8.8 Beta 1
Copyright ©2000 - 2019, vBulletin Solutions, Inc.

ShowCase vBulletin Plugins by Drive Thru Online, Inc.