Beta Test / Technical

[Baikal]

Particle map in grib plugin do not work OCPN 4.1.427 (VS2013, WXW3, Windows x64)
I make a video screen
https://www.dropbox.com/s/j6rpfwwn2k...leMap.mp4?dl=0

[ChuckSK]

Originally Posted by Baikal

Particle map in grib plugin do not work OCPN 4.1.427 (VS2013, WXW3, Windows x64)
I make a video screen
https://www.dropbox.com/s/j6rpfwwn2k...leMap.mp4?dl=0

Try this.

diff --git a/plugins/grib_pi/src/GribOverlayFactory.cpp b/plugins/grib_pi/src/GribOverlayFactory.cpp
index 0689f73..8e47fb9 100644
--- a/plugins/grib_pi/src/GribOverlayFactory.cpp
+++ b/plugins/grib_pi/src/GribOverlayFactory.cpp
@@ -1610,7 +1610,7 @@ void GRIBOverlayFactory::RenderGribParticles( int settings, GribRecord **pGR,
         total_particles = 60000;
 
     // remove particles if needed;
-    int remove_particles = (particles.size() - total_particles) / 16;
+    int remove_particles = ((int)particles.size() - total_particles) / 16;
     for(int i = 0; i<remove_particles; i++)
         particles.pop_back();

[jongough]

Rick,
This issue is caused by a change in the 1.13 API. I have fixed up the issue, but you need to look in the CMakeList.txt file and make sure you are running VERSION_MINOR="3" AND VERSION_PATCH="0003" but "0050" would be better as this is the latest and fixes up some other issues.

If you look in the log when ocpn_draw_pi is loaded you should see:

PlugIn Version detected: 3


Jon

Originally Posted by rgleason

Found out ocpn_draw enabled was causing v4.1.427 instant crash, disable it and opencpn 4.1.427 loads ok using v4.0 opencpn.ini. So I don't believe dedicated opencpn.ini for the two versions is needed.
Ocpn_draw failing on changes in log file

Sent from my SCH-I545 using Cruisers Sailing Forum mobile app

[jongough]

Hi,
Under Linux I am now getting some assert errors when running OCPN 4.1.427. I get the following traceback when clicking on the 'Setup/Options' icon in the toolbar:

A
SSERT INFO:
../src/generic/listctrl.cpp(3367): assert "litem >= 0 && (size_t)litem < GetItemCount()" failed in SetItemState(): invalid list ctrl item index in SetItem

BACKTRACE:
[1] wxGenericListCtrl::SetItemState(long, long, long)
[2] wxSizer::Add(wxWindow*, int, int, int, wxObject*) /usr/include/wx-3.0/wx/sizer.h:1152
[3] options::CreateControls() /data/public/working area/opencpn/remote/jongough/clean/src/options.cpp:3084
[4] options::options(MyFrame*, int, wxString const&, wxPoint const&, wxSize const&, long) /data/public/working area/opencpn/remote/jongough/clean/src/options.cpp:870
[5] MyFrame::DoOptionsDialog() /data/public/working area/opencpn/remote/jongough/clean/src/chart1.cpp:4707
[6] MyFrame::DoSettings() /data/public/working area/opencpn/remote/jongough/clean/src/chart1.cpp:3887
[7] MyFrame::OnToolLeftClick(wxCommandEvent&) /data/public/working area/opencpn/remote/jongough/clean/src/chart1.cpp:3698
[8] wxAppConsoleBase::CallEventHandler(wxEvtHandler*, wxEventFunctor&, wxEvent&) const
[9] wxEvtHandler::ProcessEventIfMatchesId(wxEventTableEntryBase const&, wxEvtHandler*, wxEvent&)
[10] wxEventHashTable::HandleEvent(wxEvent&, wxEvtHandler*)
[11] wxEvtHandler::TryHereOnly(wxEvent&)
[12] wxEvtHandler::DoTryChain(wxEvent&)
[13] wxEvtHandler::ProcessEvent(wxEvent&)
[14] wxWindowBase::TryAfter(wxEvent&)
[15] wxEvtHandler::ProcessPendingEvents()
[16] wxAppConsoleBase::ProcessPendingEvents()
[17] wxApp::DoIdle()
[18] g_main_context_dispatch
[19] g_main_loop_run
[20] gtk_main
[21] wxGUIEventLoop::DoRun()
[22] wxEventLoopBase::Run()
[23] wxAppConsoleBase::MainLoop()
[24] wxEntry(int&, wchar_t**)
[25] main /data/public/working area/opencpn/remote/jongough/clean/src/chart1.cpp:795
[26] __libc_start_main
[27] _start

Jon

[bdbcat]

Hakan...

re:

Though, if I let the tools function "recreate cache" (or how it's named  in English) build the new cache the bad colors are partly there again.

Fixed in github now. You will need another cache rebuild.

Thanks. keep the bugs coming. Saves a lot of trouble when we start Beta.

Dave

[Baikal]

what kind of switch in the options interface?

CPN does not read S-57 charts, CM93 boot normally
After restarting the CPN reset all the settings of vector maps

[CarCode]

Originally Posted by bdbcat

Fixed in github now. You will need another cache rebuild.

Thanks. keep the bugs coming. Saves a lot of trouble when we start Beta.

Dave

Please check line 1 of plugins/grib_pi/src/GribOverlayFactory.cpp

Gerhard

[bdbcat]

Gerhard...

Wow. Wonder how that happened?

Anyway, fixed now.

Thanks
Dave

[jongough]

Hi,
In the current beta (4.1.427) with the introduction of the new 'OnToolbarToolDownCallback' & 'OnToolbarToolUpCallback' functions the 'SetToolbarItemState' function locks the screen as there is an assert error:

ASSERT INFO:
../src/common/tbarbase.cpp(86): assert "CanBeToggled()" failed in Toggle(): can't toggle this tool

BACKTRACE:
[1] wxToolBarToolBase::Toggle(bool)
[2] ocpnToolBarSimple::ToggleTool(int, bool) /data/public/working area/opencpn/remote/jongough/clean/src/toolbar.cpp:2014
[3] ocpn_draw_pi::OnToolbarToolDownCallback(int)
[4] ocpnToolBarSimple::OnMouseEvent(wxMouseEvent&) /data/public/working area/opencpn/remote/jongough/clean/src/toolbar.cpp:1703
[5] wxAppConsoleBase::CallEventHandler(wxEvtHandler*, wxEventFunctor&, wxEvent&) const
[6] wxEvtHandler::ProcessEventIfMatchesId(wxEventTableEntryBase const&, wxEvtHandler*, wxEvent&)
[7] wxEventHashTable::HandleEvent(wxEvent&, wxEvtHandler*)
[8] wxEvtHandler::TryHereOnly(wxEvent&)
[9] wxEvtHandler::ProcessEventLocally(wxEvent&)
[10] wxEvtHandler::ProcessEvent(wxEvent&)
[11] wxEvtHandler::SafelyProcessEvent(wxEvent&)
[12] g_closure_invoke
[13] g_signal_emit_valist
[14] g_signal_emit
[15] gtk_propagate_event
[16] gtk_main_do_event
[17] g_main_context_dispatch
[18] g_main_loop_run
[19] gtk_main
[20] wxGUIEventLoop::DoRun()
[21] wxEventLoopBase::Run()
[22] wxAppConsoleBase::MainLoop()
[23] wxEntry(int&, wchar_t**)
[24] main /data/public/working area/opencpn/remote/jongough/clean/src/chart1.cpp:803
[25] __libc_start_main
[26] _start

I have removed the statements to allow the program to run, but I cannot set the button pressed on the toolbar.

Jon

[.Paul.]

In the right-click "Center View..." window, I cannot edit the entries in the Latitude and Longitude fields using the keyboard. The initial entry of digits, "n", "s", space, etc. is okay, but backspace, and other editing fails.

Lat and Lon are picked up from clipboard, but not edited from the keyboard. This can be done multiple times in a session in O, but keyboard entry cannot be done after the first [right-click] "Center View...". Exit and restart O allows one-time keyboard entry into "Center View...".

Compiled from second master 4.1.427 from github yesterday (22 May) using Win 8.1, VS2013, wxWidgets 3.0.2 .


Paul

[bdbcat]

Baikal...

Most of your indicated bugs fixed in current github.

There is a new icon set for the toolbar manipulation tool, the "Grabber". To see the new toobar "Grabber" icon, you must copy the uidata directory from the source tree into your local build directory, as mentioned in the Windows build instructions.

The UI for the toolbar grabber changed as well.
1. Left click to hide toolbar.
2. Right click to switch to 4-way drag arrow.
3. Single left click on 4-way arrow toggles orientation.
4. Right click on 4-way arrow switches back to grabber.


I did not understand the first point in your video... More info, please?


Thanks for the reports.
Dave

[bdbcat]

jon...

Tool toggle assert fixed in github.

Please test and report.

Thanks
Dave

[rgleason]

Trying to reconfig for v4.1.427 compile. Found I had a wxWidgets2.8.12 problem...
Have changed all my Environment Path to point to wxWidgets 3.0.2 and rebooted and have removed OpenCPN locally and cloned again. Now cmake is showing wxWidgets 3.0.2 paths correctly, but there is some other problem in the window below.

Is there an easy fix, or should I upgrade Cmake and VS to 2013 and start that over? Thanks.

PS I am keeping the wxWidget 2.8.12 setup on my other computer to be able to compile O 3.2.2 and 4.0 and those versions of the plugins.

PSS Followed these two github links to update the "upstream" worked very nicely.
https://help.github.com/articles/syncing-a-fork/
https://help.github.com/articles/fork-a-repo/

[Baikal]

Originally Posted by bdbcat

Baikal...
I did not understand the first point in your video... More info, please?

With the rapid and the usual pan hangs at which kind of goes back to the previous step pan.

It is also observed decrease in performance may hang when panning because of this.

And the most important thing he noticed recently spot soundings on the S-57 charts are not in their places. At different charts of different displacement met the offset up to 30 meters. This issue also features in release 4.0
The image and the original ENC as it appears in CPN

[Baikal]

a test piece of S57 chart to reproduce the problem with depth soundings
52 15.0623 N 104 22.0013 E
https://www.dropbox.com/sh/5bp3i9d3i...su6sV64za?dl=0